From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:37145 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753101AbdEUMR4 (ORCPT ); Sun, 21 May 2017 08:17:56 -0400 Subject: Re: [PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102 To: Jan Kiszka Cc: linux-iio@vger.kernel.org, Linux Kernel Mailing List , Sascha Weisenberger , Andy Shevchenko , Mika Westerberg , Peter Meerwald-Stadler , Rob Herring References: <9eae4928-c278-62e5-05d1-728326aad45b@kernel.org> <9f60dc23-6ba1-335a-d95b-870cdd250539@siemens.com> From: Jonathan Cameron Message-ID: Date: Sun, 21 May 2017 13:17:53 +0100 MIME-Version: 1.0 In-Reply-To: <9f60dc23-6ba1-335a-d95b-870cdd250539@siemens.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 21/05/17 12:59, Jan Kiszka wrote: > On 2017-05-21 12:47, Jonathan Cameron wrote: >> On 17/05/17 16:28, Jan Kiszka wrote: >>> This is an upstream port of an IIO driver for the TI ADC108S102 and >>> ADC128S102. The former can be found on the Intel Galileo Gen2 and the >>> Siemens SIMATIC IOT2000. For those boards, ACPI-based enumeration is >>> included. >>> >>> Due to the lack of regulators under ACPI, we hard-code the voltage >>> provided to the VA pin of the ADC to 5 V, the value used on Galileo and >>> IOT2000. For DT usage, the regulator "vref-supply" provides this >>> information. Note that DT usage has not been tested. >>> >>> Original author: Bogdan Pricop >>> Ported from Intel Galileo Gen2 BSP to Intel Yocto kernel: >>> Todor Minchev . >>> >>> Signed-off-by: Jan Kiszka >> Still an issue wrt to it being obviously correct in the ordering in probe >> and remove. >> >> As a reviewer I want to be able to run through each step in probe and >> compare with remove to ensure they occur in the opposite order and >> reverse all the steps in probe. Where ever it deviates from that I have >> to think about it and we all know the last thing a reviewer with a big >> backlog of patches wants to do is to think hard ;) >> >> Anyhow, I've fixed up and applied to the togreg branch of iio.git and >> pushed out as testing for the autobuilders to play with it. >> >> Please check I haven't made a mess of it. > > Forgot to push? Not finding it in togreg, which is 5 days old. > As it says, pushed out as testing... Togreg is non rebasing so only gets pushed out publicly once all the trivial stuff the autobuilders find has been sorted. Depending on how busy I am it can be a few days before I get a chance to push out togreg, whereas testing goes every few patches when I'm merging stuff. Thanks, Jonathan > Jan >