From: Krzysztof Kozlowski <krzk@kernel.org>
To: Darius Berghe <darius.berghe@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jic23@kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: iio: adis16480: add devices to adis16480
Date: Fri, 8 Nov 2024 11:43:14 +0100 [thread overview]
Message-ID: <f19d96a8-8f67-4aa6-a3c6-f850cbbfb109@kernel.org> (raw)
In-Reply-To: <20241107134517.3089112-4-darius.berghe@analog.com>
On 07/11/2024 14:45, Darius Berghe wrote:
> Add the adis16486, adis16487 and adis16489 Six Degrees
> of Freedom Inertial Sensors to the list of compatible devices
> of the adis16480 iio subsystem driver.
>
> adis16486 is similar to adis16485, has the exact same channels
> but acceleration and delta velocity scales are different.
>
> adis16487 is fallback compatible with adis16485.
This was never tested - visible easily from the diff. No need to ask
reviewers to do the tools job. Tools are for that.
<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.
Please kindly resend and include all necessary To/Cc entries.
</form letter>
Best regards,
Krzysztof
prev parent reply other threads:[~2024-11-08 10:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 13:45 [PATCH v2 0/3] iio: imu: add devices to adis16480 driver Darius Berghe
2024-11-07 13:45 ` [PATCH v2 1/3] iio: imu: adis16480: " Darius Berghe
2024-11-07 13:45 ` [PATCH v2 2/3] iio: imu: adis16480: add devices to adis16480 - docs Darius Berghe
2024-11-07 13:45 ` [PATCH v2 3/3] dt-bindings: iio: adis16480: add devices to adis16480 Darius Berghe
2024-11-08 10:43 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f19d96a8-8f67-4aa6-a3c6-f850cbbfb109@kernel.org \
--to=krzk@kernel.org \
--cc=darius.berghe@analog.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox