From: Jonathan Cameron <jic23@kernel.org>
To: Brian Masney <masneyb@onstation.org>, linux-iio@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
lars@metafoo.de, pmeerw@pmeerw.net, knaack.h@gmx.de,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, Mark.Rutland@arm.com
Subject: Re: [PATCH 01/10] staging: iio: tsl2583: add of_match table for device tree support
Date: Sun, 30 Oct 2016 17:44:52 +0000 [thread overview]
Message-ID: <f2835bec-c819-cd1d-aaa0-4aef0b42e6f6@kernel.org> (raw)
In-Reply-To: <246d8513-3505-31cd-4cfa-4f2c2e9266d8@kernel.org>
On 30/10/16 17:43, Jonathan Cameron wrote:
> On 28/10/16 11:00, Brian Masney wrote:
>> Add device tree support for the tsl2583 IIO driver with no custom
>> properties.
>>
>> Signed-off-by: Brian Masney <masneyb@onstation.org>
> Trivial enough that I feel I can take this without an explicit devicetree
> ack. Of course one is always welcome if anyone gets a chance to look at it.
> I won't have it exposed in a non rebasing tree until perhaps the second half
> of the week.
oops. Forgot to say - applied to the togreg branch of iio.git - initially pushed
out as testing for the autobuilders to play with it.
Thanks,
Jonathan
>> ---
>> .../devicetree/bindings/iio/light/tsl2583.txt | 26 ++++++++++++++++++++++
>> drivers/staging/iio/light/tsl2583.c | 13 +++++++++++
>> 2 files changed, 39 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/iio/light/tsl2583.txt
>>
>> diff --git a/Documentation/devicetree/bindings/iio/light/tsl2583.txt b/Documentation/devicetree/bindings/iio/light/tsl2583.txt
>> new file mode 100644
>> index 0000000..8e2066c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/light/tsl2583.txt
>> @@ -0,0 +1,26 @@
>> +* TAOS TSL 2580/2581/2583 ALS sensor
>> +
>> +Required properties:
>> +
>> + - compatible: Should be one of
>> + "amstaos,tsl2580"
>> + "amstaos,tsl2581"
>> + "amstaos,tsl2583"
>> + - reg: the I2C address of the device
>> +
>> +Optional properties:
>> +
>> + - interrupt-parent: should be the phandle for the interrupt controller
>> + - interrupts: the sole interrupt generated by the device
>> +
>> + Refer to interrupt-controller/interrupts.txt for generic interrupt client
>> + node bindings.
>> +
>> + - vcc-supply: phandle to the regulator that provides power to the sensor.
>> +
>> +Example:
>> +
>> +tsl2581@29 {
>> + compatible = "amstaos,tsl2581";
>> + reg = <0x29>;
>> +};
>> diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
>> index 08f1583..fd4b6ef 100644
>> --- a/drivers/staging/iio/light/tsl2583.c
>> +++ b/drivers/staging/iio/light/tsl2583.c
>> @@ -947,11 +947,24 @@ static struct i2c_device_id taos_idtable[] = {
>> };
>> MODULE_DEVICE_TABLE(i2c, taos_idtable);
>>
>> +#ifdef CONFIG_OF
>> +static const struct of_device_id taos2583_of_match[] = {
>> + { .compatible = "amstaos,tsl2580", },
>> + { .compatible = "amstaos,tsl2581", },
>> + { .compatible = "amstaos,tsl2583", },
>> + { },
>> +};
>> +MODULE_DEVICE_TABLE(of, taos2583_of_match);
>> +#else
>> +#define taos2583_of_match NULL
>> +#endif
>> +
>> /* Driver definition */
>> static struct i2c_driver taos_driver = {
>> .driver = {
>> .name = "tsl2583",
>> .pm = TAOS_PM_OPS,
>> + .of_match_table = taos2583_of_match,
>> },
>> .id_table = taos_idtable,
>> .probe = taos_probe,
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-10-30 17:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 10:00 [PATCH 00/10] staging: iio: tsl2583: staging cleanups Brian Masney
2016-10-28 10:00 ` [PATCH 01/10] staging: iio: tsl2583: add of_match table for device tree support Brian Masney
2016-10-30 17:43 ` Jonathan Cameron
2016-10-30 17:44 ` Jonathan Cameron [this message]
2016-10-31 6:06 ` Rob Herring
2016-10-28 10:00 ` [PATCH 02/10] staging: iio: tsl2583: check for error code from i2c_smbus_read_byte() Brian Masney
2016-10-30 17:49 ` Jonathan Cameron
2016-10-28 10:00 ` [PATCH 03/10] staging: iio: tsl2583: return proper error code instead of -1 Brian Masney
2016-10-30 17:50 ` Jonathan Cameron
2016-10-28 10:00 ` [PATCH 04/10] staging: iio: tsl2583: remove redundant power_state sysfs attribute Brian Masney
2016-10-30 17:51 ` Jonathan Cameron
2016-10-28 10:00 ` [PATCH 05/10] staging: iio: tsl2583: check return values from taos_chip_{on,off} Brian Masney
2016-10-30 17:54 ` Jonathan Cameron
2016-10-28 10:00 ` [PATCH 06/10] staging: iio: tsl2583: convert to use iio_chan_spec and {read,write}_raw Brian Masney
2016-10-30 18:04 ` Jonathan Cameron
2016-10-28 10:00 ` [PATCH 07/10] staging: iio: tsl2583: convert illuminance0_calibscale sysfs attr to use iio_chan_spec Brian Masney
2016-10-30 18:37 ` Jonathan Cameron
2016-10-30 20:04 ` Brian Masney
2016-10-30 20:29 ` Jonathan Cameron
2016-10-28 10:00 ` [PATCH 08/10] staging: iio: tsl2583: use IIO_*_ATTR* macros to create sysfs entries Brian Masney
2016-10-30 18:38 ` Jonathan Cameron
2016-10-28 10:00 ` [PATCH 09/10] staging: iio: tsl2583: add error code to sysfs store functions Brian Masney
2016-10-30 18:39 ` Jonathan Cameron
2016-10-28 10:00 ` [PATCH 10/10] staging: iio: tsl2583: add locking to sysfs attributes Brian Masney
2016-10-30 18:43 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2835bec-c819-cd1d-aaa0-4aef0b42e6f6@kernel.org \
--to=jic23@kernel.org \
--cc=Mark.Rutland@arm.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).