Linux IIO development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>, jic23@kernel.org
Cc: linux-iio@vger.kernel.org, lorenzo.bianconi@redhat.com,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH 2/2] dt-bindings: iio: imu: st_lsm6dsx: add asm330lhb
Date: Tue, 7 Mar 2023 10:10:31 +0100	[thread overview]
Message-ID: <f2bbda1a-b6e3-ccbb-d77a-8bdb42aca0ee@linaro.org> (raw)
In-Reply-To: <fecf1f20cc8e99fb8654cc733f14bd449ca7f87a.1678100533.git.lorenzo@kernel.org>

On 06/03/2023 12:08, Lorenzo Bianconi wrote:
> Add device bindings for asm330lhb IMU sensor.
> Use asm330lhh as fallback device for asm330lhb since it implements all
> the features currently supported by asm330lhb.
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>  Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml b/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> index decf022335d8..b39f5217d8ff 100644
> --- a/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> @@ -46,6 +46,9 @@ properties:
>        - items:
>            - const: st,ism330is
>            - const: st,lsm6dso16is
> +      - items:
> +          - const: st,asm330lhb
> +          - const: st,asm330lhh

You added it to the end of the list, but aren't there any ordering
already? If so, it should be put rather in correct place.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof


  reply	other threads:[~2023-03-07  9:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 11:07 [PATCH 0/2] add support for ASM330LHB Lorenzo Bianconi
2023-03-06 11:08 ` [PATCH 1/2] iio: imu: st_lsm6dsx: add support to ASM330LHB Lorenzo Bianconi
2023-03-06 11:08 ` [PATCH 2/2] dt-bindings: iio: imu: st_lsm6dsx: add asm330lhb Lorenzo Bianconi
2023-03-07  9:10   ` Krzysztof Kozlowski [this message]
2023-03-09  9:57     ` Lorenzo Bianconi
2023-03-12 15:57       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2bbda1a-b6e3-ccbb-d77a-8bdb42aca0ee@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=lorenzo@kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox