From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f45.google.com (mail-oo1-f45.google.com [209.85.161.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C6EA17A30E for ; Thu, 17 Apr 2025 17:07:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744909664; cv=none; b=K/q6dv/0Kfh4MtO49eOACK2fAA4xsRDuTOY6mKHJu0MrDZ19Ij96Vv9/6627vLnKfEymvyYokOmv/eVsYquV1q3JZokvwUYKavZLEH+Lmz26uJjsqHIAUm16CFDx3Glc8XZ9sD85SzjOjySYycgSVFCaDQsyBj6NXaQwpqoJHk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744909664; c=relaxed/simple; bh=QTblW1Gq1v1BLqv3bQj+TbvXE9AnXYXO/4GsN9Rn0IE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MEBvMbjawH++LEiPwFdNnpbOlvSB5ADpj06by2gktdq2lKXHbFhbrzJgQ7h33lqkGK2fRjoNm9wr1by2q2C73P8UFxFfvDqBIyDif+dZIRC5iwm9CrUkaiS62qCNHT9BMLLFR4n72ZmI/0bXCAVbLDQ+4dSaASRmneGhIxFwWbA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=gj2Y7Uk3; arc=none smtp.client-ip=209.85.161.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="gj2Y7Uk3" Received: by mail-oo1-f45.google.com with SMTP id 006d021491bc7-603fd257386so240546eaf.1 for ; Thu, 17 Apr 2025 10:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1744909661; x=1745514461; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iJO4GXL7dOZjeP6V87YS4vJmfeGtcMABTZh3kn2uUsg=; b=gj2Y7Uk3x7EwWduQIwOzFt/vbkv10ZETT3diWxK7T+pg6s0cH1SuAi8Kp7ogVNv7yc BsRTTarBzuZTV/LptAzJFdiijtjFXpSCDzqcNo1GhAv4KxXpOefZ/f5y6Tu77eOvA/D8 qrKxGHLHi1ASoy1QgFfO85dxNy0BlhF7UftWrI4SwNF1LealvCd/BY5Urzj5GiImhOtS v6/16RF0/auEVRUgQzpiff5I1Wux1o3kZcZbK1cASxkQXsuQSb5l7iBdVSfGQsERKaui 0QOegz2jgzA/cdplbOewf2kG7dN5X/iweAZNmRPXnomR74HLBr3AZvTxc61OVBDE1BAr yXPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744909661; x=1745514461; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iJO4GXL7dOZjeP6V87YS4vJmfeGtcMABTZh3kn2uUsg=; b=mBAzQTIYbwoW7jkhHG2reLLbMobE3Or3XSmNZF3Rb3vQR7/h4O2mqaDSq1Qgd3J9kG /Rq+cEKEKiiOPwqn+xIZgEs87omyoatpbOYdQ6Uxl8x0DQ+prvXs/C+06vzk18Mwh1Rc X3aUDIhrG6K3uoEUMhayKjbCszYF9oLK5d+Pcvwj3W/VGI4kRhauQmUAb2+WeNb0yob3 zSPIVYWlIW0FZiK40vncDCs16LBz/S2uKontjc1QxT9zEShfGzIPut2MOK+jo+avNvnw tKd1pXzuUeLLcximMR8/jZ7yb0299Hym3cLx1WNT6HIHEbpt3c1E1VFDyVHrv/8Qx9br fFvw== X-Forwarded-Encrypted: i=1; AJvYcCWfnICBR1xjBsvlx1RHCHOP5UbkwDSW1g2BARBiBJzyQmz2/dK2BA/ntkwSWPYOu1P4SSFSyQDdCK0=@vger.kernel.org X-Gm-Message-State: AOJu0YzIF9k5JpMZXdIJXIC9pXQnOokEfjNNfKzxRmKE6jnwTOiHZCDh pjoXT/IOlZitekmmYmabu7qJJfcrOiyXOEfFcWXaULP5wxlV1SOVF91Z2kiyhyM= X-Gm-Gg: ASbGncs7jlgqk+49FU4NMj4mppTQ36HWEvC+zUQGg3Uz8NzdanZ+pRvXj716l8a0Snk CwvGFsuKnfbMqDMXWO++a1/GocO5ubZsgUb35MBXgHNzYVNc2NdlIF3yGXd1Mzb/b+yR8FhAtUG 33Vlo56oveTlGqKjTG4tD1jsRyPm9mCuRJFeA+AqWgIy2uA8C1u48DsdGCR++bckj6kB/fdmAP4 Hadk4bUhXQUf1QG2FrYHY/V8kmvzWwIcnDgFDfnNuJ38bYYSv7IQodElY0726Kz1GwfTyb/k3Bz E/pd9jj+loo/GC6bgDQ9V0vcjC76wPYutldD/NEN9RQtGkEFjcQNKp84hsMi6xBxngJGHw9FtM+ 3cyOaE5YUuYKlkW+WCg== X-Google-Smtp-Source: AGHT+IHbLABiWinLwjfZ0DTmEnAkfAixBYu8A7EcycIAgYoLkSVTlOq/Pw+F15KcRSPJ7k1qWk67rg== X-Received: by 2002:a05:6820:180c:b0:603:fada:ac47 with SMTP id 006d021491bc7-604a91e814cmr3847196eaf.1.1744909661228; Thu, 17 Apr 2025 10:07:41 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:c91b:eea3:7afd:2dee? ([2600:8803:e7e4:1d00:c91b:eea3:7afd:2dee]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-605ff5d8c40sm33099eaf.3.2025.04.17.10.07.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Apr 2025 10:07:39 -0700 (PDT) Message-ID: Date: Thu, 17 Apr 2025 12:07:37 -0500 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] iio: imu: adis16550: align buffers for timestamp To: Andy Shevchenko Cc: Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Matthias Brugger , AngeloGioacchino Del Regno , Lars-Peter Clausen , Michael Hennerich , Cosmin Tanislav , Tomasz Duszynski , Jean-Baptiste Maneyrol , Andreas Klinger , Petre Rodan , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20250417-iio-more-timestamp-alignment-v1-0-eafac1e22318@baylibre.com> <20250417-iio-more-timestamp-alignment-v1-6-eafac1e22318@baylibre.com> From: David Lechner Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/17/25 11:59 AM, Andy Shevchenko wrote: > On Thu, Apr 17, 2025 at 11:52:38AM -0500, David Lechner wrote: >> Align the buffers used with iio_push_to_buffers_with_timestamp() to >> ensure the s64 timestamp is aligned to 8 bytes. >> >> drivers/iio/accel/bmc150-accel.h | 2 +- >> drivers/iio/imu/adis16550.c | 2 +- > > Looks like a stray squash of the two independent commits. Oops, sure enough. > > ... > >> struct bmc150_accel_trigger triggers[BMC150_ACCEL_TRIGGERS]; >> struct mutex mutex; >> u8 fifo_mode, watermark; >> - s16 buffer[8]; >> + s16 buffer[8] __aligned(8); > > As for the code, would it be possible to convert to actually use a sturcture > rather than an array? I do personally prefer the struct pattern, but there are very many other drivers using this buffer pattern that I was not tempted to try to start converting them. > > ... > >> struct iio_poll_func *pf = p; >> - __be32 data[ADIS16550_MAX_SCAN_DATA]; >> + __be32 data[ADIS16550_MAX_SCAN_DATA] __aligned(8); >> struct iio_dev *indio_dev = pf->indio_dev; >> struct adis16550 *st = iio_priv(indio_dev); > > Ditto. >