Linux IIO development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Lothar Rubusch <l.rubusch@gmail.com>,
	lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, eraretuya@gmail.com
Subject: Re: [PATCH v4 4/7] dt-bindings: iio: accel: adxl345: Add spi-3wire
Date: Mon, 25 Mar 2024 19:32:00 +0100	[thread overview]
Message-ID: <f74a01bd-46a3-46cd-a47a-fcfccd7e4dc6@linaro.org> (raw)
In-Reply-To: <20240325153356.46112-5-l.rubusch@gmail.com>

On 25/03/2024 16:33, Lothar Rubusch wrote:
> Add spi-3wire because the driver optionally supports spi-3wire.

This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.

> 
> Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
> ---

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.

Best regards,
Krzysztof


  reply	other threads:[~2024-03-25 18:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-25 15:33 [PATCH v4 0/7] iio: accel: adxl345: Add spi-3wire feature Lothar Rubusch
2024-03-25 15:33 ` [PATCH v4 1/7] iio: accel: adxl345: Make data_range obsolete Lothar Rubusch
2024-03-25 20:31   ` Jonathan Cameron
2024-03-26 20:59     ` Lothar Rubusch
2024-03-28 13:15       ` Jonathan Cameron
2024-03-25 15:33 ` [PATCH v4 2/7] iio: accel: adxl345: Group bus configuration Lothar Rubusch
2024-03-25 20:33   ` Jonathan Cameron
2024-03-25 15:33 ` [PATCH v4 3/7] iio: accel: adxl345: Move defines to header Lothar Rubusch
2024-03-25 15:33 ` [PATCH v4 4/7] dt-bindings: iio: accel: adxl345: Add spi-3wire Lothar Rubusch
2024-03-25 18:32   ` Krzysztof Kozlowski [this message]
2024-03-25 21:05     ` Lothar Rubusch
2024-03-25 21:40       ` Krzysztof Kozlowski
2024-03-25 22:09         ` Lothar Rubusch
2024-03-26  6:30           ` Krzysztof Kozlowski
2024-03-26 20:17             ` Lothar Rubusch
2024-03-27  5:02               ` Krzysztof Kozlowski
2024-03-25 15:33 ` [PATCH v4 5/7] iio: accel: adxl345: Pass function pointer to core Lothar Rubusch
2024-03-25 20:34   ` Jonathan Cameron
2024-03-25 15:33 ` [PATCH v4 6/7] iio: accel: adxl345: Add comment to probe Lothar Rubusch
2024-03-25 15:33 ` [PATCH v4 7/7] iio: accel: adxl345: Add spi-3wire option Lothar Rubusch
2024-03-25 20:37   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f74a01bd-46a3-46cd-a47a-fcfccd7e4dc6@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eraretuya@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=l.rubusch@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox