From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: iio/…: Use common error handling code
Date: Sun, 10 Dec 2017 17:43:34 +0100 [thread overview]
Message-ID: <f8289b08-389a-a6d6-21f6-ca1ba20c2c85@users.sourceforge.net> (raw)
In-Reply-To: <20171210160829.16128419@archlinux>
> Hi Markus, I've accepted the ones that I think made an improvement
> outweighing the inherent small costs of making any change.
Does such a kind of feedback mean that you reconsidered any places
where you expressed a rejection initially?
> We also need to avoid code constructs that are unusual in error handling
> such as backwards gotos.
Why would you like to exclude this approach if anything useful could be achieved
in the shown software design direction?
> Note however that most of the changes made so far are only minor improvements.
I agree that corresponding effects are small just because the discussed
source code adjustments affected specific function implementations.
> I am not saying I don't appreciate them,
Thanks.
> but rather than that they are of of low importance.
A lot of details are competing also for our software development attention.
Regards,
Markus
next prev parent reply other threads:[~2017-12-10 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 20:15 [PATCH 0/2] iio/accel/stk8ba50: Fine-tuning for two function implementations SF Markus Elfring
2017-10-25 20:16 ` [PATCH 1/2] iio/accel/stk8ba50: Use common error handling code in stk8ba50_probe() SF Markus Elfring
2017-10-26 16:42 ` Jonathan Cameron
2017-10-26 17:09 ` SF Markus Elfring
2017-12-10 12:33 ` iio/…: Use common error handling code SF Markus Elfring
2017-12-10 16:08 ` Jonathan Cameron
2017-12-10 16:43 ` SF Markus Elfring [this message]
2017-12-10 19:45 ` Jonathan Cameron
2017-10-25 20:17 ` [PATCH 2/2] iio/accel/stk8ba50: Improve unlocking of a mutex in stk8ba50_read_raw() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8289b08-389a-a6d6-21f6-ca1ba20c2c85@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=hdegoede@redhat.com \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).