* [PATCH 1/5] bus: stm32_firewall: Fix build warnings about export.h
2025-06-10 12:48 [PATCH 0/5] STM32: Fix build warnings about export.h Antonio Borneo
@ 2025-06-10 12:48 ` Antonio Borneo
2025-06-10 13:30 ` Gatien CHEVALLIER
2025-06-10 12:48 ` [PATCH 2/5] iio: adc: stm32-dfsdm: " Antonio Borneo
` (3 subsequent siblings)
4 siblings, 1 reply; 15+ messages in thread
From: Antonio Borneo @ 2025-06-10 12:48 UTC (permalink / raw)
To: Alexandre Torgue, Andy Shevchenko, David Lechner, Fabrice Gasnier,
Gatien Chevallier, Jonathan Cameron, Lee Jones, linux-iio,
Nuno Sá, Olivier Moysan
Cc: Antonio Borneo, linux-arm-kernel, linux-kernel, linux-stm32,
Maxime Coquelin
After commit a934a57a42f6 ("scripts/misc-check: check missing #include
<linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check:
check unnecessary #include <linux/export.h> when W=1") we get the build
warning with W=1:
drivers/bus/stm32_firewall.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
Fix it.
Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
---
drivers/bus/stm32_firewall.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bus/stm32_firewall.c b/drivers/bus/stm32_firewall.c
index 2fc9761dadecf..3ff5b5b6add45 100644
--- a/drivers/bus/stm32_firewall.c
+++ b/drivers/bus/stm32_firewall.c
@@ -8,6 +8,7 @@
#include <linux/bus/stm32_firewall_device.h>
#include <linux/device.h>
#include <linux/err.h>
+#include <linux/export.h>
#include <linux/init.h>
#include <linux/io.h>
#include <linux/kernel.h>
--
2.34.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 1/5] bus: stm32_firewall: Fix build warnings about export.h
2025-06-10 12:48 ` [PATCH 1/5] bus: stm32_firewall: " Antonio Borneo
@ 2025-06-10 13:30 ` Gatien CHEVALLIER
0 siblings, 0 replies; 15+ messages in thread
From: Gatien CHEVALLIER @ 2025-06-10 13:30 UTC (permalink / raw)
To: Antonio Borneo, Alexandre Torgue, Andy Shevchenko, David Lechner,
Fabrice Gasnier, Jonathan Cameron, Lee Jones, linux-iio,
Nuno Sá, Olivier Moysan
Cc: linux-arm-kernel, linux-kernel, linux-stm32, Maxime Coquelin
Hello Antonio,
On 6/10/25 14:48, Antonio Borneo wrote:
> After commit a934a57a42f6 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check:
> check unnecessary #include <linux/export.h> when W=1") we get the build
> warning with W=1:
>
> drivers/bus/stm32_firewall.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
>
> Fix it.
>
> Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
> ---
> drivers/bus/stm32_firewall.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/stm32_firewall.c b/drivers/bus/stm32_firewall.c
> index 2fc9761dadecf..3ff5b5b6add45 100644
> --- a/drivers/bus/stm32_firewall.c
> +++ b/drivers/bus/stm32_firewall.c
> @@ -8,6 +8,7 @@
> #include <linux/bus/stm32_firewall_device.h>
> #include <linux/device.h>
> #include <linux/err.h>
> +#include <linux/export.h>
> #include <linux/init.h>
> #include <linux/io.h>
> #include <linux/kernel.h>
Thank you,
Acked-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
BR,
Gatien
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/5] iio: adc: stm32-dfsdm: Fix build warnings about export.h
2025-06-10 12:48 [PATCH 0/5] STM32: Fix build warnings about export.h Antonio Borneo
2025-06-10 12:48 ` [PATCH 1/5] bus: stm32_firewall: " Antonio Borneo
@ 2025-06-10 12:48 ` Antonio Borneo
2025-06-10 13:05 ` Fabrice Gasnier
2025-06-10 12:48 ` [PATCH 3/5] iio: trigger: stm32-timer: " Antonio Borneo
` (2 subsequent siblings)
4 siblings, 1 reply; 15+ messages in thread
From: Antonio Borneo @ 2025-06-10 12:48 UTC (permalink / raw)
To: Alexandre Torgue, Andy Shevchenko, David Lechner, Fabrice Gasnier,
Gatien Chevallier, Jonathan Cameron, Lee Jones, linux-iio,
Nuno Sá, Olivier Moysan
Cc: Antonio Borneo, linux-arm-kernel, linux-kernel, linux-stm32,
Maxime Coquelin
After commit a934a57a42f6 ("scripts/misc-check: check missing #include
<linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check:
check unnecessary #include <linux/export.h> when W=1") we get the build
warnings with W=1:
drivers/iio/adc/stm32-dfsdm-adc.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
drivers/iio/adc/stm32-dfsdm-core.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
Fix them.
Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
---
drivers/iio/adc/stm32-dfsdm-adc.c | 1 +
drivers/iio/adc/stm32-dfsdm-core.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
index f583924eb16bb..c2d21eecafe79 100644
--- a/drivers/iio/adc/stm32-dfsdm-adc.c
+++ b/drivers/iio/adc/stm32-dfsdm-adc.c
@@ -8,6 +8,7 @@
#include <linux/dmaengine.h>
#include <linux/dma-mapping.h>
+#include <linux/export.h>
#include <linux/iio/adc/stm32-dfsdm-adc.h>
#include <linux/iio/backend.h>
#include <linux/iio/buffer.h>
diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
index 041dc9ebc0482..47e2d1338e9e6 100644
--- a/drivers/iio/adc/stm32-dfsdm-core.c
+++ b/drivers/iio/adc/stm32-dfsdm-core.c
@@ -8,6 +8,7 @@
#include <linux/bitfield.h>
#include <linux/clk.h>
+#include <linux/export.h>
#include <linux/iio/iio.h>
#include <linux/iio/sysfs.h>
#include <linux/interrupt.h>
--
2.34.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 2/5] iio: adc: stm32-dfsdm: Fix build warnings about export.h
2025-06-10 12:48 ` [PATCH 2/5] iio: adc: stm32-dfsdm: " Antonio Borneo
@ 2025-06-10 13:05 ` Fabrice Gasnier
2025-06-11 16:34 ` Jonathan Cameron
0 siblings, 1 reply; 15+ messages in thread
From: Fabrice Gasnier @ 2025-06-10 13:05 UTC (permalink / raw)
To: Antonio Borneo, Alexandre Torgue, Andy Shevchenko, David Lechner,
Gatien Chevallier, Jonathan Cameron, Lee Jones, linux-iio,
Nuno Sá, Olivier Moysan
Cc: linux-arm-kernel, linux-kernel, linux-stm32, Maxime Coquelin
On 6/10/25 14:48, Antonio Borneo wrote:
> After commit a934a57a42f6 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check:
> check unnecessary #include <linux/export.h> when W=1") we get the build
> warnings with W=1:
>
> drivers/iio/adc/stm32-dfsdm-adc.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> drivers/iio/adc/stm32-dfsdm-core.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
>
> Fix them.
>
> Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
Hi Antonio,
You can add my:
Acked-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Thanks,
Fabrice
> ---
> drivers/iio/adc/stm32-dfsdm-adc.c | 1 +
> drivers/iio/adc/stm32-dfsdm-core.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index f583924eb16bb..c2d21eecafe79 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -8,6 +8,7 @@
>
> #include <linux/dmaengine.h>
> #include <linux/dma-mapping.h>
> +#include <linux/export.h>
> #include <linux/iio/adc/stm32-dfsdm-adc.h>
> #include <linux/iio/backend.h>
> #include <linux/iio/buffer.h>
> diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
> index 041dc9ebc0482..47e2d1338e9e6 100644
> --- a/drivers/iio/adc/stm32-dfsdm-core.c
> +++ b/drivers/iio/adc/stm32-dfsdm-core.c
> @@ -8,6 +8,7 @@
>
> #include <linux/bitfield.h>
> #include <linux/clk.h>
> +#include <linux/export.h>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> #include <linux/interrupt.h>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 2/5] iio: adc: stm32-dfsdm: Fix build warnings about export.h
2025-06-10 13:05 ` Fabrice Gasnier
@ 2025-06-11 16:34 ` Jonathan Cameron
0 siblings, 0 replies; 15+ messages in thread
From: Jonathan Cameron @ 2025-06-11 16:34 UTC (permalink / raw)
To: Fabrice Gasnier
Cc: Antonio Borneo, Alexandre Torgue, Andy Shevchenko, David Lechner,
Gatien Chevallier, Lee Jones, linux-iio, Nuno Sá,
Olivier Moysan, linux-arm-kernel, linux-kernel, linux-stm32,
Maxime Coquelin
On Tue, 10 Jun 2025 15:05:16 +0200
Fabrice Gasnier <fabrice.gasnier@foss.st.com> wrote:
> On 6/10/25 14:48, Antonio Borneo wrote:
> > After commit a934a57a42f6 ("scripts/misc-check: check missing #include
> > <linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check:
> > check unnecessary #include <linux/export.h> when W=1") we get the build
> > warnings with W=1:
> >
> > drivers/iio/adc/stm32-dfsdm-adc.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> > drivers/iio/adc/stm32-dfsdm-core.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> >
> > Fix them.
> >
> > Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
>
> Hi Antonio,
>
> You can add my:
> Acked-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Applied to the togreg branch of iio.git.
Ta.
>
> Thanks,
> Fabrice
> > ---
> > drivers/iio/adc/stm32-dfsdm-adc.c | 1 +
> > drivers/iio/adc/stm32-dfsdm-core.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> > index f583924eb16bb..c2d21eecafe79 100644
> > --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> > @@ -8,6 +8,7 @@
> >
> > #include <linux/dmaengine.h>
> > #include <linux/dma-mapping.h>
> > +#include <linux/export.h>
> > #include <linux/iio/adc/stm32-dfsdm-adc.h>
> > #include <linux/iio/backend.h>
> > #include <linux/iio/buffer.h>
> > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
> > index 041dc9ebc0482..47e2d1338e9e6 100644
> > --- a/drivers/iio/adc/stm32-dfsdm-core.c
> > +++ b/drivers/iio/adc/stm32-dfsdm-core.c
> > @@ -8,6 +8,7 @@
> >
> > #include <linux/bitfield.h>
> > #include <linux/clk.h>
> > +#include <linux/export.h>
> > #include <linux/iio/iio.h>
> > #include <linux/iio/sysfs.h>
> > #include <linux/interrupt.h>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 3/5] iio: trigger: stm32-timer: Fix build warnings about export.h
2025-06-10 12:48 [PATCH 0/5] STM32: Fix build warnings about export.h Antonio Borneo
2025-06-10 12:48 ` [PATCH 1/5] bus: stm32_firewall: " Antonio Borneo
2025-06-10 12:48 ` [PATCH 2/5] iio: adc: stm32-dfsdm: " Antonio Borneo
@ 2025-06-10 12:48 ` Antonio Borneo
2025-06-10 13:05 ` Fabrice Gasnier
2025-06-10 12:48 ` [PATCH 4/5] iio: trigger: stm32-lptimer: " Antonio Borneo
2025-06-10 12:48 ` [PATCH 5/5] mfd: stm32-timers: " Antonio Borneo
4 siblings, 1 reply; 15+ messages in thread
From: Antonio Borneo @ 2025-06-10 12:48 UTC (permalink / raw)
To: Alexandre Torgue, Andy Shevchenko, David Lechner, Fabrice Gasnier,
Gatien Chevallier, Jonathan Cameron, Lee Jones, linux-iio,
Nuno Sá, Olivier Moysan
Cc: Antonio Borneo, linux-arm-kernel, linux-kernel, linux-stm32,
Maxime Coquelin
After commit a934a57a42f6 ("scripts/misc-check: check missing #include
<linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check:
check unnecessary #include <linux/export.h> when W=1") we get the build
warning with W=1:
drivers/iio/trigger/stm32-timer-trigger.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
Fix it.
Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
---
drivers/iio/trigger/stm32-timer-trigger.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/trigger/stm32-timer-trigger.c b/drivers/iio/trigger/stm32-timer-trigger.c
index 925b864facca1..3b9a3a6cbb25c 100644
--- a/drivers/iio/trigger/stm32-timer-trigger.c
+++ b/drivers/iio/trigger/stm32-timer-trigger.c
@@ -6,6 +6,7 @@
*
*/
+#include <linux/export.h>
#include <linux/iio/iio.h>
#include <linux/iio/sysfs.h>
#include <linux/iio/timer/stm32-timer-trigger.h>
--
2.34.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 3/5] iio: trigger: stm32-timer: Fix build warnings about export.h
2025-06-10 12:48 ` [PATCH 3/5] iio: trigger: stm32-timer: " Antonio Borneo
@ 2025-06-10 13:05 ` Fabrice Gasnier
2025-06-11 16:36 ` Jonathan Cameron
0 siblings, 1 reply; 15+ messages in thread
From: Fabrice Gasnier @ 2025-06-10 13:05 UTC (permalink / raw)
To: Antonio Borneo, Alexandre Torgue, Andy Shevchenko, David Lechner,
Gatien Chevallier, Jonathan Cameron, Lee Jones, linux-iio,
Nuno Sá, Olivier Moysan
Cc: linux-arm-kernel, linux-kernel, linux-stm32, Maxime Coquelin
On 6/10/25 14:48, Antonio Borneo wrote:
> After commit a934a57a42f6 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check:
> check unnecessary #include <linux/export.h> when W=1") we get the build
> warning with W=1:
>
> drivers/iio/trigger/stm32-timer-trigger.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
>
> Fix it.
>
> Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
Hi Antonio,
You can add my:
Acked-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Thanks,
Fabrice
> ---
> drivers/iio/trigger/stm32-timer-trigger.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/trigger/stm32-timer-trigger.c b/drivers/iio/trigger/stm32-timer-trigger.c
> index 925b864facca1..3b9a3a6cbb25c 100644
> --- a/drivers/iio/trigger/stm32-timer-trigger.c
> +++ b/drivers/iio/trigger/stm32-timer-trigger.c
> @@ -6,6 +6,7 @@
> *
> */
>
> +#include <linux/export.h>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> #include <linux/iio/timer/stm32-timer-trigger.h>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 3/5] iio: trigger: stm32-timer: Fix build warnings about export.h
2025-06-10 13:05 ` Fabrice Gasnier
@ 2025-06-11 16:36 ` Jonathan Cameron
0 siblings, 0 replies; 15+ messages in thread
From: Jonathan Cameron @ 2025-06-11 16:36 UTC (permalink / raw)
To: Fabrice Gasnier
Cc: Antonio Borneo, Alexandre Torgue, Andy Shevchenko, David Lechner,
Gatien Chevallier, Lee Jones, linux-iio, Nuno Sá,
Olivier Moysan, linux-arm-kernel, linux-kernel, linux-stm32,
Maxime Coquelin
On Tue, 10 Jun 2025 15:05:36 +0200
Fabrice Gasnier <fabrice.gasnier@foss.st.com> wrote:
> On 6/10/25 14:48, Antonio Borneo wrote:
> > After commit a934a57a42f6 ("scripts/misc-check: check missing #include
> > <linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check:
> > check unnecessary #include <linux/export.h> when W=1") we get the build
> > warning with W=1:
> >
> > drivers/iio/trigger/stm32-timer-trigger.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> >
> > Fix it.
> >
> > Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
>
> Hi Antonio,
>
> You can add my:
> Acked-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Applied to the togreg branch of iio.git - initially pushed out as testing
as I have some other stuff queued today that needs 0-day to look at it.
Thanks,
J
>
> Thanks,
> Fabrice
>
> > ---
> > drivers/iio/trigger/stm32-timer-trigger.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iio/trigger/stm32-timer-trigger.c b/drivers/iio/trigger/stm32-timer-trigger.c
> > index 925b864facca1..3b9a3a6cbb25c 100644
> > --- a/drivers/iio/trigger/stm32-timer-trigger.c
> > +++ b/drivers/iio/trigger/stm32-timer-trigger.c
> > @@ -6,6 +6,7 @@
> > *
> > */
> >
> > +#include <linux/export.h>
> > #include <linux/iio/iio.h>
> > #include <linux/iio/sysfs.h>
> > #include <linux/iio/timer/stm32-timer-trigger.h>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 4/5] iio: trigger: stm32-lptimer: Fix build warnings about export.h
2025-06-10 12:48 [PATCH 0/5] STM32: Fix build warnings about export.h Antonio Borneo
` (2 preceding siblings ...)
2025-06-10 12:48 ` [PATCH 3/5] iio: trigger: stm32-timer: " Antonio Borneo
@ 2025-06-10 12:48 ` Antonio Borneo
2025-06-10 13:05 ` Fabrice Gasnier
2025-06-10 12:48 ` [PATCH 5/5] mfd: stm32-timers: " Antonio Borneo
4 siblings, 1 reply; 15+ messages in thread
From: Antonio Borneo @ 2025-06-10 12:48 UTC (permalink / raw)
To: Alexandre Torgue, Andy Shevchenko, David Lechner, Fabrice Gasnier,
Gatien Chevallier, Jonathan Cameron, Lee Jones, linux-iio,
Nuno Sá, Olivier Moysan
Cc: Antonio Borneo, linux-arm-kernel, linux-kernel, linux-stm32,
Maxime Coquelin
After commit a934a57a42f6 ("scripts/misc-check: check missing #include
<linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check:
check unnecessary #include <linux/export.h> when W=1") we get the build
warning with W=1:
drivers/iio/trigger/stm32-lptimer-trigger.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
Fix it.
Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
---
drivers/iio/trigger/stm32-lptimer-trigger.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/trigger/stm32-lptimer-trigger.c b/drivers/iio/trigger/stm32-lptimer-trigger.c
index 2505ace440b46..c7bab18221c70 100644
--- a/drivers/iio/trigger/stm32-lptimer-trigger.c
+++ b/drivers/iio/trigger/stm32-lptimer-trigger.c
@@ -9,6 +9,7 @@
* Inspired by Benjamin Gaignard's stm32-timer-trigger driver
*/
+#include <linux/export.h>
#include <linux/iio/timer/stm32-lptim-trigger.h>
#include <linux/mfd/stm32-lptimer.h>
#include <linux/mod_devicetable.h>
--
2.34.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 4/5] iio: trigger: stm32-lptimer: Fix build warnings about export.h
2025-06-10 12:48 ` [PATCH 4/5] iio: trigger: stm32-lptimer: " Antonio Borneo
@ 2025-06-10 13:05 ` Fabrice Gasnier
2025-06-11 16:37 ` Jonathan Cameron
0 siblings, 1 reply; 15+ messages in thread
From: Fabrice Gasnier @ 2025-06-10 13:05 UTC (permalink / raw)
To: Antonio Borneo, Alexandre Torgue, Andy Shevchenko, David Lechner,
Gatien Chevallier, Jonathan Cameron, Lee Jones, linux-iio,
Nuno Sá, Olivier Moysan
Cc: linux-arm-kernel, linux-kernel, linux-stm32, Maxime Coquelin
On 6/10/25 14:48, Antonio Borneo wrote:
> After commit a934a57a42f6 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check:
> check unnecessary #include <linux/export.h> when W=1") we get the build
> warning with W=1:
>
> drivers/iio/trigger/stm32-lptimer-trigger.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
>
> Fix it.
>
> Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
Hi Antonio,
You can add my:
Acked-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Thanks,
Fabrice
> ---
> drivers/iio/trigger/stm32-lptimer-trigger.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/trigger/stm32-lptimer-trigger.c b/drivers/iio/trigger/stm32-lptimer-trigger.c
> index 2505ace440b46..c7bab18221c70 100644
> --- a/drivers/iio/trigger/stm32-lptimer-trigger.c
> +++ b/drivers/iio/trigger/stm32-lptimer-trigger.c
> @@ -9,6 +9,7 @@
> * Inspired by Benjamin Gaignard's stm32-timer-trigger driver
> */
>
> +#include <linux/export.h>
> #include <linux/iio/timer/stm32-lptim-trigger.h>
> #include <linux/mfd/stm32-lptimer.h>
> #include <linux/mod_devicetable.h>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 4/5] iio: trigger: stm32-lptimer: Fix build warnings about export.h
2025-06-10 13:05 ` Fabrice Gasnier
@ 2025-06-11 16:37 ` Jonathan Cameron
0 siblings, 0 replies; 15+ messages in thread
From: Jonathan Cameron @ 2025-06-11 16:37 UTC (permalink / raw)
To: Fabrice Gasnier
Cc: Antonio Borneo, Alexandre Torgue, Andy Shevchenko, David Lechner,
Gatien Chevallier, Lee Jones, linux-iio, Nuno Sá,
Olivier Moysan, linux-arm-kernel, linux-kernel, linux-stm32,
Maxime Coquelin
On Tue, 10 Jun 2025 15:05:50 +0200
Fabrice Gasnier <fabrice.gasnier@foss.st.com> wrote:
> On 6/10/25 14:48, Antonio Borneo wrote:
> > After commit a934a57a42f6 ("scripts/misc-check: check missing #include
> > <linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check:
> > check unnecessary #include <linux/export.h> when W=1") we get the build
> > warning with W=1:
> >
> > drivers/iio/trigger/stm32-lptimer-trigger.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> >
> > Fix it.
> >
> > Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
>
> Hi Antonio,
>
> You can add my:
> Acked-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
>
Applied.
> Thanks,
> Fabrice
>
> > ---
> > drivers/iio/trigger/stm32-lptimer-trigger.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iio/trigger/stm32-lptimer-trigger.c b/drivers/iio/trigger/stm32-lptimer-trigger.c
> > index 2505ace440b46..c7bab18221c70 100644
> > --- a/drivers/iio/trigger/stm32-lptimer-trigger.c
> > +++ b/drivers/iio/trigger/stm32-lptimer-trigger.c
> > @@ -9,6 +9,7 @@
> > * Inspired by Benjamin Gaignard's stm32-timer-trigger driver
> > */
> >
> > +#include <linux/export.h>
> > #include <linux/iio/timer/stm32-lptim-trigger.h>
> > #include <linux/mfd/stm32-lptimer.h>
> > #include <linux/mod_devicetable.h>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 5/5] mfd: stm32-timers: Fix build warnings about export.h
2025-06-10 12:48 [PATCH 0/5] STM32: Fix build warnings about export.h Antonio Borneo
` (3 preceding siblings ...)
2025-06-10 12:48 ` [PATCH 4/5] iio: trigger: stm32-lptimer: " Antonio Borneo
@ 2025-06-10 12:48 ` Antonio Borneo
2025-06-10 13:06 ` Fabrice Gasnier
2025-06-19 11:26 ` (subset) " Lee Jones
4 siblings, 2 replies; 15+ messages in thread
From: Antonio Borneo @ 2025-06-10 12:48 UTC (permalink / raw)
To: Alexandre Torgue, Andy Shevchenko, David Lechner, Fabrice Gasnier,
Gatien Chevallier, Jonathan Cameron, Lee Jones, linux-iio,
Nuno Sá, Olivier Moysan
Cc: Antonio Borneo, linux-arm-kernel, linux-kernel, linux-stm32,
Maxime Coquelin
After commit a934a57a42f6 ("scripts/misc-check: check missing #include
<linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check:
check unnecessary #include <linux/export.h> when W=1") we get the build
warning with W=1:
drivers/mfd/stm32-timers.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
Fix it.
Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
---
drivers/mfd/stm32-timers.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c
index e3c116ee4034a..b3dbc02aaf798 100644
--- a/drivers/mfd/stm32-timers.c
+++ b/drivers/mfd/stm32-timers.c
@@ -5,6 +5,7 @@
*/
#include <linux/bitfield.h>
+#include <linux/export.h>
#include <linux/mfd/stm32-timers.h>
#include <linux/module.h>
#include <linux/of_platform.h>
--
2.34.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 5/5] mfd: stm32-timers: Fix build warnings about export.h
2025-06-10 12:48 ` [PATCH 5/5] mfd: stm32-timers: " Antonio Borneo
@ 2025-06-10 13:06 ` Fabrice Gasnier
2025-06-19 11:26 ` (subset) " Lee Jones
1 sibling, 0 replies; 15+ messages in thread
From: Fabrice Gasnier @ 2025-06-10 13:06 UTC (permalink / raw)
To: Antonio Borneo, Alexandre Torgue, Andy Shevchenko, David Lechner,
Gatien Chevallier, Jonathan Cameron, Lee Jones, linux-iio,
Nuno Sá, Olivier Moysan
Cc: linux-arm-kernel, linux-kernel, linux-stm32, Maxime Coquelin
On 6/10/25 14:48, Antonio Borneo wrote:
> After commit a934a57a42f6 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check:
> check unnecessary #include <linux/export.h> when W=1") we get the build
> warning with W=1:
>
> drivers/mfd/stm32-timers.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
>
> Fix it.
>
> Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
Hi Antonio,
You can add my:
Acked-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Thanks,
Fabrice
> ---
> drivers/mfd/stm32-timers.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c
> index e3c116ee4034a..b3dbc02aaf798 100644
> --- a/drivers/mfd/stm32-timers.c
> +++ b/drivers/mfd/stm32-timers.c
> @@ -5,6 +5,7 @@
> */
>
> #include <linux/bitfield.h>
> +#include <linux/export.h>
> #include <linux/mfd/stm32-timers.h>
> #include <linux/module.h>
> #include <linux/of_platform.h>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: (subset) [PATCH 5/5] mfd: stm32-timers: Fix build warnings about export.h
2025-06-10 12:48 ` [PATCH 5/5] mfd: stm32-timers: " Antonio Borneo
2025-06-10 13:06 ` Fabrice Gasnier
@ 2025-06-19 11:26 ` Lee Jones
1 sibling, 0 replies; 15+ messages in thread
From: Lee Jones @ 2025-06-19 11:26 UTC (permalink / raw)
To: Alexandre Torgue, Andy Shevchenko, David Lechner, Fabrice Gasnier,
Gatien Chevallier, Jonathan Cameron, Lee Jones, linux-iio,
Nuno Sá, Olivier Moysan, Antonio Borneo
Cc: linux-arm-kernel, linux-kernel, linux-stm32, Maxime Coquelin
On Tue, 10 Jun 2025 14:48:55 +0200, Antonio Borneo wrote:
> After commit a934a57a42f6 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check:
> check unnecessary #include <linux/export.h> when W=1") we get the build
> warning with W=1:
>
> drivers/mfd/stm32-timers.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
>
> [...]
Applied, thanks!
[5/5] mfd: stm32-timers: Fix build warnings about export.h
commit: cf5d2f2deaee5dbfcac2db8758c3e6e0864a0c86
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 15+ messages in thread