From: Lukas Wunner <lukas@wunner.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Mathias Duckeck <m.duckeck@kunbus.de>,
Phil Elwell <phil@raspberrypi.org>,
Oskar Andero <oskar.andero@gmail.com>,
Andrea Galbusera <gizero@gmail.com>,
Akinobu Mita <akinobu.mita@gmail.com>,
Manfred Schlaegl <manfred.schlaegl@gmx.at>,
Michael Welling <mwelling@ieee.org>,
Soeren Andersen <san@rosetechnology.dk>,
linux-iio@vger.kernel.org
Subject: [PATCH v2 2/6] iio: adc: mcp320x: Drop unnecessary of_device_id attributes
Date: Sat, 9 Sep 2017 20:32:41 +0200 [thread overview]
Message-ID: <f948e3b438b4fc7fdecb83c4f044e060bcffb150.1504807204.git.lukas@wunner.de> (raw)
In-Reply-To: <cover.1504807204.git.lukas@wunner.de>
The driver sets a .data pointer for each .compatible string but never
calls of_device_get_match_data(). Instead, ADC properties are looked up
with spi_get_device_id(). The .data pointer is therefore unnecessary,
so drop it.
Signed-off-by: Lukas Wunner <lukas@wunner.de>
---
drivers/iio/adc/mcp320x.c | 75 ++++++++++++-----------------------------------
1 file changed, 19 insertions(+), 56 deletions(-)
diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c
index 15b5fa7ad427..bf4794009413 100644
--- a/drivers/iio/adc/mcp320x.c
+++ b/drivers/iio/adc/mcp320x.c
@@ -363,62 +363,25 @@ static int mcp320x_remove(struct spi_device *spi)
#if defined(CONFIG_OF)
static const struct of_device_id mcp320x_dt_ids[] = {
/* NOTE: The use of compatibles with no vendor prefix is deprecated. */
- {
- .compatible = "mcp3001",
- .data = &mcp320x_chip_infos[mcp3001],
- }, {
- .compatible = "mcp3002",
- .data = &mcp320x_chip_infos[mcp3002],
- }, {
- .compatible = "mcp3004",
- .data = &mcp320x_chip_infos[mcp3004],
- }, {
- .compatible = "mcp3008",
- .data = &mcp320x_chip_infos[mcp3008],
- }, {
- .compatible = "mcp3201",
- .data = &mcp320x_chip_infos[mcp3201],
- }, {
- .compatible = "mcp3202",
- .data = &mcp320x_chip_infos[mcp3202],
- }, {
- .compatible = "mcp3204",
- .data = &mcp320x_chip_infos[mcp3204],
- }, {
- .compatible = "mcp3208",
- .data = &mcp320x_chip_infos[mcp3208],
- }, {
- .compatible = "mcp3301",
- .data = &mcp320x_chip_infos[mcp3301],
- }, {
- .compatible = "microchip,mcp3001",
- .data = &mcp320x_chip_infos[mcp3001],
- }, {
- .compatible = "microchip,mcp3002",
- .data = &mcp320x_chip_infos[mcp3002],
- }, {
- .compatible = "microchip,mcp3004",
- .data = &mcp320x_chip_infos[mcp3004],
- }, {
- .compatible = "microchip,mcp3008",
- .data = &mcp320x_chip_infos[mcp3008],
- }, {
- .compatible = "microchip,mcp3201",
- .data = &mcp320x_chip_infos[mcp3201],
- }, {
- .compatible = "microchip,mcp3202",
- .data = &mcp320x_chip_infos[mcp3202],
- }, {
- .compatible = "microchip,mcp3204",
- .data = &mcp320x_chip_infos[mcp3204],
- }, {
- .compatible = "microchip,mcp3208",
- .data = &mcp320x_chip_infos[mcp3208],
- }, {
- .compatible = "microchip,mcp3301",
- .data = &mcp320x_chip_infos[mcp3301],
- }, {
- }
+ { .compatible = "mcp3001" },
+ { .compatible = "mcp3002" },
+ { .compatible = "mcp3004" },
+ { .compatible = "mcp3008" },
+ { .compatible = "mcp3201" },
+ { .compatible = "mcp3202" },
+ { .compatible = "mcp3204" },
+ { .compatible = "mcp3208" },
+ { .compatible = "mcp3301" },
+ { .compatible = "microchip,mcp3001" },
+ { .compatible = "microchip,mcp3002" },
+ { .compatible = "microchip,mcp3004" },
+ { .compatible = "microchip,mcp3008" },
+ { .compatible = "microchip,mcp3201" },
+ { .compatible = "microchip,mcp3202" },
+ { .compatible = "microchip,mcp3204" },
+ { .compatible = "microchip,mcp3208" },
+ { .compatible = "microchip,mcp3301" },
+ { }
};
MODULE_DEVICE_TABLE(of, mcp320x_dt_ids);
#endif
--
2.11.0
next prev parent reply other threads:[~2017-09-09 18:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 18:32 [PATCH v2 0/6] IIO driver for MCP3550/1/3 Lukas Wunner
2017-09-09 18:32 ` [PATCH v2 4/6] dt-bindings: iio: adc: mcp320x: Update for mcp3550/1/3 Lukas Wunner
2017-09-10 16:16 ` Jonathan Cameron
2017-09-18 20:27 ` Rob Herring
2017-09-09 18:32 ` Lukas Wunner [this message]
2017-09-10 16:10 ` [PATCH v2 2/6] iio: adc: mcp320x: Drop unnecessary of_device_id attributes Jonathan Cameron
2017-09-09 18:32 ` [PATCH v2 5/6] iio: adc: mcp320x: Add support for mcp3550/1/3 Lukas Wunner
2017-09-10 16:15 ` Jonathan Cameron
2017-10-04 19:50 ` Lukas Wunner
2017-10-04 20:53 ` Jonathan Cameron
2017-10-08 10:30 ` Jonathan Cameron
2017-10-09 7:54 ` Lukas Wunner
2017-10-09 19:55 ` Jonathan Cameron
2017-09-09 18:32 ` [PATCH v2 3/6] iio: adc: mcp320x: Document struct mcp320x Lukas Wunner
2017-09-10 16:12 ` Jonathan Cameron
2017-09-09 18:32 ` [PATCH v2 6/6 INFORMATIONAL/RFT] iio: adc: mcp320x: Support continuous conversion mode Lukas Wunner
2017-09-09 18:32 ` [PATCH v2 1/6] iio: adc: mcp320x: Speed up readout of single-channel ADCs Lukas Wunner
2017-09-10 16:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f948e3b438b4fc7fdecb83c4f044e060bcffb150.1504807204.git.lukas@wunner.de \
--to=lukas@wunner.de \
--cc=akinobu.mita@gmail.com \
--cc=gizero@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=m.duckeck@kunbus.de \
--cc=manfred.schlaegl@gmx.at \
--cc=mwelling@ieee.org \
--cc=oskar.andero@gmail.com \
--cc=phil@raspberrypi.org \
--cc=pmeerw@pmeerw.net \
--cc=san@rosetechnology.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).