From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CC96C19F2A for ; Thu, 11 Aug 2022 10:51:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234131AbiHKKvP (ORCPT ); Thu, 11 Aug 2022 06:51:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233856AbiHKKvN (ORCPT ); Thu, 11 Aug 2022 06:51:13 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82FD37820B; Thu, 11 Aug 2022 03:51:12 -0700 (PDT) Received: from [IPV6:2405:201:10:389d:42df:ae4c:c047:294c] (unknown [IPv6:2405:201:10:389d:42df:ae4c:c047:294c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: shreeya) by madras.collabora.co.uk (Postfix) with ESMTPSA id 82B106601CE2; Thu, 11 Aug 2022 11:51:09 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1660215071; bh=IfPooe1VNkTtfiNR2zb1X1udyCJ5qiqVzbKpp7Jtf/8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AzSDrxaBlb/8Z/b1yo7GpOsQOvjwXnAJgnSWybI2ANSb3PhK3MHmB80N5c8Eu6wMb py9MTrBrshMuimJuvgjWQYc1Hof7xpA0JXiLDsx1TVMfQTAh7j6sbzWiUdZyN4ZsTW e9dvKduYfx7W1MjkLB+I4kA6mCMLCX1UEouuS/HL//iCatP2ebA34qKOvoa5ge7fIK gAWQRvdMt8OGHuSEc9Ba2d7yIq5qVyVoUxJrtXmh+et2UEHA5UddanxjB1MyDPPjZ6 uLQLvG5JyCGz5dsEAtxVUcdU/qwq2wX5N7LN5IANqmzi4xctXsRmNBOcDRLvwsP465 VQapnZyFSxxNQ== Message-ID: Date: Thu, 11 Aug 2022 16:21:05 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] iio: light: Add raw attribute Content-Language: en-US To: Dmitry Osipenko , jic23@kernel.org, lars@metafoo.de Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, krisman@collabora.com, kernel@collabora.com, alvaro.soliverez@collabora.com References: <20220811101443.499761-1-shreeya.patel@collabora.com> From: Shreeya Patel In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On 11/08/22 16:13, Dmitry Osipenko wrote: > On 8/11/22 13:14, Shreeya Patel wrote: >> + case IIO_CHAN_INFO_RAW: >> + ret = ltrf216a_set_power_state(data, true); >> + if (ret) >> + return ret; >> + mutex_lock(&data->lock); >> + ret = ltrf216a_read_data(data, LTRF216A_ALS_DATA_0); >> + mutex_unlock(&data->lock); > ltrf216a_set_power_state(data, false) should be called before return. ah! yes, missed that. Thanks for pointing out. I'll send a v2. Thanks, Shreeya Patel >> + if (ret < 0) >> + return ret; >> + *val = ret; >> + ltrf216a_set_power_state(data, false); >