From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andrea Collamati <andrea.collamati@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: dac: add mcp4728.yaml
Date: Fri, 21 Jul 2023 10:22:54 +0200 [thread overview]
Message-ID: <fe062725-e9b5-bcc6-d515-8e2d4989301a@linaro.org> (raw)
In-Reply-To: <4898bc33-5245-8fb2-e5e6-8ea1a8f32e1e@linaro.org>
On 21/07/2023 10:21, Krzysztof Kozlowski wrote:
>> + - |
>> + i2c {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + mcp4728@60 {
>
> The same... Probably more comments were ignored, so:
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
Damn, this is my third comment about the same. Here was second:
https://lore.kernel.org/all/5e5d1a1e-f106-9dd6-c19e-f933e8e70dd4@kernel.org/
so you nicely ignore feedback. NAK.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-21 8:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 15:40 [PATCH v3 0/2] add MCP4728 I2C DAC driver Andrea Collamati
2023-07-20 15:40 ` [PATCH v3 1/2] dt-bindings: iio: dac: add mcp4728.yaml Andrea Collamati
2023-07-20 17:01 ` Conor Dooley
2023-07-23 4:59 ` Andrea Collamati
2023-07-21 8:21 ` Krzysztof Kozlowski
2023-07-21 8:22 ` Krzysztof Kozlowski [this message]
2023-07-21 12:02 ` Andrea Collamati
2023-07-21 11:58 ` Andrea Collamati
2023-07-21 12:07 ` Krzysztof Kozlowski
2023-07-20 15:40 ` [PATCH v3 2/2] iio: add MCP4728 I2C DAC driver Andrea Collamati
2023-07-20 19:13 ` Jonathan Cameron
2023-07-21 19:47 ` Andrea Collamati
2023-07-23 11:34 ` Jonathan Cameron
2023-07-23 5:09 ` Andrea Collamati
2023-07-23 11:41 ` Jonathan Cameron
2023-07-23 12:15 ` Andrea Collamati
2023-07-23 12:47 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe062725-e9b5-bcc6-d515-8e2d4989301a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrea.collamati@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox