[PATCH] iio: proximity: pulsedlight-lidar-lite-v2: cleanup power management

[PATCH] iio: proximity: pulsedlight-lidar-lite-v2: cleanup power management

[Matt Ranostay]

Remove pm_runtime_mark_last_busy() call that wasn't need in the probe
since the device should be put to sleep

Signed-off-by: Matt Ranostay <matt@ranostay.consulting>
---
 drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
index 3141c3c161bb..1fa9eefa0982 100644
--- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
+++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
@@ -301,8 +301,6 @@ static int lidar_probe(struct i2c_client *client,
 	if (ret)
 		goto error_unreg_buffer;
 	pm_runtime_enable(&client->dev);
-
-	pm_runtime_mark_last_busy(&client->dev);
 	pm_runtime_idle(&client->dev);
 
 	return 0;
-- 
2.7.4

Re: [PATCH] iio: proximity: pulsedlight-lidar-lite-v2: cleanup power management

[Jonathan Cameron]

On 15/10/16 19:04, Matt Ranostay wrote:
> Remove pm_runtime_mark_last_busy() call that wasn't need in the probe
> since the device should be put to sleep
> 
> Signed-off-by: Matt Ranostay <matt@ranostay.consulting>
Hi Matt,

I don't really follow what you are addressing here.
Is the point that without this call it will suspend immediately?
I could figure this out from the pm docs based on a quick skim
read.

Or is it simply that the pm_runtime_idle call following it
will suspend immediately whatever this value contains?


Jonathan
> ---
>  drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> index 3141c3c161bb..1fa9eefa0982 100644
> --- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> +++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> @@ -301,8 +301,6 @@ static int lidar_probe(struct i2c_client *client,
>  	if (ret)
>  		goto error_unreg_buffer;
>  	pm_runtime_enable(&client->dev);
> -
> -	pm_runtime_mark_last_busy(&client->dev);
>  	pm_runtime_idle(&client->dev);
>  
>  	return 0;
> 

Re: [PATCH] iio: proximity: pulsedlight-lidar-lite-v2: cleanup power management

[Matt Ranostay]

On Sun, Oct 16, 2016 at 6:41 AM, Jonathan Cameron <jic23@kernel.org> wrote:
> On 15/10/16 19:04, Matt Ranostay wrote:
>> Remove pm_runtime_mark_last_busy() call that wasn't need in the probe
>> since the device should be put to sleep
>>
>> Signed-off-by: Matt Ranostay <matt@ranostay.consulting>
> Hi Matt,
>
> I don't really follow what you are addressing here.
> Is the point that without this call it will suspend immediately?
> I could figure this out from the pm docs based on a quick skim
> read.
>
> Or is it simply that the pm_runtime_idle call following it
> will suspend immediately whatever this value contains?

Basically it going to be suspended once pm_runtime_idle() is called,
and setting the last busy is useless and not needed.
Clearly this doesn't affect the device running but just makes the code
more consistent with other uses.

>
>
> Jonathan
>> ---
>>  drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
>> index 3141c3c161bb..1fa9eefa0982 100644
>> --- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
>> +++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
>> @@ -301,8 +301,6 @@ static int lidar_probe(struct i2c_client *client,
>>       if (ret)
>>               goto error_unreg_buffer;
>>       pm_runtime_enable(&client->dev);
>> -
>> -     pm_runtime_mark_last_busy(&client->dev);
>>       pm_runtime_idle(&client->dev);
>>
>>       return 0;
>>
>

Re: [PATCH] iio: proximity: pulsedlight-lidar-lite-v2: cleanup power management

[Jonathan Cameron]

On 16/10/16 18:52, Matt Ranostay wrote:
> On Sun, Oct 16, 2016 at 6:41 AM, Jonathan Cameron <jic23@kernel.org> wrote:
>> On 15/10/16 19:04, Matt Ranostay wrote:
>>> Remove pm_runtime_mark_last_busy() call that wasn't need in the probe
>>> since the device should be put to sleep
>>>
>>> Signed-off-by: Matt Ranostay <matt@ranostay.consulting>
>> Hi Matt,
>>
>> I don't really follow what you are addressing here.
>> Is the point that without this call it will suspend immediately?
>> I could figure this out from the pm docs based on a quick skim
>> read.
>>
>> Or is it simply that the pm_runtime_idle call following it
>> will suspend immediately whatever this value contains?
> 
> Basically it going to be suspended once pm_runtime_idle() is called,
> and setting the last busy is useless and not needed.
> Clearly this doesn't affect the device running but just makes the code
> more consistent with other uses.

I added a quote of this to the patch description and applied.

Thanks,

Jonathan
> 
>>
>>
>> Jonathan
>>> ---
>>>  drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 2 --
>>>  1 file changed, 2 deletions(-)
>>>
>>> diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
>>> index 3141c3c161bb..1fa9eefa0982 100644
>>> --- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
>>> +++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
>>> @@ -301,8 +301,6 @@ static int lidar_probe(struct i2c_client *client,
>>>       if (ret)
>>>               goto error_unreg_buffer;
>>>       pm_runtime_enable(&client->dev);
>>> -
>>> -     pm_runtime_mark_last_busy(&client->dev);
>>>       pm_runtime_idle(&client->dev);
>>>
>>>       return 0;
>>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>