From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: iio: Rename a jump label in iio_buffer_store_watermark()
Date: Sun, 25 Sep 2016 17:17:25 +0200 [thread overview]
Message-ID: <ff3e7353-894b-4fb2-b72c-74dcb1a8f14e@users.sourceforge.net> (raw)
In-Reply-To: <6da5896d-a605-300e-568c-b6b3c6e49eef@kernel.org>
> It's not an inappropriate identifier as it stands. The point is
> that it could be better.
Thanks for your interest in clarifying further improvement possibilities.
>>> Which tool is spitting it out?
>>
>> Are you looking for any special tool?
> I was wondering how you identified these particular
> issues as I wanted to know the logic behind the test.
Do you get any related ideas from information in a message like
"Source code review around jump label usage" (from 2015-12-11)?
https://lkml.org/lkml/2015/12/11/378
https://lkml.kernel.org/r/<566ABCD9.1060404@users.sourceforge.net>
>> Which test do you mean?
> Whatever you used to find these jump labels
There is a general possibility that dedicated scripts for the semantic
patch language can also adjust jump labels as I suggested it for five
functions in this software.
> (the patch series description suggested it was a static checker).
The corresponding five patches are just a result of a source code review
by the means of a current text editor wit extra support for programming.
How do you think about to improve the capabilities of tools for advanced
static source code analysis any further?
Regards,
Markus
next prev parent reply other threads:[~2016-09-25 15:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <566ABCD9.1060404@users.sourceforge.net>
2015-12-26 13:04 ` [PATCH] iio: qcom-spmi-vadc: One check less in vadc_measure_ref_points() after error detection SF Markus Elfring
2016-01-02 18:28 ` Jonathan Cameron
2016-09-24 6:22 ` [PATCH 0/7] iio: Fine-tuning for several function implementations SF Markus Elfring
2016-09-24 6:24 ` [PATCH 1/7] iio: Use kmalloc_array() in iio_scan_mask_set() SF Markus Elfring
2016-09-24 15:36 ` Jonathan Cameron
2016-09-24 16:18 ` SF Markus Elfring
2016-09-24 16:36 ` Jonathan Cameron
2016-09-24 6:25 ` [PATCH 2/7] iio: Rename a jump label in iio_buffer_store_watermark() SF Markus Elfring
2016-09-24 15:32 ` Jonathan Cameron
2016-09-24 19:21 ` SF Markus Elfring
2016-09-25 8:45 ` Jonathan Cameron
2016-09-25 13:00 ` SF Markus Elfring
2016-09-25 14:23 ` Jonathan Cameron
2016-09-25 15:17 ` SF Markus Elfring [this message]
2016-09-25 16:49 ` Jonathan Cameron
2016-09-25 17:31 ` SF Markus Elfring
2016-09-24 6:26 ` [PATCH 3/7] iio: Rename a jump label in iio_buffer_store_enable() SF Markus Elfring
2016-09-24 6:28 ` [PATCH 4/7] iio: Rename a jump label in iio_buffer_write_length() SF Markus Elfring
2016-09-24 6:29 ` [PATCH 5/7] iio: Rename a jump label in iio_scan_el_ts_store() SF Markus Elfring
2016-09-24 6:30 ` [PATCH 6/7] iio: Rename a jump label in iio_scan_el_store() SF Markus Elfring
2016-09-24 6:31 ` [PATCH 7/7] iio: Adjust checks for null pointers in six functions SF Markus Elfring
2016-09-25 14:24 ` Jonathan Cameron
2016-09-25 14:44 ` SF Markus Elfring
2016-09-25 16:51 ` Jonathan Cameron
2016-09-25 17:45 ` SF Markus Elfring
2016-09-25 18:15 ` Al Viro
2016-09-25 19:30 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff3e7353-894b-4fb2-b72c-74dcb1a8f14e@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=jic23@kernel.org \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).