From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.web.de ([212.227.15.4]:58090 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966373AbcIYPRu (ORCPT ); Sun, 25 Sep 2016 11:17:50 -0400 Subject: Re: iio: Rename a jump label in iio_buffer_store_watermark() To: Jonathan Cameron References: <566ABCD9.1060404@users.sourceforge.net> <50eb1352-fb0a-1cf5-70d8-48fe8f98b9eb@users.sourceforge.net> <69f22bcd-9945-2214-9f80-4b42f95a3d80@users.sourceforge.net> <6da5896d-a605-300e-568c-b6b3c6e49eef@kernel.org> Cc: linux-iio@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: Date: Sun, 25 Sep 2016 17:17:25 +0200 MIME-Version: 1.0 In-Reply-To: <6da5896d-a605-300e-568c-b6b3c6e49eef@kernel.org> Content-Type: text/plain; charset=utf-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org > It's not an inappropriate identifier as it stands. The point is > that it could be better. Thanks for your interest in clarifying further improvement possibilities. >>> Which tool is spitting it out? >> >> Are you looking for any special tool? > I was wondering how you identified these particular > issues as I wanted to know the logic behind the test. Do you get any related ideas from information in a message like "Source code review around jump label usage" (from 2015-12-11)? https://lkml.org/lkml/2015/12/11/378 https://lkml.kernel.org/r/<566ABCD9.1060404@users.sourceforge.net> >> Which test do you mean? > Whatever you used to find these jump labels There is a general possibility that dedicated scripts for the semantic patch language can also adjust jump labels as I suggested it for five functions in this software. > (the patch series description suggested it was a static checker). The corresponding five patches are just a result of a source code review by the means of a current text editor wit extra support for programming. How do you think about to improve the capabilities of tools for advanced static source code analysis any further? Regards, Markus