linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Waqar Hameed <waqar.hameed@axis.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: <devicetree@vger.kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>, <linux-iio@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
	<kernel@axis.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	<kernel@lists.axis.com>
Subject: Re: [PATCH 1/2] dt-bindings: iio: proximity: Add bindings for Murata IRS-D200
Date: Mon, 19 Jun 2023 12:41:06 +0200	[thread overview]
Message-ID: <pndwmzz1yqu.fsf@axis.com> (raw)
In-Reply-To: <20230617135532.328dc3c8@jic23-huawei>

On Sat, Jun 17, 2023 at 13:55 +0100 Jonathan Cameron <jic23@kernel.org> wrote:

> On Fri, 16 Jun 2023 17:10:42 +0200
> Waqar Hameed <waqar.hameed@axis.com> wrote:
>
>> Murata IRS-D200 is a PIR sensor for human detection. It uses the I2C bus
>> for communication with interrupt support. Add devicetree bindings
>> requiring the compatible string, I2C slave address (reg) and interrupts.
>> 
>> Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
>
> This device will have some power supplies, so I'd expect those to be both
> listed and marked as required (maybe some are optional?)

Right, will add that here (and call `devm_regulator_get_enable()` in
driver's probe).

[...]

>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>
> If it is possible to remove interrupts from requires  - and hence have
> at least a partly functional driver doing basic reading of the sensor
> then that is usually a good idea.   Far too many board designers seem
> to decide that they don't need to wire up interrupt lines.
>
> If it's really hard then don't worry too much.

I see. It would be possible, but would also require some work. Let's
leave it for now then?

  reply	other threads:[~2023-06-19 11:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16 15:10 [PATCH 0/2] Add driver for Murata IRS-D200 Waqar Hameed
2023-06-16 15:10 ` [PATCH 2/2] iio: " Waqar Hameed
2023-06-17  1:37   ` Lars-Peter Clausen
2023-06-19 11:21     ` Waqar Hameed
2023-06-17 13:35   ` Jonathan Cameron
2023-06-19 11:24     ` Waqar Hameed
2023-06-25 11:06       ` Jonathan Cameron
2023-06-30  8:54         ` Waqar Hameed
2023-07-02 10:42           ` Jonathan Cameron
2023-07-03  8:59             ` Waqar Hameed
2023-07-05  7:50               ` Jonathan Cameron
2023-07-12 15:33         ` Waqar Hameed
2023-07-15 16:51           ` Jonathan Cameron
2023-06-16 15:10 ` [PATCH 1/2] dt-bindings: iio: proximity: Add bindings " Waqar Hameed
2023-06-17  8:55   ` Krzysztof Kozlowski
2023-06-19 10:40     ` Waqar Hameed
2023-06-19 11:29       ` Krzysztof Kozlowski
2023-06-17 12:55   ` Jonathan Cameron
2023-06-19 10:41     ` Waqar Hameed [this message]
2023-07-02 10:34       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pndwmzz1yqu.fsf@axis.com \
    --to=waqar.hameed@axis.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=kernel@axis.com \
    --cc=kernel@lists.axis.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).