From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingoo Han Subject: Re: [PATCH] Input: spear-keyboard - Add CONFIG_PM_SLEEP to suspend/resume functions Date: Tue, 28 Oct 2014 09:34:06 +0900 Message-ID: <000601cff246$e192a3b0$a4b7eb10$%han@samsung.com> References: <000801cff1e2$2427ba40$6c772ec0$%han@samsung.com> <20141027233744.GC7594@dtor-ws> <000001cff242$80476680$80d63380$%han@samsung.com> <20141028001100.GF7594@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:51223 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985AbaJ1Adt (ORCPT ); Mon, 27 Oct 2014 20:33:49 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NE400ANLPKCFYC0@mailout3.samsung.com> for linux-input@vger.kernel.org; Tue, 28 Oct 2014 09:33:48 +0900 (KST) In-reply-to: <20141028001100.GF7594@dtor-ws> Content-language: ko Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: 'Dmitry Torokhov' Cc: linux-input@vger.kernel.org, 'Viresh Kumar' , 'Jingoo Han' On Tuesday, October 28, 2014 9:11 AM, Dmitry Torokhov wrote: > On Tue, Oct 28, 2014 at 09:02:44AM +0900, Jingoo Han wrote: > > On Tuesday, October 28, 2014 8:38 AM, Dmitry Torokhov wrote: > > > On Mon, Oct 27, 2014 at 09:32:58PM +0900, Jingoo Han wrote: > > > > Add CONFIG_PM_SLEEP to suspend/resume functions > > > > > > > > Add CONFIG_PM_SLEEP to suspend/resume functions instead of > > > > CONFIG_PM to fix the following build warning when CONFIG_PM_SLEEP > > > > is not selected and CONFIG_PM is selected. This is because sleep > > > > PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when the > > > > CONFIG_PM_SLEEP is enabled. > > > > > > Recently I've become a fan of __maybe_unused markings as they insulate > > > us from various CONFIG changes in unrelated subsystems, I'll transform > > > this patch to use them instead. > > > > OK, I see. I have no objection. > > Then, how about changing other usages of CONFIG_PM_SLEEP/CONFIG_PM > > to __maybe_unused annotation? Personally, I prefer to increase build > > coverage than using #ifdef guards. Someone, however, argued that #ifdef > > guards should be used in this case because the size of binary can be > > reduced. How about your opinion? > > The optimizer is supposed to drop functions marked as '__maybe_unused' > if they are indeed unused so size of the binary should not change. Oh, I really appreciate your reply. :-) Then, how about changing other usages of CONFIG_PM_SLEEP/CONFIG_PM to __maybe_unused annotation? If you don't have any objection, I will send one single patch for this. Best regards, Jingoo Han > > Thanks. > > -- > Dmitry