linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han@samsung.com>
To: 'Lars-Peter Clausen' <lars@metafoo.de>
Cc: 'Dmitry Torokhov' <dmitry.torokhov@gmail.com>,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH 6/7] Input: pwm-beepe: remove HAVE_PWM dependencies
Date: Tue, 11 Feb 2014 21:18:54 +0900	[thread overview]
Message-ID: <000901cf2723$6e68bc10$4b3a3430$%han@samsung.com> (raw)
In-Reply-To: <52FA12D1.4020408@metafoo.de>

On Tuesday, February 11, 2014 9:09 PM, Lars-Peter Clausen wrote:
> On 02/10/2014 02:16 AM, Jingoo Han wrote:
> > The HAVE_PWM symbol is only for legacy platforms that provide
> > the PWM API without using the generic framework. However, legacy
> > PWM drivers were already moved to the generic PWM framework.
> > Thus, HAVE_PWM should be removed, because HAVE_PWM is not
> > required anymore.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> 
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Hi Lars-Peter Clausen,

I really appreciate your Acked-by. However, the same patch was
already submitted by Sascha Hauer.[1] So, please ignore this patch.
Thank you.

[1] https://lkml.org/lkml/2014/1/16/262

Best regards,
Jingoo Han

> 
> > ---
> >   drivers/input/misc/Kconfig |    2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> > index ae74df7..762e6d2 100644
> > --- a/drivers/input/misc/Kconfig
> > +++ b/drivers/input/misc/Kconfig
> > @@ -470,7 +470,7 @@ config INPUT_PCF8574
> >
> >   config INPUT_PWM_BEEPER
> >   	tristate "PWM beeper support"
> > -	depends on PWM && HAVE_PWM
> > +	depends on PWM
> >   	help
> >   	  Say Y here to get support for PWM based beeper devices.
> >
> >

  reply	other threads:[~2014-02-11 12:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-10  1:07 [PATCH 0/7] Remove HAVE_PWM config option Jingoo Han
2014-02-10  1:15 ` [PATCH 5/7] Input: max8997_haptic: remove HAVE_PWM dependencies Jingoo Han
2014-02-10  1:16 ` [PATCH 6/7] Input: pwm-beepe: " Jingoo Han
2014-02-11 12:08   ` Lars-Peter Clausen
2014-02-11 12:18     ` Jingoo Han [this message]
2014-02-11  3:02 ` [PATCH 0/7] Remove HAVE_PWM config option Jingoo Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000901cf2723$6e68bc10$4b3a3430$%han@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).