* [PATCH 0/7] Remove HAVE_PWM config option
@ 2014-02-10 1:07 Jingoo Han
2014-02-10 1:15 ` [PATCH 5/7] Input: max8997_haptic: remove HAVE_PWM dependencies Jingoo Han
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jingoo Han @ 2014-02-10 1:07 UTC (permalink / raw)
To: 'Arnd Bergmann', 'Ralf Baechle',
'Dmitry Torokhov', 'Thierry Reding'
Cc: 'Linus Walleij', 'Russell King - ARM Linux',
'Eric Miao', linux-kernel, linux-arm-kernel, linux-mips,
linux-input, linux-pwm, 'Jingoo Han'
The HAVE_PWM symbol is only for legacy platforms that provide
the PWM API without using the generic framework, while PWM symbol
is used for PWM drivers using the generic PWM framework.
I looked at all HAVE_PWMs in the latest mainline kernel 3.14-rc1.
Three platforms are still using HAVE_PWM as below:
1. ARM - PXA
./arch/arm/mach-pxa/Kconfig
2. ARM - NXP LPC32XX
./arch/arm/Kconfig
config ARCH_LPC32XX
select HAVE_PWM
3. MIPS - Ingenic JZ4740 based machines
./arch/mips/Kconfig
config MACH_JZ4740
select HAVE_PWM
However, the legacy PWM drivers for PXA, LPC32XX, and JZ474 were
already moved to the generic PWM framework.
./drivers/pwm/pwm-pxa.c
./drivers/pwm/pwm-lpc32xx.c
./drivers/pwm/pwm-jz4740.c
In conclusion, HAVE_PWM should be removed, because HAVE_PWM is
NOT required anymore.
Jingoo Han (7):
ARM: pxa: don't select HAVE_PWM
ARM: lpc32xx: don't select HAVE_PWM
ARM: remove HAVE_PWM config option
MIPS: jz4740: don't select HAVE_PWM
Input: max8997_haptic: remove HAVE_PWM dependencies
Input: pwm-beepe: remove HAVE_PWM dependencies
pwm: don't use IS_ENABLED(CONFIG_HAVE_PWM)
arch/arm/Kconfig | 4 ----
arch/arm/mach-pxa/Kconfig | 15 ---------------
arch/mips/Kconfig | 1 -
drivers/input/misc/Kconfig | 4 ++--
include/linux/pwm.h | 2 +-
5 files changed, 3 insertions(+), 23 deletions(-)
I would like to merge these patches as below:
1. Through arm-soc tree
[PATCH 1/7] ARM: pxa: don't select HAVE_PWM
[PATCH 2/7] ARM: lpc32xx: don't select HAVE_PWM
[PATCH 3/7] ARM: remove HAVE_PWM config option
2. Through MIPS tree
[PATCH 4/7] MIPS: jz4740: don't select HAVE_PWM
3. Through Input tree
[PATCH 5/7] Input: max8997_haptic: remove HAVE_PWM dependencies
[PATCH 6/7] Input: pwm-beepe: remove HAVE_PWM dependencies
4. Through PWM tree
[PATCH 7/7] pwm: don't use IS_ENABLED(CONFIG_HAVE_PWM)
After merging these patches, all HAVE_PWM will be removed from
the mainline kernel. Thank you. :-)
Best regards,
Jingoo Han
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 5/7] Input: max8997_haptic: remove HAVE_PWM dependencies
2014-02-10 1:07 [PATCH 0/7] Remove HAVE_PWM config option Jingoo Han
@ 2014-02-10 1:15 ` Jingoo Han
2014-02-10 1:16 ` [PATCH 6/7] Input: pwm-beepe: " Jingoo Han
2014-02-11 3:02 ` [PATCH 0/7] Remove HAVE_PWM config option Jingoo Han
2 siblings, 0 replies; 6+ messages in thread
From: Jingoo Han @ 2014-02-10 1:15 UTC (permalink / raw)
To: 'Dmitry Torokhov'; +Cc: linux-kernel, linux-input
The HAVE_PWM symbol is only for legacy platforms that provide
the PWM API without using the generic framework. However, legacy
PWM drivers were already moved to the generic PWM framework.
Thus, HAVE_PWM should be removed, because HAVE_PWM is not
required anymore.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/input/misc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index 7904ab0..ae74df7 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -156,7 +156,7 @@ config INPUT_MAX8925_ONKEY
config INPUT_MAX8997_HAPTIC
tristate "MAXIM MAX8997 haptic controller support"
- depends on PWM && HAVE_PWM && MFD_MAX8997
+ depends on PWM && MFD_MAX8997
select INPUT_FF_MEMLESS
help
This option enables device driver support for the haptic controller
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 6/7] Input: pwm-beepe: remove HAVE_PWM dependencies
2014-02-10 1:07 [PATCH 0/7] Remove HAVE_PWM config option Jingoo Han
2014-02-10 1:15 ` [PATCH 5/7] Input: max8997_haptic: remove HAVE_PWM dependencies Jingoo Han
@ 2014-02-10 1:16 ` Jingoo Han
2014-02-11 12:08 ` Lars-Peter Clausen
2014-02-11 3:02 ` [PATCH 0/7] Remove HAVE_PWM config option Jingoo Han
2 siblings, 1 reply; 6+ messages in thread
From: Jingoo Han @ 2014-02-10 1:16 UTC (permalink / raw)
To: 'Dmitry Torokhov'
Cc: linux-kernel, linux-input, 'Jingoo Han',
'Lars-Peter Clausen'
The HAVE_PWM symbol is only for legacy platforms that provide
the PWM API without using the generic framework. However, legacy
PWM drivers were already moved to the generic PWM framework.
Thus, HAVE_PWM should be removed, because HAVE_PWM is not
required anymore.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/input/misc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index ae74df7..762e6d2 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -470,7 +470,7 @@ config INPUT_PCF8574
config INPUT_PWM_BEEPER
tristate "PWM beeper support"
- depends on PWM && HAVE_PWM
+ depends on PWM
help
Say Y here to get support for PWM based beeper devices.
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 6/7] Input: pwm-beepe: remove HAVE_PWM dependencies
2014-02-10 1:16 ` [PATCH 6/7] Input: pwm-beepe: " Jingoo Han
@ 2014-02-11 12:08 ` Lars-Peter Clausen
2014-02-11 12:18 ` Jingoo Han
0 siblings, 1 reply; 6+ messages in thread
From: Lars-Peter Clausen @ 2014-02-11 12:08 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Dmitry Torokhov', linux-kernel, linux-input
On 02/10/2014 02:16 AM, Jingoo Han wrote:
> The HAVE_PWM symbol is only for legacy platforms that provide
> the PWM API without using the generic framework. However, legacy
> PWM drivers were already moved to the generic PWM framework.
> Thus, HAVE_PWM should be removed, because HAVE_PWM is not
> required anymore.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> drivers/input/misc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index ae74df7..762e6d2 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -470,7 +470,7 @@ config INPUT_PCF8574
>
> config INPUT_PWM_BEEPER
> tristate "PWM beeper support"
> - depends on PWM && HAVE_PWM
> + depends on PWM
> help
> Say Y here to get support for PWM based beeper devices.
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 6/7] Input: pwm-beepe: remove HAVE_PWM dependencies
2014-02-11 12:08 ` Lars-Peter Clausen
@ 2014-02-11 12:18 ` Jingoo Han
0 siblings, 0 replies; 6+ messages in thread
From: Jingoo Han @ 2014-02-11 12:18 UTC (permalink / raw)
To: 'Lars-Peter Clausen'
Cc: 'Dmitry Torokhov', linux-kernel, linux-input,
'Jingoo Han'
On Tuesday, February 11, 2014 9:09 PM, Lars-Peter Clausen wrote:
> On 02/10/2014 02:16 AM, Jingoo Han wrote:
> > The HAVE_PWM symbol is only for legacy platforms that provide
> > the PWM API without using the generic framework. However, legacy
> > PWM drivers were already moved to the generic PWM framework.
> > Thus, HAVE_PWM should be removed, because HAVE_PWM is not
> > required anymore.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Hi Lars-Peter Clausen,
I really appreciate your Acked-by. However, the same patch was
already submitted by Sascha Hauer.[1] So, please ignore this patch.
Thank you.
[1] https://lkml.org/lkml/2014/1/16/262
Best regards,
Jingoo Han
>
> > ---
> > drivers/input/misc/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> > index ae74df7..762e6d2 100644
> > --- a/drivers/input/misc/Kconfig
> > +++ b/drivers/input/misc/Kconfig
> > @@ -470,7 +470,7 @@ config INPUT_PCF8574
> >
> > config INPUT_PWM_BEEPER
> > tristate "PWM beeper support"
> > - depends on PWM && HAVE_PWM
> > + depends on PWM
> > help
> > Say Y here to get support for PWM based beeper devices.
> >
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/7] Remove HAVE_PWM config option
2014-02-10 1:07 [PATCH 0/7] Remove HAVE_PWM config option Jingoo Han
2014-02-10 1:15 ` [PATCH 5/7] Input: max8997_haptic: remove HAVE_PWM dependencies Jingoo Han
2014-02-10 1:16 ` [PATCH 6/7] Input: pwm-beepe: " Jingoo Han
@ 2014-02-11 3:02 ` Jingoo Han
2 siblings, 0 replies; 6+ messages in thread
From: Jingoo Han @ 2014-02-11 3:02 UTC (permalink / raw)
To: 'Arnd Bergmann', 'Ralf Baechle',
'Dmitry Torokhov', 'Thierry Reding'
Cc: 'Linus Walleij', 'Russell King - ARM Linux',
'Eric Miao', linux-kernel, linux-arm-kernel, linux-mips,
linux-input, linux-pwm, 'Jingoo Han',
'Sascha Hauer', 'Roland Stigge'
On Monday, February 10, 2014 10:07 AM, Jingoo Han wrote:
>
> The HAVE_PWM symbol is only for legacy platforms that provide
> the PWM API without using the generic framework, while PWM symbol
> is used for PWM drivers using the generic PWM framework.
>
> I looked at all HAVE_PWMs in the latest mainline kernel 3.14-rc1.
> Three platforms are still using HAVE_PWM as below:
>
> 1. ARM - PXA
> ./arch/arm/mach-pxa/Kconfig
>
> 2. ARM - NXP LPC32XX
> ./arch/arm/Kconfig
> config ARCH_LPC32XX
> select HAVE_PWM
>
> 3. MIPS - Ingenic JZ4740 based machines
> ./arch/mips/Kconfig
> config MACH_JZ4740
> select HAVE_PWM
>
> However, the legacy PWM drivers for PXA, LPC32XX, and JZ474 were
> already moved to the generic PWM framework.
> ./drivers/pwm/pwm-pxa.c
> ./drivers/pwm/pwm-lpc32xx.c
> ./drivers/pwm/pwm-jz4740.c
>
> In conclusion, HAVE_PWM should be removed, because HAVE_PWM is
> NOT required anymore.
>
> Jingoo Han (7):
> ARM: pxa: don't select HAVE_PWM
> ARM: lpc32xx: don't select HAVE_PWM
> ARM: remove HAVE_PWM config option
> MIPS: jz4740: don't select HAVE_PWM
> Input: max8997_haptic: remove HAVE_PWM dependencies
> Input: pwm-beepe: remove HAVE_PWM dependencies
> pwm: don't use IS_ENABLED(CONFIG_HAVE_PWM)
>
> arch/arm/Kconfig | 4 ----
> arch/arm/mach-pxa/Kconfig | 15 ---------------
> arch/mips/Kconfig | 1 -
> drivers/input/misc/Kconfig | 4 ++--
> include/linux/pwm.h | 2 +-
> 5 files changed, 3 insertions(+), 23 deletions(-)
(+cc Sascha Hauer, Roland Stigge)
The same patch was already submitted by Sascha Hauer. [1]
So, please ignore this patch. Thank you.
[1] https://lkml.org/lkml/2014/1/16/262
Best regards,
Jingoo Han
>
> I would like to merge these patches as below:
>
> 1. Through arm-soc tree
> [PATCH 1/7] ARM: pxa: don't select HAVE_PWM
> [PATCH 2/7] ARM: lpc32xx: don't select HAVE_PWM
> [PATCH 3/7] ARM: remove HAVE_PWM config option
>
> 2. Through MIPS tree
> [PATCH 4/7] MIPS: jz4740: don't select HAVE_PWM
>
> 3. Through Input tree
> [PATCH 5/7] Input: max8997_haptic: remove HAVE_PWM dependencies
> [PATCH 6/7] Input: pwm-beepe: remove HAVE_PWM dependencies
>
> 4. Through PWM tree
> [PATCH 7/7] pwm: don't use IS_ENABLED(CONFIG_HAVE_PWM)
>
> After merging these patches, all HAVE_PWM will be removed from
> the mainline kernel. Thank you. :-)
>
> Best regards,
> Jingoo Han
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-11 12:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-10 1:07 [PATCH 0/7] Remove HAVE_PWM config option Jingoo Han
2014-02-10 1:15 ` [PATCH 5/7] Input: max8997_haptic: remove HAVE_PWM dependencies Jingoo Han
2014-02-10 1:16 ` [PATCH 6/7] Input: pwm-beepe: " Jingoo Han
2014-02-11 12:08 ` Lars-Peter Clausen
2014-02-11 12:18 ` Jingoo Han
2014-02-11 3:02 ` [PATCH 0/7] Remove HAVE_PWM config option Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).