From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54B1C3E3C68; Fri, 26 Jun 2026 07:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782459742; cv=none; b=oK4F4zcRe2Y91UkR5I8i07YQ+KWKQvCGP2sUt3Q6B6h+6UCNZLn9SNj6Rj8dG1MqLAzDP6s+FMXp/PajUhPEXBZWb3TDiAk4wk9Cr9HCfcXa4W+m1v88Q3jVIreq/TnhU412QyC247jRZDVzANKEECgBBoP5DHbPWYVLMmajISA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782459742; c=relaxed/simple; bh=/9bJzCLXu+XRWRNZvRgGOcrm76MKLAlFsEhJkA0NLp0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kyhcQ5DZZ2AIg2CT0R4SucdiIPyF7FvQws+U/DpOiHN83UsJNHn24lMKAjD6smBUqqXuxATZoU/c1i1fhmFITT/dlOkGYV9wRKlRsANejMYwYLt6UcpbiG53MOGMoPCVP+4dE1qBkyEWBnVK1YeCp7FvHW3VgnTdjRRiHIBA/AQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OoQCFvDp; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OoQCFvDp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A29E1F000E9; Fri, 26 Jun 2026 07:42:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782459741; bh=etYENOeSZId+ruwOU1toe2ZhPkwps93/WrI7AqM4gz8=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=OoQCFvDpvxlup1UMU6B1GZC/J+bKGycENqNE3EFhgcwOCVlerqtANzW4Oa+p6tRKN QAtDbcwFDFnbbZuo2u63qW0RaCEOg9l3eSbJVKRzfAg1XHGLIrDKru27/766ikyNfO Zv8J3tg8EtvGLRQU48YfuUy6pv+Htu7ucmkrhCkoDRuCWJo/CP0lj53As4YUlbIbsr 9A89rtFXVSm+TlJRLvM7pZg+OOFR3tnL3gIhNMOQFWHAxfGoqFo9vg4wtcSc0WURtT 4IoCR9TJeoOBzGTpU56kw3ZazeTKGhzugONO6XIpBT6NOSxyFNWLxNxKY+cUZQlJNH hvy6RnqopDwFQ== Message-ID: <001abe91-5b9a-4d8b-a52a-fff1b1558ba4@kernel.org> Date: Fri, 26 Jun 2026 09:42:13 +0200 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sdm845-oneplus: Update compatible to include model To: Dmitry Torokhov Cc: David Heidelberg , Krzysztof Kozlowski , Konrad Dybcio , Rob Herring , Conor Dooley , "Jason A. Donenfeld" , Matthias Schiffer , Vincent Huang , Bjorn Andersson , Konrad Dybcio , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org References: <20260523-synaptics-rmi4-dt-v2-0-0645122babdc@ixit.cz> <20260523-synaptics-rmi4-dt-v2-2-0645122babdc@ixit.cz> <1d0e7e31-f808-4347-955a-7246dea208f5@ixit.cz> <742c7a13-9465-40e8-8990-e679712e9784@ixit.cz> <52b7dd3a-3f6f-474c-8386-4fc2776b185b@ixit.cz> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 25/06/2026 18:57, Dmitry Torokhov wrote: > Hi Krzysztof, > > On Thu, Jun 25, 2026 at 10:23:54AM +0200, Krzysztof Kozlowski wrote: >> On 25/06/2026 06:53, Dmitry Torokhov wrote: >>> On Wed, Jun 24, 2026 at 04:37:25PM +0200, David Heidelberg wrote: >>>> On 24/06/2026 06:28, Dmitry Torokhov wrote: >>>>> Hi David, >>>>> >>>>> On Sun, Jun 21, 2026 at 07:11:45PM +0200, David Heidelberg wrote: >>>>>> On 28/05/2026 00:13, David Heidelberg wrote: >>>>>>> On 27/05/2026 23:56, Dmitry Torokhov wrote: >>>>>>>> Hi David, >>>>>>>> >>>>>>>> On Sat, May 23, 2026 at 11:45:35AM +0200, David Heidelberg via B4 Relay wrote: >>>>>>>>> From: David Heidelberg >>>>>>>>> >>>>>>>>> We know the driver is reporting s3706b, introduce the compatible so we >>>>>>>>> can more easily introduce quirks for weird touchscreen replacements in >>>>>>>>> followup series. >>>>>>>>> >>>>>>>>> Reviewed-by: Konrad Dybcio >>>>>>>>> Signed-off-by: David Heidelberg >>>>>>>>> --- >>>>>>>>>   arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 2 +- >>>>>>>>>   1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>>>> >>>>>>>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi >>>>>>>>> b/arch/ arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi >>>>>>>>> index 6b7378cf4d493..148164d456a5a 100644 >>>>>>>>> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi >>>>>>>>> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi >>>>>>>>> @@ -475,17 +475,17 @@ bq27441_fg: bq27441-battery@55 { >>>>>>>>>       }; >>>>>>>>>   }; >>>>>>>>>   &i2c12 { >>>>>>>>>       status = "okay"; >>>>>>>>>       clock-frequency = <400000>; >>>>>>>>>       synaptics-rmi4-i2c@20 { >>>>>>>>> -        compatible = "syna,rmi4-i2c"; >>>>>>>>> +        compatible = "syna,rmi4-s3706b", "syna,rmi4-i2c"; >>>>>>>> >>>>>>>> So I believe we established that this device (s3706b) does not in fact >>>>>>>> implement rmi4 protocol properly. Why do we have "syna,rmi4-i2c" as a >>>>>>>> fallback? Shouldn't it be just "syna,rmi4-s3706b"? >>>>>>> >>>>>>> The vendor supplies s3706b which does implement the RMI4 properly. >>>>>>> >>>>>>> The 3rd party replacement impersonating original parts may not implement >>>>>>> it properly, but I don't address this issue in this initial submission. >>>>>>> >>>>>>> With this compatible we know which original part is used by the vendor >>>>>>> and installed in the phones, so later we can deduct specific sequences >>>>>>> for the replacement aftermarket parts to keep phone touchscreen working >>>>>>> same as they do on Android without affecting other devices. >>>>>> >>>>>> Hello Dmitry. >>>>>> >>>>>> May I ask what is currently preventing this series from moving forward? >>>>>> >>>>>> The first version was posted in 2023 [1]. I picked it up again in 2025 [2] >>>>>> and am now on the 9th iteration (this patchset). At this point, the series >>>>>> has been under discussion for well over a year, with relatively little >>>>>> feedback and increasingly long gaps between review rounds. >>>>>> >>>>>> The current approach is based on the guidance I have received so far, >>>>>> including suggestions from the device-tree maintainers. When concerns were >>>>>> raised, I tried to address them and rework the series accordingly. >>>>>> >>>>>> What I am struggling with is understanding what specific issue still needs >>>>>> to be resolved before these patches can be accepted. If there are remaining >>>>>> requirements, objections to the approach, or technical concerns that I have >>>>>> not addressed, I would appreciate having them stated explicitly so I can >>>>>> work on them. >>>>>> >>>>>> I also split out the straightforward, self-contained changes in the hope >>>>>> that at least those could progress independently while I continued working >>>>>> on any follow-up requirements. However, even those patches do not appear to >>>>>> be moving forward. >>>>>> >>>>>> Could you please clarify what outcome you would like to see from this >>>>>> series, and what concrete changes would be required to get it accepted? >>>>> >>>>> I am still confused about how you want to differentiate between the full >>>>> RMI4 support vs the OnePlus flavor. The "syna,rmi4-s3706b", as you >>>>> mentioned, implements RMI4 protocol properly, so we do not need to >>>>> actually have it documented neither in binding nor in DTS. >>>> >>>> --- part 1 --- >>>> >>>> This series addresses identification within device-tree. It's normal >>>> recommended practice. >>>> >>>> If we know, the device ships specific, but **compliant** variant, we just >>>> put it as compatible = "more-specific", "less-specific"; in this case >>>> "syna,rmi4-s3706b", "syna,rmi4-i2c" >>>> >>>> This approach is used everywhere. This has nothing to do with after-market parts. >>> >>> We do this in many cases, sometimes when a part has different timings or >>> maybe additional functionality compared to the base model. >> >> Generic expectation is to have always dedicated front compatible for >> every device. rmi4-i2c is not really specific enough, more like a >> family, thus a specific device compatible is essential by the DT rules. > > Essential in what way? What will break if such compatible is not there? Essential by the rules we defined for DT and documented in writing-bindings. > We have lived without it for many years and will continue live happily > without it for years to come. Does not matter if compatible is used or not. The rules are dictating that. Best regards, Krzysztof