Re: New Elantech touchpad version?

Re: New Elantech touchpad version?

[Dmitry Torokhov]

Hi Patrick,

On Mon, Jun 20, 2016 at 06:10:41PM +0000, Patrick Lessard wrote:
> Hello!
> 
> First, thank you very much for creating a driver for the Elantech touchpads. Very appeciated.
> 
> I’ve contacted one of the original author, Arjan Opmeer and he directed me to you. (those 2 email addresses actually)
> 
> I just bought a HP Pavilion 14-ab057ca laptop and I think it uses a new version of the Elantech touchpad.
> 
> On linux, when I boot, I get this message :
> 
> « psmouse serio1: elantech: unknown hardware version, aborting... »
> 
> By looking at the kernel driver code in elantech.c below, I might try a quick patch and add a case higher than 14, compile and try it.

Looking at HP site it seems that at least some batches of this laptop
are shipping with Elan touchpads.

KT, do we need to expand the list in elantech_set_properties() to
include more IC types?

> 
> If succesfull, could you include a fix in the near future?
> 
> Are you still maintaining this driver?
> 
> How should I proceed?
> 
> Thank you very much for your attention.
> 
> Patrick.
> 
> 
> Code snippet :
> 
> ….
> 
> static int elantech_set_properties(struct elantech_data *etd)
> {
>         /* This represents the version of IC body. */
>         int ver = (etd->fw_version & 0x0f0000) >> 16;
> 
>         /* Early version of Elan touchpads doesn't obey the rule. */
>         if (etd->fw_version < 0x020030 || etd->fw_version == 0x020600)
>                etd->hw_version = 1;
>         else {
>                switch (ver) {
>                case 2:
>                case 4:
>                        etd->hw_version = 2;
>                        break;
>                case 5:
>                        etd->hw_version = 3;
>                        break;
>                case 6:
>                case 7:
>                case 8:
>                case 9:
>                case 10:
>                case 13:
>                case 14:
>                        etd->hw_version = 4;
>                        break;
>                default:
>                        return -1;
>                }
>         }
> 

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE : New Elantech touchpad version?

[Patrick Lessard]

Hello,

Just tested an ugly quick patch just for testing. By assigning it a hw_version of 4 it works fine.

I'll find out what fw_version it gives and see how it translate for the ver variable

You can see what I did below. I just played with the "default" statement.

Thank you.

Patrick.

static int elantech_set_properties(struct elantech_data *etd)
{
        /* This represents the version of IC body. */
        int ver = (etd->fw_version & 0x0f0000) >> 16;

        /* Early version of Elan touchpads doesn't obey the rule. */
        if (etd->fw_version < 0x020030 || etd->fw_version == 0x020600)
                etd->hw_version = 1;
        else {
                switch (ver) {
                case 2:
                case 4:
                        etd->hw_version = 2;
                        break;
                case 5:
                        etd->hw_version = 3;
                        break;
                case 6:
                case 7:
                case 8:
                case 9:
                case 10:
                case 13:
                case 14:
                        etd->hw_version = 4;
                        break;
                default:
                        etd->hw_version = 4;
                        break;
                        /*return -1;*/



The information in this message, including in all attachments, is
confidential or privileged. In the event you have received this message in error
and are not the intended recipient, you are hereby advised that any use, copying
or reproduction of this document is strictly forbidden. Please notify
immediately the sender of this error and destroy this message, including its
attachments, as the case may be.
</P>
L'information apparaissant dans ce message electronique et dans les documents
qui y sont joints est de nature confidentielle ou privilegiee. Si ce message
vous est parvenu par erreur et que vous n'en etes pas le destinataire vise, vous
etes par les presentes avise que toute utilisation, copie ou distribution de ce
message est strictement interdite. Vous etes donc prie d’en informer
immediatement l’expediteur et de detruire ce message, ainsi que les documents
qui y sont joints, le

request a hard-copy version.



Ce courriel provient de Patrick.Lessard@cogeco.com . Pour assurer la livraison de futurs envois, veuillez inclure la presente adresse courriel a votre carnet
d’adresses ou votre liste d’expediteurs autorises.
Si vous ne souhaitez plus recevoir de messages promotionnels de la part de Cogeco, veuillez transférer ce courriel a desabonnement@cogeco.com. Merci!
Politique en matiere de protection des renseignements personnels de Cogeco et Engagement en matiere d’anti-spam – Contactez-nous
Cogeco Cable Canada, 5 Place Ville-Marie, Bureau 1700, Montreal, Quebec, H3B 0B3
--
This email is from Patrick.Lessard@cogeco.com . To ensure the delivery of future emails, please add the current email address to your address book or safe senders list.
If you no longer wish to receive promotional emails from Cogeco, please forward this message to unsubscribe@cogeco.com. Thank you!
Privacy Policy and Anti-spam Commitment - Contact us
Cogeco Cable Canada, 5 Place Ville-Marie, Suite 1700, Montreal, Quebec, H3B 0B3

________________________________________
De : Dmitry Torokhov [dmitry.torokhov@gmail.com]
Envoyé : 20 juin 2016 14:21
À : Patrick Lessard; kt.liao@emc.com.tw
Cc : linux-input@vger.kernel.org
Objet : Re: New Elantech touchpad version?

Hi Patrick,

On Mon, Jun 20, 2016 at 06:10:41PM +0000, Patrick Lessard wrote:
> Hello!
>
> First, thank you very much for creating a driver for the Elantech touchpads. Very appeciated.
>
> I’ve contacted one of the original author, Arjan Opmeer and he directed me to you. (those 2 email addresses actually)
>
> I just bought a HP Pavilion 14-ab057ca laptop and I think it uses a new version of the Elantech touchpad.
>
> On linux, when I boot, I get this message :
>
> « psmouse serio1: elantech: unknown hardware version, aborting... »
>
> By looking at the kernel driver code in elantech.c below, I might try a quick patch and add a case higher than 14, compile and try it.

Looking at HP site it seems that at least some batches of this laptop
are shipping with Elan touchpads.

KT, do we need to expand the list in elantech_set_properties() to
include more IC types?

>
> If succesfull, could you include a fix in the near future?
>
> Are you still maintaining this driver?
>
> How should I proceed?
>
> Thank you very much for your attention.
>
> Patrick.
>
>
> Code snippet :
>
> ….
>
> static int elantech_set_properties(struct elantech_data *etd)
> {
>         /* This represents the version of IC body. */
>         int ver = (etd->fw_version & 0x0f0000) >> 16;
>
>         /* Early version of Elan touchpads doesn't obey the rule. */
>         if (etd->fw_version < 0x020030 || etd->fw_version == 0x020600)
>                etd->hw_version = 1;
>         else {
>                switch (ver) {
>                case 2:
>                case 4:
>                        etd->hw_version = 2;
>                        break;
>                case 5:
>                        etd->hw_version = 3;
>                        break;
>                case 6:
>                case 7:
>                case 8:
>                case 9:
>                case 10:
>                case 13:
>                case 14:
>                        etd->hw_version = 4;
>                        break;
>                default:
>                        return -1;
>                }
>         }
>

Thanks.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE : New Elantech touchpad version?

[Patrick Lessard]

Sorry to bother, but here is some additionnal info.

This is what I get from dmesg

[    9.320371] psmouse serio1: elantech: assuming hardware version 4 (with firmware version 0x5c1f04)
[    9.335504] psmouse serio1: elantech: Synaptics capabilities query result 0x10, 0x16, 0x0d.
[    9.350483] psmouse serio1: elantech: Elan sample query result 0d, 01, 86

and calculated version gives 0xC, so 12

If that could help

Patrick.



The information in this message, including in all attachments, is
confidential or privileged. In the event you have received this message in error
and are not the intended recipient, you are hereby advised that any use, copying
or reproduction of this document is strictly forbidden. Please notify
immediately the sender of this error and destroy this message, including its
attachments, as the case may be.
</P>
L'information apparaissant dans ce message electronique et dans les documents
qui y sont joints est de nature confidentielle ou privilegiee. Si ce message
vous est parvenu par erreur et que vous n'en etes pas le destinataire vise, vous
etes par les presentes avise que toute utilisation, copie ou distribution de ce
message est strictement interdite. Vous etes donc prie d’en informer
immediatement l’expediteur et de detruire ce message, ainsi que les documents
qui y sont joints, le

request a hard-copy version.



Ce courriel provient de Patrick.Lessard@cogeco.com . Pour assurer la livraison de futurs envois, veuillez inclure la presente adresse courriel a votre carnet
d’adresses ou votre liste d’expediteurs autorises.
Si vous ne souhaitez plus recevoir de messages promotionnels de la part de Cogeco, veuillez transférer ce courriel a desabonnement@cogeco.com. Merci!
Politique en matiere de protection des renseignements personnels de Cogeco et Engagement en matiere d’anti-spam – Contactez-nous
Cogeco Cable Canada, 5 Place Ville-Marie, Bureau 1700, Montreal, Quebec, H3B 0B3
--
This email is from Patrick.Lessard@cogeco.com . To ensure the delivery of future emails, please add the current email address to your address book or safe senders list.
If you no longer wish to receive promotional emails from Cogeco, please forward this message to unsubscribe@cogeco.com. Thank you!
Privacy Policy and Anti-spam Commitment - Contact us
Cogeco Cable Canada, 5 Place Ville-Marie, Suite 1700, Montreal, Quebec, H3B 0B3

________________________________________
De : Patrick Lessard
Envoyé : 20 juin 2016 19:53
À : Dmitry Torokhov; kt.liao@emc.com.tw
Cc : linux-input@vger.kernel.org
Objet : RE : New Elantech touchpad version?

Hello,

Just tested an ugly quick patch just for testing. By assigning it a hw_version of 4 it works fine.

I'll find out what fw_version it gives and see how it translate for the ver variable

You can see what I did below. I just played with the "default" statement.

Thank you.

Patrick.

static int elantech_set_properties(struct elantech_data *etd)
{
        /* This represents the version of IC body. */
        int ver = (etd->fw_version & 0x0f0000) >> 16;

        /* Early version of Elan touchpads doesn't obey the rule. */
        if (etd->fw_version < 0x020030 || etd->fw_version == 0x020600)
                etd->hw_version = 1;
        else {
                switch (ver) {
                case 2:
                case 4:
                        etd->hw_version = 2;
                        break;
                case 5:
                        etd->hw_version = 3;
                        break;
                case 6:
                case 7:
                case 8:
                case 9:
                case 10:
                case 13:
                case 14:
                        etd->hw_version = 4;
                        break;
                default:
                        etd->hw_version = 4;
                        break;
                        /*return -1;*/

________________________________________
De : Dmitry Torokhov [dmitry.torokhov@gmail.com]
Envoyé : 20 juin 2016 14:21
À : Patrick Lessard; kt.liao@emc.com.tw
Cc : linux-input@vger.kernel.org
Objet : Re: New Elantech touchpad version?

Hi Patrick,

On Mon, Jun 20, 2016 at 06:10:41PM +0000, Patrick Lessard wrote:
> Hello!
>
> First, thank you very much for creating a driver for the Elantech touchpads. Very appeciated.
>
> I’ve contacted one of the original author, Arjan Opmeer and he directed me to you. (those 2 email addresses actually)
>
> I just bought a HP Pavilion 14-ab057ca laptop and I think it uses a new version of the Elantech touchpad.
>
> On linux, when I boot, I get this message :
>
> « psmouse serio1: elantech: unknown hardware version, aborting... »
>
> By looking at the kernel driver code in elantech.c below, I might try a quick patch and add a case higher than 14, compile and try it.

Looking at HP site it seems that at least some batches of this laptop
are shipping with Elan touchpads.

KT, do we need to expand the list in elantech_set_properties() to
include more IC types?

>
> If succesfull, could you include a fix in the near future?
>
> Are you still maintaining this driver?
>
> How should I proceed?
>
> Thank you very much for your attention.
>
> Patrick.
>
>
> Code snippet :
>
> ….
>
> static int elantech_set_properties(struct elantech_data *etd)
> {
>         /* This represents the version of IC body. */
>         int ver = (etd->fw_version & 0x0f0000) >> 16;
>
>         /* Early version of Elan touchpads doesn't obey the rule. */
>         if (etd->fw_version < 0x020030 || etd->fw_version == 0x020600)
>                etd->hw_version = 1;
>         else {
>                switch (ver) {
>                case 2:
>                case 4:
>                        etd->hw_version = 2;
>                        break;
>                case 5:
>                        etd->hw_version = 3;
>                        break;
>                case 6:
>                case 7:
>                case 8:
>                case 9:
>                case 10:
>                case 13:
>                case 14:
>                        etd->hw_version = 4;
>                        break;
>                default:
>                        return -1;
>                }
>         }
>

Thanks.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: RE : New Elantech touchpad version?

[Patrick Lessard]

I confirm that by adding
case 12:
It works.

Patrick

> Le 20 juin 2016 à 21:38, Patrick Lessard <Patrick.Lessard@cogeco.com> a écrit :
>
> Sorry to bother, but here is some additionnal info.
>
> This is what I get from dmesg
>
> [    9.320371] psmouse serio1: elantech: assuming hardware version 4 (with firmware version 0x5c1f04)
> [    9.335504] psmouse serio1: elantech: Synaptics capabilities query result 0x10, 0x16, 0x0d.
> [    9.350483] psmouse serio1: elantech: Elan sample query result 0d, 01, 86
>
> and calculated version gives 0xC, so 12
>
> If that could help
>
> Patrick.
>
>

The information in this message, including in all attachments, is
confidential or privileged. In the event you have received this message in error
and are not the intended recipient, you are hereby advised that any use, copying
or reproduction of this document is strictly forbidden. Please notify
immediately the sender of this error and destroy this message, including its
attachments, as the case may be.
</P>
L'information apparaissant dans ce message electronique et dans les documents
qui y sont joints est de nature confidentielle ou privilegiee. Si ce message
vous est parvenu par erreur et que vous n'en etes pas le destinataire vise, vous
etes par les presentes avise que toute utilisation, copie ou distribution de ce
message est strictement interdite. Vous etes donc prie d’en informer
immediatement l’expediteur et de detruire ce message, ainsi que les documents
qui y sont joints, le cas echeant.</FONT>






Ce courriel provient de Patrick.Lessard@cogeco.com . Pour assurer la livraison de futurs envois, veuillez inclure la presente adresse courriel a votre carnet
d’adresses ou votre liste d’expediteurs autorises.
Si vous ne souhaitez plus recevoir de messages promotionnels de la part de Cogeco, veuillez transférer ce courriel a desabonnement@cogeco.com. Merci!
Politique en matiere de protection des renseignements personnels de Cogeco et Engagement en matiere d’anti-spam – Contactez-nous
Cogeco Cable Canada, 5 Place Ville-Marie, Bureau 1700, Montreal, Quebec, H3B 0B3
--
This email is from Patrick.Lessard@cogeco.com . To ensure the delivery of future emails, please add the current email address to your address book or safe senders list.
If you no longer wish to receive promotional emails from Cogeco, please forward this message to unsubscribe@cogeco.com. Thank you!
Privacy Policy and Anti-spam Commitment - Contact us
Cogeco Cable Canada, 5 Place Ville-Marie, Suite 1700, Montreal, Quebec, H3B 0B3

________________________________________
> De : Patrick Lessard
> Envoyé : 20 juin 2016 19:53
> À : Dmitry Torokhov; kt.liao@emc.com.tw
> Cc : linux-input@vger.kernel.org
> Objet : RE : New Elantech touchpad version?
>
> Hello,
>
> Just tested an ugly quick patch just for testing. By assigning it a hw_version of 4 it works fine.
>
> I'll find out what fw_version it gives and see how it translate for the ver variable
>
> You can see what I did below. I just played with the "default" statement.
>
> Thank you.
>
> Patrick.
>
> static int elantech_set_properties(struct elantech_data *etd)
> {
>        /* This represents the version of IC body. */
>        int ver = (etd->fw_version & 0x0f0000) >> 16;
>
>        /* Early version of Elan touchpads doesn't obey the rule. */
>        if (etd->fw_version < 0x020030 || etd->fw_version == 0x020600)
>                etd->hw_version = 1;
>        else {
>                switch (ver) {
>                case 2:
>                case 4:
>                        etd->hw_version = 2;
>                        break;
>                case 5:
>                        etd->hw_version = 3;
>                        break;
>                case 6:
>                case 7:
>                case 8:
>                case 9:
>                case 10:
>                case 13:
>                case 14:
>                        etd->hw_version = 4;
>                        break;
>                default:
>                        etd->hw_version = 4;
>                        break;
>                        /*return -1;*/
>
> ________________________________________
> De : Dmitry Torokhov [dmitry.torokhov@gmail.com]
> Envoyé : 20 juin 2016 14:21
> À : Patrick Lessard; kt.liao@emc.com.tw
> Cc : linux-input@vger.kernel.org
> Objet : Re: New Elantech touchpad version?
>
> Hi Patrick,
>
>> On Mon, Jun 20, 2016 at 06:10:41PM +0000, Patrick Lessard wrote:
>> Hello!
>>
>> First, thank you very much for creating a driver for the Elantech touchpads. Very appeciated.
>>
>> I’ve contacted one of the original author, Arjan Opmeer and he directed me to you. (those 2 email addresses actually)
>>
>> I just bought a HP Pavilion 14-ab057ca laptop and I think it uses a new version of the Elantech touchpad.
>>
>> On linux, when I boot, I get this message :
>>
>> « psmouse serio1: elantech: unknown hardware version, aborting... »
>>
>> By looking at the kernel driver code in elantech.c below, I might try a quick patch and add a case higher than 14, compile and try it.
>
> Looking at HP site it seems that at least some batches of this laptop
> are shipping with Elan touchpads.
>
> KT, do we need to expand the list in elantech_set_properties() to
> include more IC types?
>
>>
>> If succesfull, could you include a fix in the near future?
>>
>> Are you still maintaining this driver?
>>
>> How should I proceed?
>>
>> Thank you very much for your attention.
>>
>> Patrick.
>>
>>
>> Code snippet :
>>
>> ….
>>
>> static int elantech_set_properties(struct elantech_data *etd)
>> {
>>        /* This represents the version of IC body. */
>>        int ver = (etd->fw_version & 0x0f0000) >> 16;
>>
>>        /* Early version of Elan touchpads doesn't obey the rule. */
>>        if (etd->fw_version < 0x020030 || etd->fw_version == 0x020600)
>>               etd->hw_version = 1;
>>        else {
>>               switch (ver) {
>>               case 2:
>>               case 4:
>>                       etd->hw_version = 2;
>>                       break;
>>               case 5:
>>                       etd->hw_version = 3;
>>                       break;
>>               case 6:
>>               case 7:
>>               case 8:
>>               case 9:
>>               case 10:
>>               case 13:
>>               case 14:
>>                       etd->hw_version = 4;
>>                       break;
>>               default:
>>                       return -1;
>>               }
>>        }
>
> Thanks.
>
> --
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: RE : New Elantech touchpad version?

[廖崇榮]

Hi Patrick,

	You are right, I just check the IC body in the HP Pavilion 14-ab057ca. It's ID is 0xC.
We will upstream the patch ASAP.

		B.R  KT


-----Original Message-----
From: Patrick Lessard [mailto:Patrick.Lessard@cogeco.com] 
Sent: Tuesday, June 21, 2016 11:24 AM
To: Dmitry Torokhov; kt.liao@emc.com.tw
Cc: linux-input@vger.kernel.org
Subject: Re: RE : New Elantech touchpad version?

I confirm that by adding
case 12:
It works.

Patrick

> Le 20 juin 2016 à 21:38, Patrick Lessard <Patrick.Lessard@cogeco.com> a écrit :
>
> Sorry to bother, but here is some additionnal info.
>
> This is what I get from dmesg
>
> [    9.320371] psmouse serio1: elantech: assuming hardware version 4 (with firmware version 0x5c1f04)
> [    9.335504] psmouse serio1: elantech: Synaptics capabilities query result 0x10, 0x16, 0x0d.
> [    9.350483] psmouse serio1: elantech: Elan sample query result 0d, 01, 86
>
> and calculated version gives 0xC, so 12
>
> If that could help
>
> Patrick.
>
>

The information in this message, including in all attachments, is confidential or privileged. In the event you have received this message in error and are not the intended recipient, you are hereby advised that any use, copying or reproduction of this document is strictly forbidden. Please notify immediately the sender of this error and destroy this message, including its attachments, as the case may be.
</P>
L'information apparaissant dans ce message electronique et dans les documents qui y sont joints est de nature confidentielle ou privilegiee. Si ce message vous est parvenu par erreur et que vous n'en etes pas le destinataire vise, vous etes par les presentes avise que toute utilisation, copie ou distribution de ce message est strictement interdite. Vous etes donc prie d’en informer immediatement l’expediteur et de detruire ce message, ainsi que les documents qui y sont joints, le cas echeant.</FONT>






Ce courriel provient de Patrick.Lessard@cogeco.com . Pour assurer la livraison de futurs envois, veuillez inclure la presente adresse courriel a votre carnet d’adresses ou votre liste d’expediteurs autorises.
Si vous ne souhaitez plus recevoir de messages promotionnels de la part de Cogeco, veuillez transférer ce courriel a desabonnement@cogeco.com. Merci!
Politique en matiere de protection des renseignements personnels de Cogeco et Engagement en matiere d’anti-spam – Contactez-nous Cogeco Cable Canada, 5 Place Ville-Marie, Bureau 1700, Montreal, Quebec, H3B 0B3
--
This email is from Patrick.Lessard@cogeco.com . To ensure the delivery of future emails, please add the current email address to your address book or safe senders list.
If you no longer wish to receive promotional emails from Cogeco, please forward this message to unsubscribe@cogeco.com. Thank you!
Privacy Policy and Anti-spam Commitment - Contact us Cogeco Cable Canada, 5 Place Ville-Marie, Suite 1700, Montreal, Quebec, H3B 0B3

________________________________________
> De : Patrick Lessard
> Envoyé : 20 juin 2016 19:53
> À : Dmitry Torokhov; kt.liao@emc.com.tw Cc : 
> linux-input@vger.kernel.org Objet : RE : New Elantech touchpad 
> version?
>
> Hello,
>
> Just tested an ugly quick patch just for testing. By assigning it a hw_version of 4 it works fine.
>
> I'll find out what fw_version it gives and see how it translate for 
> the ver variable
>
> You can see what I did below. I just played with the "default" statement.
>
> Thank you.
>
> Patrick.
>
> static int elantech_set_properties(struct elantech_data *etd) {
>        /* This represents the version of IC body. */
>        int ver = (etd->fw_version & 0x0f0000) >> 16;
>
>        /* Early version of Elan touchpads doesn't obey the rule. */
>        if (etd->fw_version < 0x020030 || etd->fw_version == 0x020600)
>                etd->hw_version = 1;
>        else {
>                switch (ver) {
>                case 2:
>                case 4:
>                        etd->hw_version = 2;
>                        break;
>                case 5:
>                        etd->hw_version = 3;
>                        break;
>                case 6:
>                case 7:
>                case 8:
>                case 9:
>                case 10:
>                case 13:
>                case 14:
>                        etd->hw_version = 4;
>                        break;
>                default:
>                        etd->hw_version = 4;
>                        break;
>                        /*return -1;*/
>
> ________________________________________
> De : Dmitry Torokhov [dmitry.torokhov@gmail.com] Envoyé : 20 juin 2016 
> 14:21 À : Patrick Lessard; kt.liao@emc.com.tw Cc : 
> linux-input@vger.kernel.org Objet : Re: New Elantech touchpad version?
>
> Hi Patrick,
>
>> On Mon, Jun 20, 2016 at 06:10:41PM +0000, Patrick Lessard wrote:
>> Hello!
>>
>> First, thank you very much for creating a driver for the Elantech touchpads. Very appeciated.
>>
>> I’ve contacted one of the original author, Arjan Opmeer and he 
>> directed me to you. (those 2 email addresses actually)
>>
>> I just bought a HP Pavilion 14-ab057ca laptop and I think it uses a new version of the Elantech touchpad.
>>
>> On linux, when I boot, I get this message :
>>
>> « psmouse serio1: elantech: unknown hardware version, aborting... »
>>
>> By looking at the kernel driver code in elantech.c below, I might try a quick patch and add a case higher than 14, compile and try it.
>
> Looking at HP site it seems that at least some batches of this laptop 
> are shipping with Elan touchpads.
>
> KT, do we need to expand the list in elantech_set_properties() to 
> include more IC types?
>
>>
>> If succesfull, could you include a fix in the near future?
>>
>> Are you still maintaining this driver?
>>
>> How should I proceed?
>>
>> Thank you very much for your attention.
>>
>> Patrick.
>>
>>
>> Code snippet :
>>
>> ….
>>
>> static int elantech_set_properties(struct elantech_data *etd) {
>>        /* This represents the version of IC body. */
>>        int ver = (etd->fw_version & 0x0f0000) >> 16;
>>
>>        /* Early version of Elan touchpads doesn't obey the rule. */
>>        if (etd->fw_version < 0x020030 || etd->fw_version == 0x020600)
>>               etd->hw_version = 1;
>>        else {
>>               switch (ver) {
>>               case 2:
>>               case 4:
>>                       etd->hw_version = 2;
>>                       break;
>>               case 5:
>>                       etd->hw_version = 3;
>>                       break;
>>               case 6:
>>               case 7:
>>               case 8:
>>               case 9:
>>               case 10:
>>               case 13:
>>               case 14:
>>                       etd->hw_version = 4;
>>                       break;
>>               default:
>>                       return -1;
>>               }
>>        }
>
> Thanks.
>
> --
> Dmitry


--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: RE : New Elantech touchpad version?

[Patrick Lessard]

Great news!

Thank you very much.

Patrick.



The information in this message, including in all attachments, is
confidential or privileged. In the event you have received this message in error
and are not the intended recipient, you are hereby advised that any use, copying
or reproduction of this document is strictly forbidden. Please notify
immediately the sender of this error and destroy this message, including its
attachments, as the case may be.
</P>
L'information apparaissant dans ce message electronique et dans les documents
qui y sont joints est de nature confidentielle ou privilegiee. Si ce message
vous est parvenu par erreur et que vous n'en etes pas le destinataire vise, vous
etes par les presentes avise que toute utilisation, copie ou distribution de ce
message est strictement interdite. Vous etes donc prie d’en informer
immediatement l’expediteur et de detruire ce message, ainsi que les documents
qui y sont joints, le cas echeant.</FONT>






Ce courriel provient de Patrick.Lessard@cogeco.com . Pour assurer la livraison de futurs envois, veuillez inclure la presente adresse courriel a votre carnet
d’adresses ou votre liste d’expediteurs autorises.
Si vous ne souhaitez plus recevoir de messages promotionnels de la part de Cogeco, veuillez transférer ce courriel a desabonnement@cogeco.com. Merci!
Politique en matiere de protection des renseignements personnels de Cogeco et Engagement en matiere d’anti-spam – Contactez-nous
Cogeco Cable Canada, 5 Place Ville-Marie, Bureau 1700, Montreal, Quebec, H3B 0B3
--
This email is from Patrick.Lessard@cogeco.com . To ensure the delivery of future emails, please add the current email address to your address book or safe senders list.
If you no longer wish to receive promotional emails from Cogeco, please forward this message to unsubscribe@cogeco.com. Thank you!
Privacy Policy and Anti-spam Commitment - Contact us
Cogeco Cable Canada, 5 Place Ville-Marie, Suite 1700, Montreal, Quebec, H3B 0B3

-----Message d'origine-----
De : 廖崇榮 [mailto:kt.liao@emc.com.tw]
Envoyé : 21 juin 2016 08:01
À : Patrick Lessard; 'Dmitry Torokhov'
Cc : linux-input@vger.kernel.org
Objet : RE: RE : New Elantech touchpad version?

Hi Patrick,

        You are right, I just check the IC body in the HP Pavilion 14-ab057ca. It's ID is 0xC.
We will upstream the patch ASAP.

                B.R  KT


-----Original Message-----
From: Patrick Lessard [mailto:Patrick.Lessard@cogeco.com]
Sent: Tuesday, June 21, 2016 11:24 AM
To: Dmitry Torokhov; kt.liao@emc.com.tw
Cc: linux-input@vger.kernel.org
Subject: Re: RE : New Elantech touchpad version?

I confirm that by adding
case 12:
It works.

Patrick

> Le 20 juin 2016 à 21:38, Patrick Lessard <Patrick.Lessard@cogeco.com> a écrit :
>
> Sorry to bother, but here is some additionnal info.
>
> This is what I get from dmesg
>
> [    9.320371] psmouse serio1: elantech: assuming hardware version 4 (with firmware version 0x5c1f04)
> [    9.335504] psmouse serio1: elantech: Synaptics capabilities query result 0x10, 0x16, 0x0d.
> [    9.350483] psmouse serio1: elantech: Elan sample query result 0d, 01, 86
>
> and calculated version gives 0xC, so 12
>
> If that could help
>
> Patrick.
>
>

The information in this message, including in all attachments, is confidential or privileged. In the event you have received this message in error and are not the intended recipient, you are hereby advised that any use, copying or reproduction of this document is strictly forbidden. Please notify immediately the sender of this error and destroy this message, including its attachments, as the case may be.
</P>
L'information apparaissant dans ce message electronique et dans les documents qui y sont joints est de nature confidentielle ou privilegiee. Si ce message vous est parvenu par erreur et que vous n'en etes pas le destinataire vise, vous etes par les presentes avise que toute utilisation, copie ou distribution de ce message est strictement interdite. Vous etes donc prie d’en informer immediatement l’expediteur et de detruire ce message, ainsi que les documents qui y sont joints, le cas echeant.</FONT>






Ce courriel provient de Patrick.Lessard@cogeco.com . Pour assurer la livraison de futurs envois, veuillez inclure la presente adresse courriel a votre carnet d’adresses ou votre liste d’expediteurs autorises.
Si vous ne souhaitez plus recevoir de messages promotionnels de la part de Cogeco, veuillez transférer ce courriel a desabonnement@cogeco.com. Merci!
Politique en matiere de protection des renseignements personnels de Cogeco et Engagement en matiere d’anti-spam – Contactez-nous Cogeco Cable Canada, 5 Place Ville-Marie, Bureau 1700, Montreal, Quebec, H3B 0B3
--
This email is from Patrick.Lessard@cogeco.com . To ensure the delivery of future emails, please add the current email address to your address book or safe senders list.
If you no longer wish to receive promotional emails from Cogeco, please forward this message to unsubscribe@cogeco.com. Thank you!
Privacy Policy and Anti-spam Commitment - Contact us Cogeco Cable Canada, 5 Place Ville-Marie, Suite 1700, Montreal, Quebec, H3B 0B3

________________________________________
> De : Patrick Lessard
> Envoyé : 20 juin 2016 19:53
> À : Dmitry Torokhov; kt.liao@emc.com.tw Cc :
> linux-input@vger.kernel.org Objet : RE : New Elantech touchpad
> version?
>
> Hello,
>
> Just tested an ugly quick patch just for testing. By assigning it a hw_version of 4 it works fine.
>
> I'll find out what fw_version it gives and see how it translate for
> the ver variable
>
> You can see what I did below. I just played with the "default" statement.
>
> Thank you.
>
> Patrick.
>
> static int elantech_set_properties(struct elantech_data *etd) {
>        /* This represents the version of IC body. */
>        int ver = (etd->fw_version & 0x0f0000) >> 16;
>
>        /* Early version of Elan touchpads doesn't obey the rule. */
>        if (etd->fw_version < 0x020030 || etd->fw_version == 0x020600)
>                etd->hw_version = 1;
>        else {
>                switch (ver) {
>                case 2:
>                case 4:
>                        etd->hw_version = 2;
>                        break;
>                case 5:
>                        etd->hw_version = 3;
>                        break;
>                case 6:
>                case 7:
>                case 8:
>                case 9:
>                case 10:
>                case 13:
>                case 14:
>                        etd->hw_version = 4;
>                        break;
>                default:
>                        etd->hw_version = 4;
>                        break;
>                        /*return -1;*/
>
> ________________________________________
> De : Dmitry Torokhov [dmitry.torokhov@gmail.com] Envoyé : 20 juin 2016
> 14:21 À : Patrick Lessard; kt.liao@emc.com.tw Cc :
> linux-input@vger.kernel.org Objet : Re: New Elantech touchpad version?
>
> Hi Patrick,
>
>> On Mon, Jun 20, 2016 at 06:10:41PM +0000, Patrick Lessard wrote:
>> Hello!
>>
>> First, thank you very much for creating a driver for the Elantech touchpads. Very appeciated.
>>
>> I’ve contacted one of the original author, Arjan Opmeer and he
>> directed me to you. (those 2 email addresses actually)
>>
>> I just bought a HP Pavilion 14-ab057ca laptop and I think it uses a new version of the Elantech touchpad.
>>
>> On linux, when I boot, I get this message :
>>
>> « psmouse serio1: elantech: unknown hardware version, aborting... »
>>
>> By looking at the kernel driver code in elantech.c below, I might try a quick patch and add a case higher than 14, compile and try it.
>
> Looking at HP site it seems that at least some batches of this laptop
> are shipping with Elan touchpads.
>
> KT, do we need to expand the list in elantech_set_properties() to
> include more IC types?
>
>>
>> If succesfull, could you include a fix in the near future?
>>
>> Are you still maintaining this driver?
>>
>> How should I proceed?
>>
>> Thank you very much for your attention.
>>
>> Patrick.
>>
>>
>> Code snippet :
>>
>> ….
>>
>> static int elantech_set_properties(struct elantech_data *etd) {
>>        /* This represents the version of IC body. */
>>        int ver = (etd->fw_version & 0x0f0000) >> 16;
>>
>>        /* Early version of Elan touchpads doesn't obey the rule. */
>>        if (etd->fw_version < 0x020030 || etd->fw_version == 0x020600)
>>               etd->hw_version = 1;
>>        else {
>>               switch (ver) {
>>               case 2:
>>               case 4:
>>                       etd->hw_version = 2;
>>                       break;
>>               case 5:
>>                       etd->hw_version = 3;
>>                       break;
>>               case 6:
>>               case 7:
>>               case 8:
>>               case 9:
>>               case 10:
>>               case 13:
>>               case 14:
>>                       etd->hw_version = 4;
>>                       break;
>>               default:
>>                       return -1;
>>               }
>>        }
>
> Thanks.
>
> --
> Dmitry

RE: New Elantech touchpad version?

[廖崇榮]

Hi Dmitry,
I add comment for it.
-----Original Message-----
From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com] 
Sent: Tuesday, June 21, 2016 2:21 AM
To: Patrick Lessard; kt.liao@emc.com.tw
Cc: linux-input@vger.kernel.org
Subject: Re: New Elantech touchpad version?

Hi Patrick,

On Mon, Jun 20, 2016 at 06:10:41PM +0000, Patrick Lessard wrote:
> Hello!
> 
> First, thank you very much for creating a driver for the Elantech touchpads. Very appeciated.
> 
> I’ve contacted one of the original author, Arjan Opmeer and he 
> directed me to you. (those 2 email addresses actually)
> 
> I just bought a HP Pavilion 14-ab057ca laptop and I think it uses a new version of the Elantech touchpad.
> 
> On linux, when I boot, I get this message :
> 
> « psmouse serio1: elantech: unknown hardware version, aborting... »
> 
> By looking at the kernel driver code in elantech.c below, I might try a quick patch and add a case higher than 14, compile and try it.

Looking at HP site it seems that at least some batches of this laptop are shipping with Elan touchpads.

KT, do we need to expand the list in elantech_set_properties() to include more IC types?
[KT]:I have checked our touchpad IC list, we should add "case 11" and "case 12" in the version switch case . and their hw_versoin is 4.
    Do I need to upstream or you will modify it directly?
> 
> If succesfull, could you include a fix in the near future?
> 
> Are you still maintaining this driver?
> 
> How should I proceed?
> 
> Thank you very much for your attention.
> 
> Patrick.
> 
> 
> Code snippet :
> 
> ….
> 
> static int elantech_set_properties(struct elantech_data *etd) {
>         /* This represents the version of IC body. */
>         int ver = (etd->fw_version & 0x0f0000) >> 16;
> 
>         /* Early version of Elan touchpads doesn't obey the rule. */
>         if (etd->fw_version < 0x020030 || etd->fw_version == 0x020600)
>                etd->hw_version = 1;
>         else {
>                switch (ver) {
>                case 2:
>                case 4:
>                        etd->hw_version = 2;
>                        break;
>                case 5:
>                        etd->hw_version = 3;
>                        break;
>                case 6:
>                case 7:
>                case 8:
>                case 9:
>                case 10:
>                case 13:
>                case 14:
>                        etd->hw_version = 4;
>                        break;
>                default:
>                        return -1;
>                }
>         }
> 

Thanks.

--
Dmitry

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html