From: Jingoo Han <jg1.han@samsung.com>
To: 'Sebastian Reichel' <sre@debian.org>
Cc: 'Dmitry Torokhov' <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, 'Fugang Duan' <B38611@freescale.com>,
'Peter Ujfalusi' <peter.ujfalusi@ti.com>,
".linux-kernel"@vger.kernel.org,
'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH] Input: twl4030 - convert to using managed resources
Date: Mon, 06 Jan 2014 11:50:46 +0900 [thread overview]
Message-ID: <009301cf0a8a$1963cfd0$4c2b6f70$%han@samsung.com> (raw)
In-Reply-To: <20140106023358.GA11575@earth.universe>
On Monday, January 06, 2014 11:34 AM, Sebastian Reichel wrote:
> On Mon, Jan 06, 2014 at 11:25:54AM +0900, Jingoo Han wrote:
> > IMHO, input_unregister_device() seems to be necessary,
> > because input_register_device() is still used.
> > If I am wrong, please let me know kindly.
> >
> > Sebastian Reichel,
> > Would you repeat insmod & rmmod 'twl4030_keypad.ko'?
>
> mh. I only tested with twl4030-keypad compiled into the kernel.
> I will try building the driver as module and reloading it on
> the device when I find some time.
OK, I see. :-)
If you repeat at least twice insmod & rmmod 'twl4030_keypad.ko',
it will be good. If there are some bugs, it will make the error
messages or kernel panic.
In my case, Samsung Exynos SPI driver made kernel panic when
Repeating insmod & rmmod twice, after the patch to covert to
devm_* functions was applied. This was because there was a bug
of devm_spi_register_master().
Thank you.
Best regards,
Jingoo Han
next prev parent reply other threads:[~2014-01-06 2:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140104090147.GA16680@core.coreip.homeip.net>
2014-01-05 3:47 ` [PATCH] Input: twl4030 - convert to using managed resources Sebastian Reichel
2014-01-06 2:25 ` Jingoo Han
2014-01-06 2:33 ` 'Sebastian Reichel'
2014-01-06 2:50 ` Jingoo Han [this message]
2014-01-06 22:14 ` 'Sebastian Reichel'
2014-01-07 0:38 ` Jingoo Han
[not found] ` <20140106180705.GB2754@core.coreip.homeip.net>
2014-01-07 0:35 ` Jingoo Han
2014-01-07 0:39 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009301cf0a8a$1963cfd0$4c2b6f70$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=".linux-kernel"@vger.kernel.org \
--cc=B38611@freescale.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=sre@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).