From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BF42C433E0 for ; Mon, 8 Mar 2021 16:01:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5814A651A0 for ; Mon, 8 Mar 2021 16:01:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230165AbhCHQA4 (ORCPT ); Mon, 8 Mar 2021 11:00:56 -0500 Received: from mga07.intel.com ([134.134.136.100]:20160 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230148AbhCHQAs (ORCPT ); Mon, 8 Mar 2021 11:00:48 -0500 IronPort-SDR: qGAn2jkSazw168RkMm0T9BZb9nvVxoDZtLKzoTAi1+duqCYyWBhOn5cjAHh0R6fIO6lWC8BaiL mp9sR3r+s6oQ== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="252081110" X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="252081110" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 08:00:43 -0800 IronPort-SDR: B1b74B1yMTqj5Dr9tfyahDvUZ/aOJ8ccU+6DLUh9DF44qFfPJ32yU3L4nggjd+ZOlDxLl1z4vw OQeEo+8PkVsA== X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="408271207" Received: from arohrbax-mobl.amr.corp.intel.com ([10.209.91.130]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 08:00:43 -0800 Message-ID: <00ad0906b90a290e9737b7bf7d8c5ab9c6ed61e6.camel@linux.intel.com> Subject: Re: [PATCH] HID: intel_ish-hid: HBM: Use connected standby state bit during suspend/resume From: Srinivas Pandruvada To: Jiri Kosina , Ye Xiang Cc: jic23@kernel.org, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 08 Mar 2021 08:00:41 -0800 In-Reply-To: References: <20210303062825.7724-1-xiang.ye@intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, 2021-03-08 at 11:26 +0100, Jiri Kosina wrote: > On Wed, 3 Mar 2021, Ye Xiang wrote: > > > ISH firmware uses connected standby state bit > > (CONNECTED_STANDBY_STATE_BIT bit 1) > > to notify current power state to sensors instead of suspend state > > bit (bit 0). > > So send both SUSPEND_STATE_BIT and CONNECTED_STANDBY_STATE_BIT to > > firmware > > to be compatible with the previous version. > > Could you please make the changelog more verbose -- namely what > user-visible issue this is fixing? Xiang, I think this change is for related to Elkhart Lake for support of connected standby (keep listening for sensor events during Linux suspend for some sensors). In this way some sensor can wake up the system. Thanks, Srinivas > > Thanks. >