[PATCH 01/03] [INPUT][KEYBOARD] Kconfig support for s3c matrix keypad

[PATCH 01/03] [INPUT][KEYBOARD] Kconfig support for s3c matrix keypad

[양진성]

This patch supports to select configuration for s3c matrix keypad.

Signed-off-by: Jinsung Yang <jsgood.yang@samsung.com>
Signed-off-by: Kyeongil Kim <ki0351.kim@samsung.com>
---
 drivers/input/keyboard/Kconfig |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index a6b989a..4a04553 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -361,4 +361,10 @@ config KEYBOARD_XTKBD
 	  To compile this driver as a module, choose M here: the
 	  module will be called xtkbd.
 
+config KEYBOARD_S3C
+	tristate "Samsung S3C keypad support"
+	depends on PLAT_S3C
+	help
+	  Enable support for Samsung S3C keypad interface.
+
 endif
-- 
1.6.2.5

Re: [PATCH 01/03] [INPUT][KEYBOARD] Kconfig support for s3c matrix keypad

[Mark Brown]

On Sat, Sep 05, 2009 at 10:54:44PM +0900, 양진성 wrote:
> This patch supports to select configuration for s3c matrix keypad.

> Signed-off-by: Jinsung Yang <jsgood.yang@samsung.com>
> Signed-off-by: Kyeongil Kim <ki0351.kim@samsung.com>

A relatively technical point but you should always try to order your
patch series so that the kernel always builds, even with the patch
series partly applied.  This means that if you've split out the build
system changes that should be the last patch in the series.

Doing this is useful when people use tools such as 'git bisect' which
walk through history and also means that it's possible to do things like
partially apply the series (for example, if you get a situation where
the earlier patches are all OK but there's some issues that need to be
resolved in the later ones).

It'd probably also help to combine more of your changes together - in
general it's better if patches achieve some goal in a self-contained
fashion.  This normally makes things easier to review.  Things like
doing the build system separately are normally there in order to split a
very large driver into managable chunks.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html