From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Eric Miao' <eric.y.miao@gmail.com>,
'Joonyoung Shim' <jy0922.shim@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, dmitry.torokhov@gmail.com,
kyungmin.park@samsung.com, ben-linux@fluff.org,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH v5 1/3] ARM: SAMSUNG: Add keypad device support
Date: Tue, 22 Jun 2010 09:18:35 +0900 [thread overview]
Message-ID: <00fb01cb11a0$76cfa3b0$646eeb10$%kim@samsung.com> (raw)
In-Reply-To: <AANLkTimhik3BOQNzybs1tUuHUXri-yxm5v7wH1JjQ5B1@mail.gmail.com>
Eric Miao wrote:
>
> >> and now in s5pc200 code, you can also register/re-use the s5pc100_keypad
> >> device/driver, and everyone knows - OK, the IP on S5PC100 is now re-used
> >> here.
> >>
> >
> > This is naming issue and i know it was not desided yet.
> > This keypad driver can support s3c64xx, s5pc100, s5pc110, s5pv210.
> >
>
> I bet the first silicon this IP is deployed is s3c64xx, so my understanding
> 's3c64xx-keypad.c' should be an acceptable name. And it's also reasonable,
> a s3c64xx-keypad driver, and is later expanded to support subsequent silicons
> without the file name being changed.
Hi,
Seems to be more suitable 'samsung-keypad', because can support S5PC100, S5PC110, and S5PV210 as well as S3C64XX.
Already tested on SMDK6410(S3C6410), SMDKC100(S5PC100), Aquila(S5PC110), GONI(S5PC110) and SMDKV210(S5PV210) boards.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
prev parent reply other threads:[~2010-06-22 0:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 6:26 [PATCH v5 1/3] ARM: SAMSUNG: Add keypad device support Joonyoung Shim
2010-06-21 6:26 ` [PATCH v5 2/3] ARM: S5PV210: Add keypad device helpers Joonyoung Shim
2010-06-21 6:26 ` [PATCH v5 3/3] input: samsung-keypad - Add samsung keypad driver Joonyoung Shim
2010-06-25 8:30 ` Dmitry Torokhov
2010-06-25 10:25 ` Joonyoung Shim
2010-06-25 10:39 ` Joonyoung Shim
2010-06-28 8:39 ` Joonyoung Shim
2010-06-28 9:01 ` Dmitry Torokhov
2010-06-21 9:05 ` [PATCH v5 1/3] ARM: SAMSUNG: Add keypad device support Eric Miao
2010-06-21 9:19 ` Russell King - ARM Linux
2010-06-21 10:39 ` Eric Miao
2010-06-21 11:16 ` Russell King - ARM Linux
2010-06-21 14:15 ` Eric Miao
2010-06-22 0:48 ` Joonyoung Shim
2010-06-22 3:02 ` Eric Miao
2010-06-22 3:27 ` Joonyoung Shim
2010-06-22 3:38 ` Eric Miao
2010-06-22 4:00 ` Joonyoung Shim
2010-06-22 7:15 ` Eric Miao
2010-06-22 7:33 ` Joonyoung Shim
2010-06-21 9:29 ` Marek Szyprowski
2010-06-21 10:43 ` Eric Miao
2010-06-21 11:21 ` Joonyoung Shim
2010-06-21 14:19 ` Eric Miao
2010-06-22 0:18 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00fb01cb11a0$76cfa3b0$646eeb10$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=ben-linux@fluff.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).