From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: RE: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver Date: Wed, 07 Jul 2010 08:52:59 +0900 Message-ID: <013401cb1d66$5fbf3fb0$1f3dbf10$%kim@samsung.com> References: <1277724824-13308-1-git-send-email-jy0922.shim@samsung.com> <1277724824-13308-3-git-send-email-jy0922.shim@samsung.com> <4C32E21A.8080100@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7BIT Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:56950 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753039Ab0GFXw4 (ORCPT ); Tue, 6 Jul 2010 19:52:56 -0400 In-reply-to: <4C32E21A.8080100@samsung.com> Content-language: ko Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: 'Joonyoung Shim' , ch.naveen@samsung.com Cc: linux-arm-kernel@lists.infradead.org, dmitry.torokhov@gmail.com, kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org, linux-input@vger.kernel.org Joonyoung Shim wrote: > > Hi, Naveen. > > On 6/28/2010 8:33 PM, Joonyoung Shim wrote: > > This patch adds support for keypad driver running on Samsung cpus. This > > driver is tested on GONI and Aquila board using S5PC110 cpu. > > > > Signed-off-by: Joonyoung Shim > > Signed-off-by: Kyungmin Park > > --- > > drivers/input/keyboard/Kconfig | 9 + > > drivers/input/keyboard/Makefile | 1 + > > drivers/input/keyboard/samsung-keypad.c | 491 > +++++++++++++++++++++++++++++++ > > 3 files changed, 501 insertions(+), 0 deletions(-) > > create mode 100644 drivers/input/keyboard/samsung-keypad.c > > > > Could you please test this v6 keypad driver on your various targets? Hi, I received the test result from Naveen. And now he is debugging about that. ..his e-mail client has some problem..so I replied... --- From: Naveen Ch I've tested with v6 patches and they are working fine on SMDK6410, SMDKC100 and SMDKV210, except for some header inclusion (linux/sched.h) in samsung-keypad.c. The build breaking error is like following: (make s5pc100_defconfig and select input->keypad->samsung keypad) drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq': drivers/input/keyboard/samsung-keypad.c:170: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared identifier is reported only once drivers/input/keyboard/samsung-keypad.c:170: error: for each function it appears in.) drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of function 'schedule_timeout' drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_stop': drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL' undeclared (first use in this function) make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1 --- Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.