From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Fenglin Wu <quic_fenglinw@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
agross@kernel.org, andersson@kernel.org,
dmitry.baryshkov@linaro.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Cc: quic_collinsd@quicinc.com, quic_subbaram@quicinc.com,
quic_kamalw@quicinc.com, jestar@qti.qualcomm.com
Subject: Re: [PATCH v3 2/3] dt-bindings: input: qcom,pm8xxx-vib: add new SPMI vibrator module
Date: Thu, 27 Jul 2023 09:09:19 +0200 [thread overview]
Message-ID: <0185a53f-b3c4-6ec7-95ae-e74f0998d6c6@linaro.org> (raw)
In-Reply-To: <3aaccc94-59b3-31d3-eac7-f8926f8c88ff@quicinc.com>
On 25/07/2023 08:26, Fenglin Wu wrote:
>
>
> On 7/25/2023 1:53 PM, Krzysztof Kozlowski wrote:
>> On 25/07/2023 07:41, Fenglin Wu wrote:
>>> Add compatible string 'qcom,spmi-vib-gen2' for vibrator module inside
>>> PMI632, PMI7250B, PM7325B, PM7550BA. Also, add 'qcom,spmi-vib-gen1'
>>> string for the SPMI vibrator inside PM8916 to maintain the completeness
>>> of the hardware version history for SPMI vibrators.
>>>
>>> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>
>>> ---
>>> .../bindings/input/qcom,pm8xxx-vib.yaml | 18 ++++++++++++++----
>>> 1 file changed, 14 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
>>> index c8832cd0d7da..ab778714ad29 100644
>>> --- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
>>> +++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
>>> @@ -11,10 +11,20 @@ maintainers:
>>>
>>> properties:
>>> compatible:
>>> - enum:
>>> - - qcom,pm8058-vib
>>> - - qcom,pm8916-vib
>>> - - qcom,pm8921-vib
>>> + oneOf:
>>> + - enum:
>>> + - qcom,pm8058-vib
>>> + - qcom,pm8916-vib
>>> + - qcom,pm8921-vib
>>> + - qcom,spmi-vib-gen1
>>> + - qcom,spmi-vib-gen2
>>
>> Generic compatibles should not be alone. Drop both lines.
>
> Sure. I will remove 'qcom,spmi-vib-gen2'.
> Should I also keep 'qcom,spmi-vib-gen1' as generic compatible and move
> 'qcom,pm8916-vib' as its fallback as following?
I would drop all of generic ones. Entirely remove qcom,spmi-vib-gen2 and
qcom,spmi-vib-gen1.
Use device specific compatibles names only. As fallback and as first
compatible.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-27 7:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230725054138.129497-1-quic_fenglinw@quicinc.com>
2023-07-25 5:41 ` [PATCH v3 1/3] input: pm8xxx-vib: refactor to easily support new SPMI vibrator Fenglin Wu
2023-07-25 5:52 ` Krzysztof Kozlowski
2023-07-25 6:16 ` Fenglin Wu
2023-07-27 7:07 ` Krzysztof Kozlowski
2023-07-27 7:43 ` Fenglin Wu
2023-07-27 9:22 ` Krzysztof Kozlowski
2023-07-27 9:40 ` Fenglin Wu
2023-07-25 10:01 ` kernel test robot
2023-07-27 7:07 ` Krzysztof Kozlowski
2023-07-25 5:41 ` [PATCH v3 2/3] dt-bindings: input: qcom,pm8xxx-vib: add new SPMI vibrator module Fenglin Wu
2023-07-25 5:53 ` Krzysztof Kozlowski
2023-07-25 6:26 ` Fenglin Wu
2023-07-27 7:09 ` Krzysztof Kozlowski [this message]
2023-07-25 5:41 ` [PATCH v3 3/3] input: pm8xxx-vibrator: add new SPMI vibrator support Fenglin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0185a53f-b3c4-6ec7-95ae-e74f0998d6c6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jestar@qti.qualcomm.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_collinsd@quicinc.com \
--cc=quic_fenglinw@quicinc.com \
--cc=quic_kamalw@quicinc.com \
--cc=quic_subbaram@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).