From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Geliang Tang <geliangtang@gmail.com>,
Kees Cook <keescook@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/2] Input: turbografx: Delete an error message for a failed memory allocation in tgfx_attach()
Date: Sat, 27 Jan 2018 15:59:18 +0100 [thread overview]
Message-ID: <0255c4a7-fff6-f427-e8a1-951b44ef3f54@users.sourceforge.net> (raw)
In-Reply-To: <dfa75f58-43e5-dc80-a606-2914b980f6e7@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 27 Jan 2018 15:43:38 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/input/joystick/turbografx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/joystick/turbografx.c b/drivers/input/joystick/turbografx.c
index e2685753e460..454d4c032292 100644
--- a/drivers/input/joystick/turbografx.c
+++ b/drivers/input/joystick/turbografx.c
@@ -192,10 +192,8 @@ static void tgfx_attach(struct parport *pp)
}
tgfx = kzalloc(sizeof(struct tgfx), GFP_KERNEL);
- if (!tgfx) {
- printk(KERN_ERR "turbografx.c: Not enough memory\n");
+ if (!tgfx)
goto err_unreg_pardev;
- }
mutex_init(&tgfx->sem);
tgfx->pd = pd;
--
2.16.1
next prev parent reply other threads:[~2018-01-27 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 14:58 [PATCH 0/2] Input-TurboGraFX: Adjustments for tgfx_attach() SF Markus Elfring
2018-01-27 14:59 ` SF Markus Elfring [this message]
2018-01-27 15:00 ` [PATCH 2/2] Input: turbografx: Improve a size determination in tgfx_attach() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0255c4a7-fff6-f427-e8a1-951b44ef3f54@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=dmitry.torokhov@gmail.com \
--cc=geliangtang@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).