Linux Input/HID development
 help / color / mirror / Atom feed
From: Alan Maguire <alan.maguire@oracle.com>
To: Ihor Solodrai <ihor.solodrai@linux.dev>,
	Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Eduard Zingerman <eddyz87@gmail.com>,
	Kumar Kartikeya Dwivedi <memxor@gmail.com>
Cc: Benjamin Tissoires <bentiss@kernel.org>,
	Jiri Kosina <jikos@kernel.org>,
	Emil Tsalapatis <emil@etsalapatis.com>,
	Jiri Olsa <jolsa@kernel.org>,
	bpf@vger.kernel.org, linux-input@vger.kernel.org,
	kernel-team@meta.com
Subject: Re: [PATCH bpf-next v1 0/8] resolve_btfids: Discover kfuncs from BTF ID sets
Date: Thu, 30 Jul 2026 13:38:46 +0100	[thread overview]
Message-ID: <029f3952-5dc5-48cf-b012-6bad8c2fcbe3@oracle.com> (raw)
In-Reply-To: <20260722233518.778854-1-ihor.solodrai@linux.dev>

On 23/07/2026 00:35, Ihor Solodrai wrote:
> This series develops resolve_btfids in preparation for bringing
> kernel-specific BTF transformations in tree, which will reduce kbuild
> dependency on pahole's features.
> 
> resolve_btfids currently identifies kfuncs by reading the "bpf_kfunc"
> decl tags pahole emits into vmlinux BTF. The series switches the
> source of truth to the BTF ID sets registered with
> BTF_KFUNCS_START()/END() in the kernel, which is the mechanism BPF
> verifier uses.
> 
> The series is based on patches #5 and #6 from the original
> "resolve_btfids: Implement BTF tags emission for kfuncs" series [1],
> and includes a few significant additions. Particularly the build time
> enforcement of kfunc flags consistency [2].
> 
> The series consists of:
>   - patches #1-#3 implement supporting infrastructure for the proper
>     kfunc discovery and deduplication
>   - patches #4-#5 expose btf__find_by_name_kind_own() and use it to
>     fix a latent bug in _impl func lookup
>   - patch #6 fixes inconsistent kfunc flags for HID kfuncs
>   - patch #7 implements kfunc discovery from BTF ID sets
>   - patch #8 adds enforcement of kfunc flags consistency
> 
> The resolve_btfids selftests patches have landed earlier [3].

I tested these changes and all looks good, so feel free to add

Tested-by: Alan Maguire <alan.maguire@oracle.com>

to the series.

> 
> [1] https://lore.kernel.org/bpf/20260601221805.821394-1-ihor.solodrai@linux.dev/
> [2] https://lore.kernel.org/bpf/9b2196dd-443b-4632-ae11-030cdbdc59b4@linux.dev/
> [3] https://lore.kernel.org/bpf/20260617210619.1562858-1-ihor.solodrai@linux.dev/
> 
> ---
> 
> Changes compared to [1]:
>   - Drop the idempotency (ensure_*) machinery: assume valid input BTF (Andrii)
>   - Use rbtree to store the kfuncs (Andrii)
>   - Enforce full KF_* flag consistency as a build error (Eduard)
>   - Various cleanups and nits (Andrii, Emil, Jiri)
> 
> ---
> 
> Ihor Solodrai (8):
>   resolve_btfids: Implement generic ensure_mem() to grow arrays
>   resolve_btfids: Index BTF ID symbols by address
>   resolve_btfids: Keep collected kfuncs in a rbtree
>   libbpf: Export btf__find_by_name_kind_own()
>   resolve_btfids: Fix the _impl lookup for module BTF
>   HID: bpf: Make syscall kfunc flags match the struct_ops set
>   resolve_btfids: Discover kfuncs from BTF ID sets
>   resolve_btfids: Enforce consistent kfunc flags across BTF ID sets
> 
>  drivers/hid/bpf/hid_bpf_dispatch.c |  10 +-
>  tools/bpf/resolve_btfids/main.c    | 275 ++++++++++++++++++-----------
>  tools/lib/bpf/btf.h                |   2 +
>  tools/lib/bpf/libbpf.map           |   1 +
>  tools/lib/bpf/libbpf_internal.h    |   2 -
>  5 files changed, 181 insertions(+), 109 deletions(-)
> 


  parent reply	other threads:[~2026-07-30 12:39 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 23:35 [PATCH bpf-next v1 0/8] resolve_btfids: Discover kfuncs from BTF ID sets Ihor Solodrai
2026-07-22 23:35 ` [PATCH bpf-next v1 1/8] resolve_btfids: Implement generic ensure_mem() to grow arrays Ihor Solodrai
2026-07-22 23:48   ` sashiko-bot
2026-07-23  0:50     ` Ihor Solodrai
2026-07-28 23:28   ` Eduard Zingerman
2026-07-22 23:35 ` [PATCH bpf-next v1 2/8] resolve_btfids: Index BTF ID symbols by address Ihor Solodrai
2026-07-29  0:21   ` Eduard Zingerman
2026-07-22 23:35 ` [PATCH bpf-next v1 3/8] resolve_btfids: Keep collected kfuncs in a rbtree Ihor Solodrai
2026-07-22 23:50   ` sashiko-bot
2026-07-23  0:51     ` Ihor Solodrai
2026-07-29  0:49   ` Eduard Zingerman
2026-07-22 23:35 ` [PATCH bpf-next v1 4/8] libbpf: Export btf__find_by_name_kind_own() Ihor Solodrai
2026-07-22 23:43   ` sashiko-bot
2026-07-23  0:45     ` Ihor Solodrai
2026-07-29  0:54   ` Eduard Zingerman
2026-07-22 23:35 ` [PATCH bpf-next v1 5/8] resolve_btfids: Fix the _impl lookup for module BTF Ihor Solodrai
2026-07-23  0:46   ` bot+bpf-ci
2026-07-29  0:55   ` Eduard Zingerman
2026-07-22 23:35 ` [PATCH bpf-next v1 6/8] HID: bpf: Make syscall kfunc flags match the struct_ops set Ihor Solodrai
2026-07-22 23:49   ` sashiko-bot
2026-07-23  0:52     ` Ihor Solodrai
2026-07-29  0:58   ` Eduard Zingerman
2026-07-22 23:35 ` [PATCH bpf-next v1 7/8] resolve_btfids: Discover kfuncs from BTF ID sets Ihor Solodrai
2026-07-23  0:32   ` bot+bpf-ci
2026-07-23  0:57     ` Ihor Solodrai
2026-07-29  1:39   ` Eduard Zingerman
2026-07-22 23:35 ` [PATCH bpf-next v1 8/8] resolve_btfids: Enforce consistent kfunc flags across " Ihor Solodrai
2026-07-23  0:32   ` bot+bpf-ci
2026-07-29  1:40   ` Eduard Zingerman
2026-07-30 12:38 ` Alan Maguire [this message]
2026-07-30 19:50 ` [PATCH bpf-next v1 0/8] resolve_btfids: Discover kfuncs from " patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=029f3952-5dc5-48cf-b012-6bad8c2fcbe3@oracle.com \
    --to=alan.maguire@oracle.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bentiss@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=jikos@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=linux-input@vger.kernel.org \
    --cc=memxor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox