From: Krzysztof Kozlowski <krzk@kernel.org>
To: Oleh Kuzhylnyi <kuzhylol@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, igor.opaniuk@gmail.com,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH 1/2] dt-bindings: input: touchscreen: add Hynitron CST816X
Date: Tue, 13 Aug 2024 11:15:03 +0200 [thread overview]
Message-ID: <02baff7e-845d-4f49-b2ce-ee06934786ab@kernel.org> (raw)
In-Reply-To: <20240813-b4-cst816s-b4-v1-1-78a03cbef328@gmail.com>
On 13/08/2024 01:22, Oleh Kuzhylnyi wrote:
> Add documentation for the Hynitron CST816X touchscreen bindings.
>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
How this could come with review tag if this is v1? Or is it not
correctly versioned?
That will confuse all the tools...
git format-patch -v2 or just use b4.
> Signed-off-by: Oleh Kuzhylnyi <kuzhylol@gmail.com>
...
> +
> +properties:
> + compatible:
> + enum:
> + - hynitron,cst816s
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + reset-gpios:
> + maxItems: 1
> +
> +additionalProperties: false
If there is going to be new version, this goes after required: block.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-13 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 23:22 [PATCH 0/2] Code quality enhancing and add tag for dt-bindings Oleh Kuzhylnyi
2024-08-12 23:22 ` [PATCH 1/2] dt-bindings: input: touchscreen: add Hynitron CST816X Oleh Kuzhylnyi
2024-08-13 9:15 ` Krzysztof Kozlowski [this message]
2024-08-16 17:54 ` Oleh Kuzhylnyi
2024-08-12 23:22 ` [PATCH 2/2] input: add driver for Hynitron CST816X touchscreen Oleh Kuzhylnyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02baff7e-845d-4f49-b2ce-ee06934786ab@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=igor.opaniuk@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuzhylol@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).