From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jiri Kosina <jikos@kernel.org>, Charles Wang <charles.goodix@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Benjamin Tissoires <bentiss@kernel.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: input: Revert "dt-bindings: input: Goodix SPI HID Touchscreen"
Date: Thu, 26 Sep 2024 08:20:47 +0200 [thread overview]
Message-ID: <039c8de5-4599-468a-9f15-986bf2d3641e@linaro.org> (raw)
In-Reply-To: <nycvar.YFH.7.76.2409252306420.31206@cbobk.fhfr.pm>
On 25/09/2024 23:07, Jiri Kosina wrote:
> On Wed, 25 Sep 2024, Krzysztof Kozlowski wrote:
>
>> This reverts commit 9184b17fbc23 ("dt-bindings: input: Goodix SPI HID
>> Touchscreen") because it duplicates existing binding leadings to errors:
>>
>> goodix,gt7986u.example.dtb:
>> touchscreen@0: compatible: 'oneOf' conditional failed, one must be fixed:
>> ['goodix,gt7986u'] is too short
>> 'goodix,gt7375p' was expected
>>
>> This was reported on mailing list on 6th of September, but no reaction
>> happened from contributor or maintainer to fix it.
>>
>> Therefore let's drop binding which breaks and duplicates existing one.
>>
>> Fixes: 9184b17fbc23 ("dt-bindings: input: Goodix SPI HID Touchscreen")
>> Reported-by: Rob Herring <robh@kernel.org>
>> Closes: https://lore.kernel.org/all/CAL_Jsq+QfTtRj_JCqXzktQ49H8VUnztVuaBjvvkg3fwEHniUHw@mail.gmail.com/
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> I've applied both patches now and will expedite them to Linus.
Thanks Jiri,
Charles,
If you ever receive a report about an issue in your patch, you should
respond to it and address it. Regardless whether it is on the lists only
or already merged.
If you do not respond to issues reported for your commits, it might
cause impression that you only care about getting your stuff into the
kernel and whatever after does not matter. As maintainer I would not
take more patches from you in such case, I bet other maintainers would
be reluctant to take them too.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-26 6:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 19:49 [PATCH 1/2] HID: hid-goodix: drop unsupported and undocumented DT part Krzysztof Kozlowski
2024-09-25 19:49 ` [PATCH 2/2] dt-bindings: input: Revert "dt-bindings: input: Goodix SPI HID Touchscreen" Krzysztof Kozlowski
2024-09-25 21:07 ` Jiri Kosina
2024-09-26 6:20 ` Krzysztof Kozlowski [this message]
2024-09-26 18:01 ` Jiri Kosina
2024-09-25 20:03 ` [PATCH 1/2] HID: hid-goodix: drop unsupported and undocumented DT part Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039c8de5-4599-468a-9f15-986bf2d3641e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bentiss@kernel.org \
--cc=charles.goodix@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).