From: Matthias Brugger <matthias.bgg@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Fabien Parent <fparent@baylibre.com>,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
Fabien Parent <parent.f@gmail.com>
Subject: Re: [PATCH v2 0/7] Input: mt6779-keypad - double keys support
Date: Wed, 24 Aug 2022 15:55:03 +0200 [thread overview]
Message-ID: <0557c9fa-1ec4-5413-78f6-f5d78f3f9ffb@gmail.com> (raw)
In-Reply-To: <YvQ3A2/Pop4YzzQ8@google.com>
On 11/08/2022 00:53, Dmitry Torokhov wrote:
> On Tue, Jul 26, 2022 at 02:56:05PM +0200, Mattijs Korpershoek wrote:
>> The MediaTek keypad controller has multiple operating modes:
>> * single key detection (currently implemented)
>> * double key detection
>>
>> With double key detection, each (row,column) is a group that can detect
>> two keys in the key matrix.
>> This minimizes the overall pin counts for cost reduction.
>> However, pressing multiple keys in the same group will not be
>> detected properly.
>>
>> On some boards, like mt8183-pumpkin, double key detection is used.
>>
>> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
>
> Applied patches 1 through 5 (leaving dts patches out), thank you.
>
Applied 6 and 7 now. Thanks!
>>
>> ---
>> Changes in v2:
>> - bindings: add matrix-keymap justification in commit message (Krzysztof)
>> - bindings: switch from double-keys(boolean) to keys-per-group(uint32) (Krzysztof)
>> - driver: add a function pointer for row/column calculation (Angelo)
>> - Link to v1: https://lore.kernel.org/r/20220720-mt8183-keypad-v1-0-ef9fc29dbff4@baylibre.com
>>
>> ---
>> Fabien Parent (2):
>> arm64: dts: mediatek: mt8183: add keyboard node
>> arm64: dts: mediatek: mt8183-pumpkin: add keypad support
>>
>> Mattijs Korpershoek (5):
>> MAINTAINERS: input: add mattijs for mt6779-keypad
>> dt-bindings: mediatek,mt6779-keypad: use unevaluatedProperties
>> dt-bindings: mediatek,mt6779-keypad: add mediatek,keys-per-group
>> Input: mt6779-keypad - prepare double keys support with calc_row_col
>> Input: mt6779-keypad - support double keys matrix
>>
>> .../bindings/input/mediatek,mt6779-keypad.yaml | 8 ++++-
>> MAINTAINERS | 6 ++++
>> arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts | 21 +++++++++++
>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 9 +++++
>> drivers/input/keyboard/mt6779-keypad.c | 41 ++++++++++++++++++++--
>> 5 files changed, 82 insertions(+), 3 deletions(-)
>> ---
>> base-commit: 668af1b6548837b44a2bfe65dcbae6b250adbf63
>> change-id: 20220720-mt8183-keypad-20aa77106ff0
>>
>> Best regards,
>> --
>> Mattijs Korpershoek <mkorpershoek@baylibre.com>
>
prev parent reply other threads:[~2022-08-24 13:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 12:56 [PATCH v2 0/7] Input: mt6779-keypad - double keys support Mattijs Korpershoek
2022-07-26 12:56 ` [PATCH v2 1/7] MAINTAINERS: input: add mattijs for mt6779-keypad Mattijs Korpershoek
2022-07-26 12:56 ` [PATCH v2 2/7] dt-bindings: mediatek,mt6779-keypad: use unevaluatedProperties Mattijs Korpershoek
2022-07-27 10:27 ` Krzysztof Kozlowski
2022-07-26 12:56 ` [PATCH v2 3/7] dt-bindings: mediatek,mt6779-keypad: add mediatek,keys-per-group Mattijs Korpershoek
2022-07-27 10:27 ` Krzysztof Kozlowski
2022-07-26 12:56 ` [PATCH v2 4/7] Input: mt6779-keypad - prepare double keys support with calc_row_col Mattijs Korpershoek
2022-07-27 7:34 ` AngeloGioacchino Del Regno
2022-07-26 12:56 ` [PATCH v2 5/7] Input: mt6779-keypad - support double keys matrix Mattijs Korpershoek
2022-07-27 7:34 ` AngeloGioacchino Del Regno
2022-07-26 12:56 ` [PATCH v2 6/7] arm64: dts: mediatek: mt8183: add keyboard node Mattijs Korpershoek
2022-07-26 12:56 ` [PATCH v2 7/7] arm64: dts: mediatek: mt8183-pumpkin: add keypad support Mattijs Korpershoek
2022-08-10 22:53 ` [PATCH v2 0/7] Input: mt6779-keypad - double keys support Dmitry Torokhov
2022-08-24 13:55 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0557c9fa-1ec4-5413-78f6-f5d78f3f9ffb@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fparent@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mkorpershoek@baylibre.com \
--cc=parent.f@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).