From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 674D33B42CD for ; Fri, 16 Oct 2026 14:33:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792161231; cv=none; b=KJR3rqNDrFYd342cxPNwwgbrNNQ3LWAF2htUfQBl36GsRxsZEEBnrUKk+3WBDc9b5oVtPLbJRKXFV2QR9PqzEozO2CJCbIN5DEbEiBCX/aa2jU81MEM27OAhMY+Ewvc5jOnOZSdDbhwSXgxDiys7I/AiJ/OC6zD7zjxkGXlzmzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792161231; c=relaxed/simple; bh=QSVM91zrGm4qnssPxMt8adG1wTh5Gl2O5ZTVucNf80E=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=qYp7TuAEU1i2zs4I6E+725lBfgYRd7x2tQi3y1byJ/wGvq8TjKXLdDrOzFDYyUJ4/lD7rAyKOlHWWZwVLCUcZG/HvzPfX6Ig7usZfoAo47ApBk82rJ9anuDHcd2546S0eeK8rJZkTtkxZhJBg1X3/CRjJkojnpqiBQFL0vAtMgU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IKaq96GS; arc=none smtp.client-ip=74.125.82.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IKaq96GS" Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-35ef6b49813so4430605eec.0 for ; Fri, 16 Oct 2026 07:33:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792161229; x=1792766029; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id :references:in-reply-to:user-agent:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=QSVM91zrGm4qnssPxMt8adG1wTh5Gl2O5ZTVucNf80E=; b=IKaq96GS98nryJH7BlQfIW0Sj5M6HG8x3l89+qxBL3oatXi5TcMorN9+I9Orf6ndj+ XKYmx/e+CHa+yQMUCHT+ivPUheyK6bvKcsLRlmtXFH7XmU/6zOgJXYLGrFxNtVwlSdHn +6hBATKkHk8E/c9HCyMfCcDJGU8sdx/hGahoY0SyAijlC7NP/brRwikSB801H5RcY6+r TYL/pLWn6QAhrvirqaLHPBy57xPeClWHfjx0XWMaDPQA8dhl1USOTIBTFd+CMdn/ZV1y /B/6x20th2THaEwd9NUcOmxaL0mJBabJ4LQs6wphbcftdBn+NxGkZCXCfpoX48yw56OU qsrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792161229; x=1792766029; h=content-transfer-encoding:content-type:mime-version:message-id :references:in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QSVM91zrGm4qnssPxMt8adG1wTh5Gl2O5ZTVucNf80E=; b=Ft7lezX/ecUzXFJtCRI5uyqkr7SIF85r9fko4WiHLybunnSyy3UJdqG0dnb44oXOgm Sv6V/GzLutqOy+ZDgDH8c486nhHMb1VAyagQLkaVERQtNyCbowXAatnSdVd5VLLN+zT6 prXdilA22kxN0XLqy/rNaLSVVUvcI7kVqmBs87BMr1OpqyqeDS5kWROGYjTG9meAp4/V Yk0Il3j32otFlfor7aWnFRzDBgpMXeMgWqBSsK/kfGk83bZ2IdpsgnS0Gs+aqpeYM4fw PjlQF8HPVJDiF3ZM3GizZXKEsmHfb9Qz+dP4FwwT09zyJecHSh2/jh/gaQKZOMUcCNFV JY4w== X-Forwarded-Encrypted: i=1; AKwUvBx5y1y4BfYekY153r1OayacoPovTEOuzeCQER96OUL9C0UCvGT3ARWh72eke7n29x9vnNkiSKSz+8yHZA==@vger.kernel.org X-Gm-Message-State: AFq9FYL6409BGWJz9N4zQ2o/XWu2W8nNSzQEDxCLkvbu0ZyV1ZnowoNF j7Gqphs1cam1pUjX/nD7drJwAtScZNOdCIqmBmHlviufATAUQS3ab9ZxlcFKnQ== X-Gm-Gg: AYBFou30Gj1HfaZfd01catiCvKAp1xdfgwqyZ/kFvz1KUCZboGXADXXfOKgC79JSF2L 5dGL2pZpOqPCeyGF9MJ5VQHujEm5ccrquqomSGXgtaDZLG84G7u0H1QufBPpWVtJYEN/FlUYv6W f41VYl/JVJRkzyvnwJ0oI469OtsnesGZVjsjfqwoIeFp4RyoQxuEv0ZRH+bni5Xc9WMXprk/zl4 qdCmVKILb6lwHdf85bq/RFkO9Aw0C8Jz0Oe5K+iAGkDeHdy1nz76Np5TF+ZNYr3cHT3rms841Cy VSCObEz1PTva547ZA9M+BjCgY394OnLgdN4pnqw4ith48Orq8ubKTK+Bjan6D94ylG7PfYo/WyU c96OO/8xeX2V6FK/B1aJAlV26onhIa6YEi+SuXC1KOsydeaCEdNiBAli29rJBUaN3Z/sgKaEXh2 ZmNwRp+YvGqPo+2SQ+d9gphz+Se6+08EyMWV9BwiygNZUzJOdnJd33N/T5jSJskV2QPMYnkkpHW oBNJnzQDEnL3O+hNqtfZXC6piBU/knF0t2tJwbc5MrIuQsdzazVn/nEuoUkOC7XrNVEzg== X-Received: by 2002:a05:7022:ea46:10b0:144:fb31:a597 with SMTP id a92af1059eb24-185150c9622mr124919c88.47.1792161229304; Fri, 16 Oct 2026 07:33:49 -0700 (PDT) Received: from ehlo.thunderbird.net (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1831c5cb39esm6787446c88.22.2026.10.16.07.33.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Oct 2026 07:33:48 -0700 (PDT) Date: Fri, 16 Oct 2026 07:33:50 -0700 From: "Derek J. Clark" To: Jiri Kosina CC: Benjamin Tissoires , "Pierre-Loup A . Griffais" , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@lists.opengamingcollective.org Subject: Re: [PATCH 00/10] HID: hid-lenovo-go-s: Fix various bugs User-Agent: Thunderbird for Android In-Reply-To: <7s882475-7947-nsq0-60s9-9s52981s18p3@xreary.bet> References: <20260914225303.868569-1-derekjohn.clark@gmail.com> <7s882475-7947-nsq0-60s9-9s52981s18p3@xreary.bet> Message-ID: <07187173-AFEC-4500-BD17-2A55BCA71FA4@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On October 16, 2026 3:03:06 AM PDT, Jiri Kosina wrote: >On Mon, 14 Sep 2026, Derek J=2E Clark wrote: > >> This series fixes various bugs in the hid-lenovo-go-s driver >>=20 >> Patch 1 fixes a dropped error on return from mcu_property_out() >>=20 >> Patch 2 creates a mechanism to ignore stale responses if they timed out >> in the previous command=2E >>=20 >> Patch 3 fixes a deadlock if the device is removed while cfg_setup() is >> running=2E >>=20 >> Patch 4 adds missing pm_ptr to the reset_resume function pointer=2E >>=20 >> Patch 5 adds a kobject_uevent notify during reset-resume to ensure the >> os_mode return is caught by udev=2E >>=20 >> Patch 6 adds a suspend callback to cancel delayed work and re-queue the >> cfg_setup if the device was suspended prior to or during the work=2E >>=20 >> Patch 7 moves attribute init to the end of cfg_setup, ensuring the >> attributes can only be used once the MCU is ready=2E >>=20 >> Patch 8 reorganizes hid_gos_cfg and renamed it to gos_cfg_drvdata in >> preparation for later fixes=2E >>=20 >> Patch 9 moves the static led_classdev to become a member of the drvdata >> struct=2E >>=20 >> Patch 10 moved drvdata from a static global to a device allocated >> struct=2E > >Given where we currently are in the development process, I've queued the= =20 >whole lot in hid=2Egit#for-7=2E4/lenovo, thanks=2E Hi Jiri, I've fixed the bugs Sashiko pointed out locally yesterday (a few of them w= ere quite valid) and have been waiting for my local sashiko pass to submit = v2=2E I'd recommend waiting to merge them if possible=2E I should be able t= o submit them today=2E Thanks, Derek