From: Pavel Rojtberg <rojtberg@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
Santosh De Massari <s.demassari@gmail.com>
Subject: Re: [PATCH 3/4] Input: xpad - Poweroff XBOX360W on mode button long press
Date: Thu, 18 Aug 2022 15:53:01 +0200 [thread overview]
Message-ID: <081aefd6-9f79-a4ca-920d-7ebb7e5f9030@gmail.com> (raw)
In-Reply-To: <Yv46iY/C8RH/+UIe@kroah.com>
Am 18.08.22 um 15:11 schrieb Greg KH:
> On Thu, Aug 18, 2022 at 03:00:20PM +0200, Pavel Rojtberg wrote:
>> From: Santosh De Massari <s.demassari@gmail.com>
>>
>> Newer gamepads turn themselves off when the mode button is held down.
>> For XBOX360W gamepads we must do this in the driver.
>>
>> Do not use BIT() macro for consistency within the file.
>
> You can fix the file up to properly use the BIT() macro :)
>
> thanks,
>
> greg k-h
That change should be a separate patch anyway, no?
Can we postpone this to the next patch series?
Greetings, Pavel
next prev parent reply other threads:[~2022-08-18 13:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 13:00 [PATCH 0/4] Input: xpad - sync with github fork Pavel Rojtberg
2022-08-18 13:00 ` [PATCH 1/4] Input: xpad - add supported devices as contributed on github Pavel Rojtberg
2022-08-18 13:10 ` Greg KH
2022-08-18 13:46 ` Pavel Rojtberg
2022-08-18 14:06 ` Greg KH
2022-08-18 13:00 ` [PATCH 2/4] Input: xpad - fix wireless 360 controller breaking after suspend Pavel Rojtberg
2022-08-18 13:10 ` Greg KH
2022-08-18 13:51 ` Pavel Rojtberg
2022-08-18 14:07 ` Greg KH
2022-08-18 13:00 ` [PATCH 3/4] Input: xpad - Poweroff XBOX360W on mode button long press Pavel Rojtberg
2022-08-18 13:11 ` Greg KH
2022-08-18 13:53 ` Pavel Rojtberg [this message]
2022-08-18 14:07 ` Greg KH
2022-08-18 13:00 ` [PATCH 4/4] Input: xpad - add support for XBOX One Elite paddles Pavel Rojtberg
2022-08-18 13:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=081aefd6-9f79-a4ca-920d-7ebb7e5f9030@gmail.com \
--to=rojtberg@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=s.demassari@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).