From: "Hemanth V" <hemanthv@ti.com>
To: Christoph Fritz <chf.fritz@googlemail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
"Datta, Shubhrajyoti" <shubhrajyoti@ti.com>,
linux-input@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [RFC][PATCHv3 1/2] SFH7741: proximity sensor driver support
Date: Thu, 13 May 2010 12:16:16 +0530 [thread overview]
Message-ID: <09ea01caf267$fe48d620$LocalHost@wipblrx0099946> (raw)
In-Reply-To: 1273694895.15717.4.camel@lovely
----- Original Message -----
From: "Christoph Fritz" <chf.fritz@googlemail.com>
To: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
Cc: "Jonathan Cameron" <jic23@cam.ac.uk>; "Datta, Shubhrajyoti"
<shubhrajyoti@ti.com>; <linux-input@vger.kernel.org>;
<linux-omap@vger.kernel.org>
Sent: Thursday, May 13, 2010 1:38 AM
Subject: Re: [RFC][PATCHv3 1/2] SFH7741: proximity sensor driver support
> On Wed, 2010-05-12 at 11:29 -0700, Dmitry Torokhov wrote:
>> On Wed, May 12, 2010 at 07:15:22PM +0100, Jonathan Cameron wrote:
>> > Hi,
>> >
>> > I was wondering if you could provide a bit more detail on what this
>> > driver is actually doing? My appologies if I have missed a
>> > previous explanation. If so, please add a Documentation file
>> > to explain what is going on.
>> >
>> > The driver you have here does virtually nothing itself. It takes
>> > both its source of interrupt and read function from platform
>> > data. Given the value is always 0 or 1, I'm guessing you are
>> > simply reading a gpio pin. That makes this effectively a button
>> > and doesn't require any specific code. The fact it is a
>> > proximity sensor isn't relevant to anything other than perhaps
>> > the name.
>>
>> Excellent point. Maybe it should simply use gpio_keys driver with
>> SW_FRONT_PROXIMITY code.
>>
>
> I had a look into the datasheet, this SFH 7741 has one Schmitt trigger
> output: So yes, it's a "key" even without chatter.
>
Output being configured as GPIO is specific to OMAP4 board, SFH7741 doesnot
really
mandate this. The idea behind this driver is to provide a generic interface
and
hooks for platform specific configuration.
Will using gpio_keys make this very specific to platform configuration.
Thanks
Hemanth
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2010-05-13 6:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 15:26 [RFC][PATCHv3 1/2] SFH7741: proximity sensor driver support Datta, Shubhrajyoti
2010-05-12 18:15 ` Jonathan Cameron
2010-05-12 18:29 ` Dmitry Torokhov
2010-05-12 20:08 ` Christoph Fritz
2010-05-13 6:46 ` Hemanth V [this message]
2010-05-13 7:50 ` Dmitry Torokhov
2010-05-13 8:04 ` Hemanth V
2010-05-13 8:12 ` Dmitry Torokhov
2010-05-14 8:53 ` Datta, Shubhrajyoti
2010-05-12 18:25 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='09ea01caf267$fe48d620$LocalHost@wipblrx0099946' \
--to=hemanthv@ti.com \
--cc=chf.fritz@googlemail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jic23@cam.ac.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).