From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zheng, Qi" Subject: RE: [PATCH] input:gpio-key: set IRQF_NO_SUSPEND for wake capable key Date: Fri, 9 Oct 2015 02:14:11 +0000 Message-ID: <0DD381DBF8F68D419C32ACFCEB28EB25212F7D02@SHSMSX101.ccr.corp.intel.com> References: <1442506019-13687-1-git-send-email-qipeng.zha@intel.com> <20151002174146.GB8437@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: Received: from mga02.intel.com ([134.134.136.20]:4532 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756337AbbJICOQ convert rfc822-to-8bit (ORCPT ); Thu, 8 Oct 2015 22:14:16 -0400 In-Reply-To: <20151002174146.GB8437@dtor-ws> Content-Language: en-US Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov , Linus Walleij Cc: "Zha, Qipeng" , Linux Input , "Li, Aubrey" Hi, "enable_irq_wake" is to enable/disable power-management wake-on of an IRQ. It is wake-on control not interrupt enable control. In my opinion, to make sure the keys press working when system suspend, both wake-on and interrupt should be enabled. Besides, for many platforms, the gpio irq chip don't implement the method "enable_irq_wake" by setting "IRQCHIP_SKIP_SET_WAKE". So, I think "IRQF_NO_SUSPEND" is necessary for this case. BRs Zheng Qi PEG->IPG->EIG SH IO/LPSS team -----Original Message----- From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com] Sent: Saturday, October 3, 2015 1:42 AM To: Linus Walleij Cc: Zha, Qipeng ; Linux Input ; Zheng, Qi ; Li, Aubrey Subject: Re: [PATCH] input:gpio-key: set IRQF_NO_SUSPEND for wake capable key On Fri, Oct 02, 2015 at 03:26:27AM -0700, Linus Walleij wrote: > On Thu, Sep 17, 2015 at 9:06 AM, Qipeng Zha wrote: > > > When wakeup attribute is set, GPIO key is supposed to wake up the > > system from system sleep state, So set IRQF_NO_SUSPEND flag to keep > > IRQ enabled during suspend. > > > > Signed-off-by: Qi Zheng > > Signed-off-by: Aubrey Li > > Signed-off-by: Qipeng Zha > > Reviewed-by: Linus Walleij > > Should this not be tagged for stable? I do not believe we need this at all. Otherwise every single driver for devices that might be wakeup sources needs this flag set. Which would basically means it is a noop and we should not suspend IRQ threads by default. The dirver correctly calls enable_irq_wake() and platform should do whatever it needs to make sure wakeup interrupt will be serviced. Thanks. -- Dmitry