From: Claudiu Beznea <Claudiu.Beznea@microchip.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: mark.rutland@arm.com, milo.kim@ti.com,
linux-fbdev@vger.kernel.org, sean@mess.org,
devicetree@vger.kernel.org, airlied@linux.ie,
mturquette@baylibre.com, joonas.lahtinen@linux.intel.com,
kamil@wypas.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
alexandre.belloni@free-electrons.com, pavel@ucw.cz,
lee.jones@linaro.org, linux-clk@vger.kernel.org,
linux-leds@vger.kernel.org, daniel.thompson@linaro.org,
linux-samsung-soc@vger.kernel.org, shc_work@mail.ru,
corbet@lwn.net, linux-doc@vger.kernel.org, linux@armlinux.org.uk,
krzk@kernel.org, kgene@kernel.org, linux-input@vger.kernel.org,
linux@roeck-us.net, linux-media@vger.kernel.org,
linux-pwm@vger.kernel.org, jdelvare@suse.com,
b.zolnierkie@samsung.com, intel-gfx@lists.freedesktop.org,
jani.nikula@linux.intel.com, robh+dt@kernel.org,
jacek.anaszewski@gmail.com, rodrigo.vivi@intel.com,
mchehab@kernel.orgl
Subject: Re: [PATCH v3 05/10] pwm: add PWM mode to pwm_config()
Date: Fri, 2 Mar 2018 11:19:43 +0200 [thread overview]
Message-ID: <0c3fc3ba-8640-0b2c-a9ec-ab848227c92d@microchip.com> (raw)
In-Reply-To: <20180228194429.GD22932@mithrandir>
On 28.02.2018 21:44, Thierry Reding wrote:
> On Thu, Feb 22, 2018 at 02:01:16PM +0200, Claudiu Beznea wrote:
>> Add PWM mode to pwm_config() function. The drivers which uses pwm_config()
>> were adapted to this change.
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>> ---
>> arch/arm/mach-s3c24xx/mach-rx1950.c | 11 +++++++++--
>> drivers/bus/ts-nbus.c | 2 +-
>> drivers/clk/clk-pwm.c | 3 ++-
>> drivers/gpu/drm/i915/intel_panel.c | 17 ++++++++++++++---
>> drivers/hwmon/pwm-fan.c | 2 +-
>> drivers/input/misc/max77693-haptic.c | 2 +-
>> drivers/input/misc/max8997_haptic.c | 6 +++++-
>> drivers/leds/leds-pwm.c | 5 ++++-
>> drivers/media/rc/ir-rx51.c | 5 ++++-
>> drivers/media/rc/pwm-ir-tx.c | 5 ++++-
>> drivers/video/backlight/lm3630a_bl.c | 4 +++-
>> drivers/video/backlight/lp855x_bl.c | 4 +++-
>> drivers/video/backlight/lp8788_bl.c | 5 ++++-
>> drivers/video/backlight/pwm_bl.c | 11 +++++++++--
>> drivers/video/fbdev/ssd1307fb.c | 3 ++-
>> include/linux/pwm.h | 6 ++++--
>> 16 files changed, 70 insertions(+), 21 deletions(-)
>
> I don't think it makes sense to leak mode support into the legacy API.
> The pwm_config() function is considered legacy
I missed this aspect.
and should eventually go
> away. As such it doesn't make sense to integrate a new feature such as
> PWM modes into it.
Agree.
All users of pwm_config() assume normal mode, and
> that's what pwm_config() should provide.
Agree.
>
> Anyone that needs something other than normal mode should use the new
> atomic PWM API.
Agree.
>
> Thierry
>
next prev parent reply other threads:[~2018-03-02 9:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 12:01 [PATCH v3 00/10] extend PWM framework to support PWM modes Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 01/10] pwm: extend PWM framework with " Claudiu Beznea
2018-02-24 20:49 ` kbuild test robot
2018-02-26 8:11 ` Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 02/10] pwm: clps711x: populate PWM mode in of_xlate function Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 03/10] pwm: cros-ec: " Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 04/10] pwm: pxa: " Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 05/10] pwm: add PWM mode to pwm_config() Claudiu Beznea
2018-02-22 12:33 ` Daniel Thompson
2018-02-22 13:21 ` Claudiu Beznea
2018-02-26 9:57 ` Jani Nikula
2018-02-26 14:24 ` Claudiu Beznea
2018-02-27 10:54 ` Daniel Thompson
2018-02-27 11:40 ` Claudiu Beznea
2018-02-27 15:38 ` Daniel Thompson
2018-02-27 16:15 ` Claudiu Beznea
2018-02-22 13:01 ` Sean Young
2018-02-22 13:23 ` Claudiu Beznea
2018-02-28 19:44 ` Thierry Reding
2018-02-28 20:04 ` Jani Nikula
2018-03-02 9:28 ` Claudiu Beznea
2018-03-02 9:19 ` Claudiu Beznea [this message]
2018-02-22 12:01 ` [PATCH v3 06/10] pwm: add PWM modes Claudiu Beznea
2018-02-22 17:28 ` Andy Shevchenko
2018-02-22 17:42 ` Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 07/10] pwm: atmel: add pwm capabilities Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 08/10] pwm: add push-pull mode support Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 09/10] pwm: add documentation for pwm push-pull mode Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 10/10] pwm: atmel: add push-pull mode support Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c3fc3ba-8640-0b2c-a9ec-ab848227c92d@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=airlied@linux.ie \
--cc=alexandre.belloni@free-electrons.com \
--cc=b.zolnierkie@samsung.com \
--cc=corbet@lwn.net \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jani.nikula@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kamil@wypas.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.orgl \
--cc=milo.kim@ti.com \
--cc=mturquette@baylibre.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=sean@mess.org \
--cc=shc_work@mail.ru \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).