linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: Juergen Gross <jgross@suse.com>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	linux-input@vger.kernel.org
Cc: dmitry.torokhov@gmail.com
Subject: Re: [Xen-devel] [PATCH 1/2] xen, input: add xen-kbdfront module parameter for setting resolution
Date: Mon, 10 Apr 2017 17:18:20 +0300	[thread overview]
Message-ID: <0d7df625-27a1-0c1e-49f3-e1d44c09a787@gmail.com> (raw)
In-Reply-To: <3441af57-3609-6268-c3f8-a88147553892@suse.com>

On 04/10/2017 05:11 PM, Juergen Gross wrote:
> On 10/04/17 16:00, Oleksandr Andrushchenko wrote:
>>
>> On 04/10/2017 04:50 PM, Juergen Gross wrote:
>>> On 10/04/17 15:44, Oleksandr Andrushchenko wrote:
>>>> Hi, Juergen!
>>>>
>>>> On 03/21/2017 07:19 PM, Juergen Gross wrote:
>>>>> Add a parameter for setting the resolution of xen-kbdfront in order to
>>>>> be able to cope with a (virtual) frame buffer of arbitrary resolution.
>>>>>
>>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>>> ---
>>>>>     drivers/input/misc/xen-kbdfront.c | 10 ++++++++--
>>>>>     1 file changed, 8 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/input/misc/xen-kbdfront.c
>>>>> b/drivers/input/misc/xen-kbdfront.c
>>>>> index 3900875..2df5678 100644
>>>>> --- a/drivers/input/misc/xen-kbdfront.c
>>>>> +++ b/drivers/input/misc/xen-kbdfront.c
>>>>> @@ -41,6 +41,12 @@ struct xenkbd_info {
>>>>>         char phys[32];
>>>>>     };
>>>>>     +enum { KPARAM_WIDTH, KPARAM_HEIGHT, KPARAM_CNT };
>>>>> +static int size[KPARAM_CNT] = { XENFB_WIDTH, XENFB_HEIGHT };
>>>>> +module_param_array(size, int, NULL, 0444);
>>>> is this by intention that you use 0444 here?
>>>> It means read-only, thus one cannot change these,
>>>> so what is the point of the module parameters then?
>>> You can see the settings in sysfs.
>> this is good so we can see actual width/height
>> used by the pv driver
>>> The values are settable via boot parameter.
>> but then, if one has other values set in XenStore,
>> these will/may be overridden, making it inconsistent,
>> e.g. values loaded at start as module parameters
>> (*size* array) is not going to be updated on
>> XenbusStateInitWait/XenbusStateConnected. So, we'll
>> end up with wrong parameters shown via sysfs
>> one more question is why do we need module parameters
>> if the same can be read from XenStore?
> Because up to now nobody is setting the Xenstore values. This is
> something I'm planning to do for Xen 4.10.
ah, good to know. btw, if you are about to add
width/height for the pointer device will you also add
the same for multi-touch?
>   Up to then we need a
> workaround.
>
> But you are right: The module parameters should be updated with
> the values read from Xenstore.
>
>
> Juergen


  reply	other threads:[~2017-04-10 14:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21 17:19 [PATCH 0/2] xen, input: xen-kbdfront pointing device resolution support Juergen Gross
2017-03-21 17:19 ` [PATCH 1/2] xen, input: add xen-kbdfront module parameter for setting resolution Juergen Gross
2017-04-10 13:44   ` [Xen-devel] " Oleksandr Andrushchenko
2017-04-10 13:50     ` Juergen Gross
2017-04-10 14:00       ` Oleksandr Andrushchenko
2017-04-10 14:11         ` Juergen Gross
2017-04-10 14:18           ` Oleksandr Andrushchenko [this message]
2017-04-11  8:54             ` Juergen Gross
2017-03-21 17:19 ` [PATCH 2/2] xen, input: repair xen-kbdfront resolution setting via xenstore Juergen Gross
2017-04-10 14:20   ` [Xen-devel] " Oleksandr Andrushchenko
2017-04-04 11:58 ` [PATCH 0/2] xen,input: xen-kbdfront pointing device resolution support Juergen Gross
2017-04-07 13:45   ` [Xen-devel] [PATCH 0/2] xen, input: " Oleksandr Andrushchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d7df625-27a1-0c1e-49f3-e1d44c09a787@gmail.com \
    --to=andr2000@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jgross@suse.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).