public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hendrik Noack <hendrik-noack@gmx.de>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: Ferass El Hafidi <funderscore@postmarketos.org>,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: Input: Add Wacom W9000-series penabled touchscreens
Date: Tue, 10 Mar 2026 17:58:55 +0100	[thread overview]
Message-ID: <0eb4dd77-a5b0-49ce-bc7f-d156f92c8044@kernel.org> (raw)
In-Reply-To: <20260307181557.66927-2-hendrik-noack@gmx.de>

On 07/03/2026 19:15, Hendrik Noack wrote:
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description:
> +      Optional regulator for the VDD digital voltage.

Drop "Optional regulator for"

Also, vdd is mandatory, not optional. How device can work without supply?

> +
> +  flash-mode-gpios:
> +    maxItems: 1
> +    description:
> +      Optional GPIO specifier for the touchscreen's flash-mode pin.

Drop "Optional GPIO specifier for the". Don't repeat constraints in free
form text. Schema tells what is optional or what is not. This also
cannot be anything else than GPIO specifier, so repeating obvious is not
making it more readable.

> +
> +  pen-inserted-gpios:
> +    maxItems: 1
> +    description:
> +      Optional GPIO specifier for the touchscreen's pen-insert pin.

Drop "Optional GPIO specifier for the".

> +
> +  reset-gpios:
> +    maxItems: 1
> +    description:
> +      Optional GPIO specifier for the touchscreen's reset pin.

Drop description completely. Redundant. It cannot be anything else than
reset pin.


> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - vdd-supply


Best regards,
Krzysztof

  parent reply	other threads:[~2026-03-10 16:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-07 18:15 [PATCH v4 0/2] Add support for Wacom W9000-series penabled touchscreens Hendrik Noack
2026-03-07 18:15 ` [PATCH v4 1/2] dt-bindings: Input: Add " Hendrik Noack
2026-03-08  9:15   ` Krzysztof Kozlowski
2026-03-09 12:54     ` Hendrik Noack
2026-03-09 12:56       ` Krzysztof Kozlowski
2026-03-09 13:12         ` Hendrik Noack
2026-03-09 13:21           ` Krzysztof Kozlowski
2026-03-10 16:50             ` Ferass El Hafidi
2026-03-10 16:55               ` Krzysztof Kozlowski
2026-03-10 17:08                 ` Ferass El Hafidi
2026-03-10 16:58   ` Krzysztof Kozlowski [this message]
2026-03-10 17:29   ` Dmitry Torokhov
2026-03-07 18:15 ` [PATCH v4 2/2] Input: Add support for " Hendrik Noack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0eb4dd77-a5b0-49ce-bc7f-d156f92c8044@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=funderscore@postmarketos.org \
    --cc=hendrik-noack@gmx.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox