From: Hans de Goede <hdegoede@redhat.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>, linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: multitouch: Fix system-control buttons not working
Date: Tue, 22 Aug 2017 12:08:20 +0200 [thread overview]
Message-ID: <0ec0f4b7-c33f-b968-405b-0ddbebe23822@redhat.com> (raw)
In-Reply-To: <20170822085920.GA25370@mail.corp.redhat.com>
Hi,
On 22-08-17 10:59, Benjamin Tissoires wrote:
> On Aug 22 2017 or thereabouts, Hans de Goede wrote:
>> Some laptops have system-control buttons (e.g. KEY_SLEEP) on the same
>> interface as a hid-multitouch touch-pad.
>>
>> This commit fixes these buttons not working.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>
> Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Thanks.
Note this applies on top of:
https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git/log/?h=for-4.14/multitouch
(in case that was not clear)
Regards,
Hans
>
>> drivers/hid/hid-multitouch.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
>> index 0a8689bb08e9..53d1413cd435 100644
>> --- a/drivers/hid/hid-multitouch.c
>> +++ b/drivers/hid/hid-multitouch.c
>> @@ -930,6 +930,7 @@ static int mt_input_mapping(struct hid_device *hdev, struct hid_input *hi,
>> field->application != HID_DG_PEN &&
>> field->application != HID_DG_TOUCHPAD &&
>> field->application != HID_GD_KEYBOARD &&
>> + field->application != HID_GD_SYSTEM_CONTROL &&
>> field->application != HID_CP_CONSUMER_CONTROL &&
>> field->application != HID_GD_WIRELESS_RADIO_CTLS &&
>> !(field->application == HID_VD_ASUS_CUSTOM_MEDIA_KEYS &&
>> --
>> 2.13.4
>>
next prev parent reply other threads:[~2017-08-22 10:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 6:37 [PATCH] HID: multitouch: Fix system-control buttons not working Hans de Goede
2017-08-22 8:59 ` Benjamin Tissoires
2017-08-22 10:08 ` Hans de Goede [this message]
2017-08-31 15:35 ` Hans de Goede
2017-09-05 9:42 ` Jiri Kosina
2017-09-05 10:04 ` Hans de Goede
2017-09-06 8:54 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ec0f4b7-c33f-b968-405b-0ddbebe23822@redhat.com \
--to=hdegoede@redhat.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).