From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Julien Massot <julien.massot@collabora.com>,
kernel@collabora.com, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] Input: mtk-pmic-keys - MT6359 has a specific release irq
Date: Mon, 8 Sep 2025 13:36:53 +0200 [thread overview]
Message-ID: <104d8128-26fb-4eb6-ac3f-3abbb35245b2@collabora.com> (raw)
In-Reply-To: <20250905-radxa-nio-12-l-gpio-v3-1-40f11377fb55@collabora.com>
Il 05/09/25 13:51, Julien Massot ha scritto:
> Support for MT6359 PMIC keys has been added recently.
> However, the key release event is not properly handled:
> only key press events are generated, leaving key states
> stuck in "pressed".
>
> This patch ensures that both key press and key release events
> are properly emitted by handling the release logic correctly.
>
> Introduce a 'key_release_irq' member to the 'mtk_pmic_regs',
> to identify the devices that have a separate irq for the
> release event.
>
> Fixes: bc25e6bf032e ("Input: mtk-pmic-keys - add support for MT6359 PMIC keys")
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
Please clarify the commit title.
Input: mtk-pmic-keys - Use platform data for release irq support
...or something like that.
After which:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cheers,
Angelo
next prev parent reply other threads:[~2025-09-08 11:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 11:51 [PATCH v3 0/3] Radxa NIO 12L: Add GPIO keys and LED support Julien Massot
2025-09-05 11:51 ` [PATCH v3 1/3] Input: mtk-pmic-keys - MT6359 has a specific release irq Julien Massot
2025-09-06 16:25 ` Dmitry Torokhov
2025-09-08 11:36 ` AngeloGioacchino Del Regno [this message]
2025-09-05 11:51 ` [PATCH v3 2/3] arm64: dts: mediatek: mt8395-nio-12l: add PMIC and GPIO keys support Julien Massot
2025-09-09 12:47 ` Matthias Brugger
2025-09-05 11:52 ` [PATCH v3 3/3] arm64: dts: mediatek: mt8395-nio-12l: add support for blue and red LEDs Julien Massot
2025-09-10 9:48 ` Matthias Brugger
2025-09-05 17:45 ` [PATCH v3 0/3] Radxa NIO 12L: Add GPIO keys and LED support Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=104d8128-26fb-4eb6-ac3f-3abbb35245b2@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=julien.massot@collabora.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louisalexis.eyraud@collabora.com \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).