From: Vladis Dronov <vdronov@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: aiptek: fix crash on detecting device without endpoints
Date: Wed, 2 Dec 2015 06:03:07 -0500 (EST) [thread overview]
Message-ID: <1052675973.31763834.1449054187055.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20151201211614.GB3740@dtor-ws>
Hello, Dmitry,
> > + if (intf->altsetting[0].desc.bNumEndpoints < 1) {
> > + dev_warn(&intf->dev,
>
> This should be dev_err as we are aborting device initialization. I know
> the driver user warn/info in similar places, but it is not right, we
> might want to adjust it at some point.
Yes, the driver using dev_warn() in all the similar error paths was a
reason for me to use dev_warn() here.
> > + err = -ENODEV;
>
> I believe it should be -EINVAL as well. I adjusted the above 3 items
> and applied.
Indeed, this suits best. Thank you for handling this and the issue in
general.
Best regards,
Vladis Dronov | Red Hat, Inc. | Product Security Engineer
prev parent reply other threads:[~2015-12-02 11:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 15:58 [PATCH] Input: aiptek: fix crash on detecting device without endpoints Vladis Dronov
2015-11-26 16:36 ` Dmitry Torokhov
2015-11-26 17:35 ` Alan Stern
2015-11-27 10:50 ` Vladis Dronov
2015-11-27 21:54 ` Alan Stern
2015-11-30 12:36 ` Vladis Dronov
2015-11-30 16:06 ` Alan Stern
2015-11-30 19:40 ` Dmitry Torokhov
2015-11-30 20:38 ` Alan Stern
2015-11-30 21:11 ` Dmitry Torokhov
2015-12-01 8:09 ` Vladis Dronov
2015-12-01 15:07 ` Alan Stern
2015-12-01 21:16 ` Dmitry Torokhov
2015-12-02 11:03 ` Vladis Dronov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1052675973.31763834.1449054187055.JavaMail.zimbra@redhat.com \
--to=vdronov@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).