From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-input@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] Add virtual "idle" device
Date: Tue, 3 Mar 2009 11:00:04 +0100 [thread overview]
Message-ID: <10f740e80903030200y3f055c28u6a01f279a53cacc1@mail.gmail.com> (raw)
In-Reply-To: <1236033772-20329-2-git-send-email-marcin.slusarz@gmail.com>
On Mon, Mar 2, 2009 at 23:42, Marcin Slusarz <marcin.slusarz@gmail.com> wrote:
> --- /dev/null
> +++ b/drivers/char/idle.c
> @@ -0,0 +1,445 @@
> +#ifdef DEBUG
> +#define idle_printk(args...) printk(KERN_DEBUG "IDLEDEV: " args)
> +#else
> +#define idle_printk(args...) do {} while (0)
> +#endif
Please use the standard debug interface, i.e.
#define pr_fmt(fmt) "IDLEDEV: " fmt
and use pr_debug() everywhere, to always have printf()-style format checking.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2009-03-03 10:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 22:42 [RFC PATCH 2/2] Add virtual "idle" device Marcin Slusarz
2009-03-03 10:00 ` Geert Uytterhoeven [this message]
2009-03-03 14:17 ` Marcin Slusarz
2009-03-06 18:43 ` Pavel Machek
2009-03-12 1:08 ` Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10f740e80903030200y3f055c28u6a01f279a53cacc1@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).