From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [RFC PATCH 2/2] Add virtual "idle" device Date: Tue, 3 Mar 2009 11:00:04 +0100 Message-ID: <10f740e80903030200y3f055c28u6a01f279a53cacc1@mail.gmail.com> References: <1236033772-20329-2-git-send-email-marcin.slusarz@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bw0-f178.google.com ([209.85.218.178]:40709 "EHLO mail-bw0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753147AbZCCKAI (ORCPT ); Tue, 3 Mar 2009 05:00:08 -0500 In-Reply-To: <1236033772-20329-2-git-send-email-marcin.slusarz@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Marcin Slusarz Cc: LKML , linux-input@vger.kernel.org On Mon, Mar 2, 2009 at 23:42, Marcin Slusarz wrote: > --- /dev/null > +++ b/drivers/char/idle.c > @@ -0,0 +1,445 @@ > +#ifdef DEBUG > +#define idle_printk(args...) printk(KERN_DEBUG "IDLEDEV: " args) > +#else > +#define idle_printk(args...) do {} while (0) > +#endif Please use the standard debug interface, i.e. #define pr_fmt(fmt) "IDLEDEV: " fmt and use pr_debug() everywhere, to always have printf()-style format checking. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds