From: Johannes Berg <johannes@sipsolutions.net>
To: linux-input <linux-input@atrey.karlin.mff.cuni.cz>
Cc: "Antonio-M. Corbi Bellot" <antonio.corbi@ua.es>,
Jiri Kosina <jkosina@suse.cz>, Bart Massey <bart@cs.pdx.edu>
Subject: [PATCH] don't invert mightymouse hwheel
Date: Thu, 12 Apr 2007 00:23:52 +0200 [thread overview]
Message-ID: <1176330232.27324.7.camel@johannes.berg> (raw)
Commit a82e49b8aeb9f8dafdf6cf2e617c8b95bf056257 said:
Further, the quirks for the Apple Mighty Mouse are not quite right: the
horizontal scrolling needs its axis reversed, and the left and center
buttons are transposed.
This is not true. With this X configuration:
Section "InputDevice"
Identifier "EvDev"
Driver "evdev"
Option "SendCoreEvents" "true"
Option "evBits" "+1-2"
Option "keyBits" "~272-287"
Option "relBits" "~0-2 ~6 ~8"
Option "Pass" "3"
EndSection
I can scroll up in a window by moving my finger up, and scroll left in a
window by moving my finger right. That makes no sense, this patch therefore
removes the INVERT_HWHEEL quirk from the USB mightymouse.
I didn't change the bluetooth mightymouse, maybe it has this quirk after
all. My USB one definitely doesn't. If the bluetooth version doesn't have
that quirk either, we can completely remove the INVERT_HWHEEL quirk.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Bart Massey <bart@cs.pdx.edu>
Cc: Antonio-M. Corbi Bellot <antonio.corbi@ua.es>
---
drivers/usb/input/hid-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- wireless-dev.orig/drivers/usb/input/hid-core.c 2007-04-12 00:09:17.754507072 +0200
+++ wireless-dev/drivers/usb/input/hid-core.c 2007-04-12 00:09:25.334507072 +0200
@@ -898,7 +898,7 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_WISEGROUP, USB_DEVICE_ID_DUAL_USB_JOYPAD, HID_QUIRK_NOGET | HID_QUIRK_MULTI_INPUT },
{ USB_VENDOR_ID_WISEGROUP_LTD, USB_DEVICE_ID_SMARTJOY_DUAL_PLUS, HID_QUIRK_NOGET | HID_QUIRK_MULTI_INPUT },
- { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MIGHTYMOUSE, HID_QUIRK_MIGHTYMOUSE | HID_QUIRK_INVERT_HWHEEL },
+ { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MIGHTYMOUSE, HID_QUIRK_MIGHTYMOUSE },
{ USB_VENDOR_ID_A4TECH, USB_DEVICE_ID_A4TECH_WCP32PU, HID_QUIRK_2WHEEL_MOUSE_HACK_7 },
{ USB_VENDOR_ID_CYPRESS, USB_DEVICE_ID_CYPRESS_MOUSE, HID_QUIRK_2WHEEL_MOUSE_HACK_5 },
next reply other threads:[~2007-04-11 22:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-11 22:23 Johannes Berg [this message]
2007-04-12 16:04 ` [PATCH] don't invert mightymouse hwheel Jiri Kosina
2007-04-12 21:25 ` Barton C Massey
2007-04-13 6:40 ` Johannes Berg
2007-04-25 20:06 ` Zephaniah E. Hull
2007-04-25 23:09 ` Barton C Massey
2007-04-26 0:00 ` Zephaniah E. Hull
2007-04-26 18:35 ` Barton C Massey
-- strict thread matches above, loose matches on Subject: below --
2007-04-13 0:21 Barton C Massey
2007-04-13 6:45 ` Johannes Berg
2007-04-13 7:43 ` Jiri Kosina
2007-04-13 9:30 ` Johannes Berg
2007-04-23 10:27 ` Barton C Massey
2007-04-23 13:13 ` Jiri Kosina
2007-04-23 13:43 ` Johannes Berg
2007-04-23 14:07 ` Jiri Kosina
2007-04-23 14:13 ` Johannes Berg
2007-04-26 8:24 ` Johannes Berg
2007-04-13 0:32 Barton C Massey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1176330232.27324.7.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=antonio.corbi@ua.es \
--cc=bart@cs.pdx.edu \
--cc=jkosina@suse.cz \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).