From: Richard Purdie <rpurdie@rpsys.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@atrey.karlin.mff.cuni.cz
Subject: [PATCH] Fix spitzkbd compile warnings
Date: Sun, 13 May 2007 13:35:47 +0100 [thread overview]
Message-ID: <1179059748.5883.3.camel@localhost.localdomain> (raw)
Fix compile warnings from spitzkbd.c. Registration failure of these IRQs
isn't fatal so just warn about it.
Signed-off-by: Richard Purdie <rpurdie@rpsys.net>
diff --git a/drivers/input/keyboard/spitzkbd.c b/drivers/input/keyboard/spitzkbd.c
index 41b8038..a609d43 100644
--- a/drivers/input/keyboard/spitzkbd.c
+++ b/drivers/input/keyboard/spitzkbd.c
@@ -418,21 +418,26 @@ static int __init spitzkbd_probe(struct platform_device *dev)
pxa_gpio_mode(SPITZ_GPIO_SWA | GPIO_IN);
pxa_gpio_mode(SPITZ_GPIO_SWB | GPIO_IN);
- request_irq(SPITZ_IRQ_GPIO_SYNC, spitzkbd_interrupt,
+ if (request_irq(SPITZ_IRQ_GPIO_SYNC, spitzkbd_interrupt,
IRQF_DISABLED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
- "Spitzkbd Sync", spitzkbd);
- request_irq(SPITZ_IRQ_GPIO_ON_KEY, spitzkbd_interrupt,
+ "Spitzkbd Sync", spitzkbd))
+ printk(KERN_WARNING "spitzkbd: Failed to request sync IRQ\n");
+ if (request_irq(SPITZ_IRQ_GPIO_ON_KEY, spitzkbd_interrupt,
IRQF_DISABLED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
- "Spitzkbd PwrOn", spitzkbd);
- request_irq(SPITZ_IRQ_GPIO_SWA, spitzkbd_hinge_isr,
+ "Spitzkbd PwrOn", spitzkbd))
+ printk(KERN_WARNING "spitzkbd: Failed to request GPIO IRQ\n");
+ if (request_irq(SPITZ_IRQ_GPIO_SWA, spitzkbd_hinge_isr,
IRQF_DISABLED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
- "Spitzkbd SWA", spitzkbd);
- request_irq(SPITZ_IRQ_GPIO_SWB, spitzkbd_hinge_isr,
+ "Spitzkbd SWA", spitzkbd))
+ printk(KERN_WARNING "spitzkbd: Failed to request SWA IRQ\n");
+ if (request_irq(SPITZ_IRQ_GPIO_SWB, spitzkbd_hinge_isr,
IRQF_DISABLED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
- "Spitzkbd SWB", spitzkbd);
- request_irq(SPITZ_IRQ_GPIO_AK_INT, spitzkbd_hinge_isr,
+ "Spitzkbd SWB", spitzkbd))
+ printk(KERN_WARNING "spitzkbd: Failed to request SWB IRQ\n");
+ if (request_irq(SPITZ_IRQ_GPIO_AK_INT, spitzkbd_hinge_isr,
IRQF_DISABLED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
- "Spitzkbd HP", spitzkbd);
+ "Spitzkbd HP", spitzkbd))
+ printk(KERN_WARNING "spitzkbd: Failed to request AK IRQ\n");
return 0;
next reply other threads:[~2007-05-13 12:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-13 12:35 Richard Purdie [this message]
2007-05-13 13:16 ` [PATCH] Fix spitzkbd compile warnings Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1179059748.5883.3.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).