linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marvin Raaijmakers <marvin.nospam@gmail.com>
To: Jiri Kosina <jikos@jikos.cz>
Cc: Vojtech Pavlik <vojtech@suse.cz>,
	federico ferri <xaero@inwind.it>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@atrey.karlin.mff.cuni.cz, mzxrlshmm@0pointer.de
Subject: Re: [PATCH] input: change SysRq keycode for systems without SysRq	key
Date: Fri, 17 Aug 2007 16:35:18 +0200	[thread overview]
Message-ID: <1187361318.3684.30.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0708171216160.2460@twin.jikos.cz>

This code doesn't filter out the "status events" right? So that still
needs to be done(?).

- Marvin

On Fri, 2007-08-17 at 12:22 +0200, Jiri Kosina wrote:
> (CCs trimmed a little bit)
> 
> On Fri, 17 Aug 2007, Marvin Raaijmakers wrote:
> 
> > What's the current state of this patch?
> 
> Hi Marvin,
> 
> does the patch below establish the functionality you are looking for? 
> Please note that we do the reporting only for such usages that have the 
> type of EV_KEY.
> 
> 
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 8edbd30..7f4731b 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -888,6 +888,11 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
>  		set_bit(KEY_VOLUMEDOWN, input->keybit);
>  	}
>  
> +	if (usage->type == EV_KEY) {
> +		set_bit(EV_MSC, input->evbit);
> +		set_bit(MSC_SCAN, input->mscbit);
> +	}
> +
>  	hid_resolv_event(usage->type, usage->code);
>  
>  	dbg_hid_line("\n");
> @@ -991,6 +996,9 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
>  		return;
>  	}
>  
> +	if (usage->type == EV_KEY && !!test_bit(usage->code, input->key) != value)
> +		input_event(input, EV_MSC, MSC_SCAN, usage->hid);
> +
>  	input_event(input, usage->type, usage->code, value);
>  
>  	if ((field->flags & HID_MAIN_ITEM_RELATIVE) && (usage->type == EV_KEY))
> 

  reply	other threads:[~2007-08-17 14:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-15 17:04 [PATCH] input: change SysRq keycode for systems without SysRq key federico ferri
2007-07-15 18:03 ` Linus Torvalds
2007-07-15 18:34   ` federico ferri
2007-07-15 18:57     ` Linus Torvalds
2007-07-15 22:04       ` federico ferri
2007-07-15 22:15         ` Linus Torvalds
2007-07-16 12:41           ` Dmitry Torokhov
2007-07-17  6:40             ` federico ferri
2007-07-17 15:11               ` Dmitry Torokhov
2007-07-18 20:55                 ` federico ferri
2007-07-19 21:00                   ` Dmitry Torokhov
2007-07-19 21:00                     ` Dmitry Torokhov
2007-07-19 21:39                     ` federico ferri
2007-07-19 22:32                       ` Dmitry Torokhov
2007-07-19 23:29                         ` federico ferri
2007-07-30 14:09                           ` Jiri Kosina
2007-08-02 21:27                             ` Vojtech Pavlik
2007-08-17  8:25                               ` Marvin Raaijmakers
2007-08-17 10:22                                 ` Jiri Kosina
2007-08-17 14:35                                   ` Marvin Raaijmakers [this message]
2007-08-17 14:42                                     ` Jiri Kosina
2007-08-17 15:01                                       ` Marvin Raaijmakers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1187361318.3684.30.camel@localhost.localdomain \
    --to=marvin.nospam@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jikos@jikos.cz \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=mzxrlshmm@0pointer.de \
    --cc=vojtech@suse.cz \
    --cc=xaero@inwind.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).