[PATCH V3 1/3] ACPI video hotkey: add new input key code for ACPI video hotkey events

[PATCH V3 1/3] ACPI video hotkey: add new input key code for ACPI video hotkey events

[Zhang Rui]

From: Yu Luming <luming.yu@intel.com>

Add keycode for ACPI video driver hotkey events.

Signed-off-by: Yu Luming <luming.yu@intel.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
 include/linux/input.h |    7 +++++++
 1 file changed, 7 insertions(+)

Index: linux-2.6.23-rc3/include/linux/input.h
===================================================================
--- linux-2.6.23-rc3.orig/include/linux/input.h
+++ linux-2.6.23-rc3/include/linux/input.h
@@ -553,6 +553,13 @@ struct input_absinfo {
 #define KEY_BRL_DOT7		0x1f7
 #define KEY_BRL_DOT8		0x1f8
 
+#define KEY_DISPLAY_CYCLE	0x1f9
+#define KEY_VIDEO_NEXT		0x1fa
+#define KEY_VIDEO_PREV		0x1fb
+#define KEY_BRIGHTNESS_CYCLE	0x1fc
+#define KEY_BRIGHTNESS_ZERO	0x1fd
+#define KEY_DISPLAY_OFF		0x1fe
+
 /* We avoid low common keys in module aliases so they don't get huge. */
 #define KEY_MIN_INTERESTING	KEY_MUTE
 #define KEY_MAX			0x1ff

Re: [PATCH V3 1/3] ACPI video hotkey: add new input key code for ACPI video hotkey events

[Len Brown]

Dmitry,
can you ACK these additional key-codes?
I need to push the 3rd patch in this series which depends on these.

thanks,
-Len

On Monday 20 August 2007 06:23, Zhang Rui wrote:
> From: Yu Luming <luming.yu@intel.com>
> 
> Add keycode for ACPI video driver hotkey events.
> 
> Signed-off-by: Yu Luming <luming.yu@intel.com>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> ---
>  include/linux/input.h |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> Index: linux-2.6.23-rc3/include/linux/input.h
> ===================================================================
> --- linux-2.6.23-rc3.orig/include/linux/input.h
> +++ linux-2.6.23-rc3/include/linux/input.h
> @@ -553,6 +553,13 @@ struct input_absinfo {
>  #define KEY_BRL_DOT7		0x1f7
>  #define KEY_BRL_DOT8		0x1f8
>  
> +#define KEY_DISPLAY_CYCLE	0x1f9
> +#define KEY_VIDEO_NEXT		0x1fa
> +#define KEY_VIDEO_PREV		0x1fb
> +#define KEY_BRIGHTNESS_CYCLE	0x1fc
> +#define KEY_BRIGHTNESS_ZERO	0x1fd
> +#define KEY_DISPLAY_OFF		0x1fe
> +
>  /* We avoid low common keys in module aliases so they don't get huge. */
>  #define KEY_MIN_INTERESTING	KEY_MUTE
>  #define KEY_MAX			0x1ff
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH V3 1/3] ACPI video hotkey: add new input key code for ACPI video hotkey events

[Len Brown]

Thanks for the refreshed patch series, Rui.
I've added it to acpi-test.

Still waiting on an ACK from Dmitry on the input.h definitions.

-Len

On Monday 20 August 2007 06:23, Zhang Rui wrote:
> From: Yu Luming <luming.yu@intel.com>
> 
> Add keycode for ACPI video driver hotkey events.
> 
> Signed-off-by: Yu Luming <luming.yu@intel.com>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> ---
>  include/linux/input.h |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> Index: linux-2.6.23-rc3/include/linux/input.h
> ===================================================================
> --- linux-2.6.23-rc3.orig/include/linux/input.h
> +++ linux-2.6.23-rc3/include/linux/input.h
> @@ -553,6 +553,13 @@ struct input_absinfo {
>  #define KEY_BRL_DOT7		0x1f7
>  #define KEY_BRL_DOT8		0x1f8
>  
> +#define KEY_DISPLAY_CYCLE	0x1f9
> +#define KEY_VIDEO_NEXT		0x1fa
> +#define KEY_VIDEO_PREV		0x1fb
> +#define KEY_BRIGHTNESS_CYCLE	0x1fc
> +#define KEY_BRIGHTNESS_ZERO	0x1fd
> +#define KEY_DISPLAY_OFF		0x1fe
> +
>  /* We avoid low common keys in module aliases so they don't get huge. */
>  #define KEY_MIN_INTERESTING	KEY_MUTE
>  #define KEY_MAX			0x1ff
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH V3 1/3] ACPI video hotkey: add new input key code for ACPI video hotkey events

[Dmitry Torokhov]

On 8/23/07, Len Brown <lenb@kernel.org> wrote:
> Thanks for the refreshed patch series, Rui.
> I've added it to acpi-test.
>
> Still waiting on an ACK from Dmitry on the input.h definitions.

Sorry, I am still trying to recover from a hard drive failure...

The keycodes conflict with a pending patch adding KEY_BRL_DOT9 and
KEY_BRL_DOT10 and so have to be moved somewhere else.

-- 
Dmitry

Re: [PATCH V3 1/3] ACPI video hotkey: add new input key code for ACPI video hotkey events

[Henrique de Moraes Holschuh]

On Thu, 23 Aug 2007, Dmitry Torokhov wrote:
> On 8/23/07, Len Brown <lenb@kernel.org> wrote:
> > Thanks for the refreshed patch series, Rui.
> > I've added it to acpi-test.
> >
> > Still waiting on an ACK from Dmitry on the input.h definitions.
> 
> Sorry, I am still trying to recover from a hard drive failure...
> 
> The keycodes conflict with a pending patch adding KEY_BRL_DOT9 and
> KEY_BRL_DOT10 and so have to be moved somewhere else.

Also, this one:
+#define KEY_DISPLAY_CYCLE      0x1f9                                                                                                      

Should probably be
#define KEY_DISPLAY_CYCLE	KEY_SWITCHVIDEOMODE

According to what was explained to us (thinkpad-acpi and the other laptop
hotkey drivers).

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [PATCH V3 1/3] ACPI video hotkey: add new input key code for ACPI video hotkey events

[Len Brown]

On Thursday 23 August 2007 17:22, Henrique de Moraes Holschuh wrote:
> On Thu, 23 Aug 2007, Dmitry Torokhov wrote:
> > On 8/23/07, Len Brown <lenb@kernel.org> wrote:
> > > Thanks for the refreshed patch series, Rui.
> > > I've added it to acpi-test.
> > >
> > > Still waiting on an ACK from Dmitry on the input.h definitions.
> > 
> > Sorry, I am still trying to recover from a hard drive failure...
> > 
> > The keycodes conflict with a pending patch adding KEY_BRL_DOT9 and
> > KEY_BRL_DOT10 and so have to be moved somewhere else.
> 
> Also, this one:
> +#define KEY_DISPLAY_CYCLE      0x1f9                                                                                                      
> 
> Should probably be
> #define KEY_DISPLAY_CYCLE	KEY_SWITCHVIDEOMODE
> 
> According to what was explained to us (thinkpad-acpi and the other laptop
> hotkey drivers).

I agree.  I noticed this also
and I'll send a refreshed patch shortly.

thanks,
-Len

Re: [PATCH V3 1/3] ACPI video hotkey: add new input key code for ACPI video hotkey events

[Len Brown]

On Thursday 23 August 2007 16:10, Dmitry Torokhov wrote:
> On 8/23/07, Len Brown <lenb@kernel.org> wrote:
> > Thanks for the refreshed patch series, Rui.
> > I've added it to acpi-test.
> >
> > Still waiting on an ACK from Dmitry on the input.h definitions.
> 
> Sorry, I am still trying to recover from a hard drive failure...
> 
> The keycodes conflict with a pending patch adding KEY_BRL_DOT9 and
> KEY_BRL_DOT10 and so have to be moved somewhere else.
> 

Okay, I moved them to lower numbers
(no clue why the 1st part of the list is decimal and the
 later part is hex).

and I omitted KEY_DISPLAY_CYCLE in favor of re-using
the existing KEY_SWITCHVIDEOMODE.

thanks,
-Len
---
commit a7ecd1ea913346a72f41a002c365882dc05c9bd5
Author: Yu Luming <luming.yu@intel.com>
Date:   Thu Aug 23 23:05:55 2007 -0400

    ACPI: video: Add keycode for ACPI video driver hotkey events.
    
    Signed-off-by: Luming Yu <luming.yu@intel.com>
    Signed-off-by: Zhang Rui <rui.zhang@intel.com>
    Signed-off-by: Len Brown <len.brown@intel.com>

diff --git a/include/linux/input.h b/include/linux/input.h
index e02c6a6..cf2b561 100644
--- a/include/linux/input.h
+++ b/include/linux/input.h
@@ -363,6 +363,12 @@ struct input_absinfo {
 
 #define KEY_UNKNOWN		240
 
+#define KEY_VIDEO_NEXT		241	/* drive next video source */
+#define KEY_VIDEO_PREV		242	/* drive previous video source */
+#define KEY_BRIGHTNESS_CYCLE	243	/* brightness up, after max is min */
+#define KEY_BRIGHTNESS_ZERO	244	/* brightness off, use ambient */
+#define KEY_DISPLAY_OFF		245	/* display device to off state */
+
 #define BTN_MISC		0x100
 #define BTN_0			0x100
 #define BTN_1			0x101