From: Matt Whitlock <linux@mattwhitlock.name>
To: Henrik Rydberg <rydberg@bitmath.org>
Cc: linux-input@vger.kernel.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] Input: bcm5974 - report highest finger pressure to Synaptics
Date: Wed, 03 Jun 2015 08:31:03 -0400 [thread overview]
Message-ID: <119471698.ELkjzU3HSk@crushinator> (raw)
In-Reply-To: <556EF1F2.50907@bitmath.org>
On Wednesday, 3 June 2015, at 2:24 pm, Henrik Rydberg wrote:
> > This patch changes the report_synaptics_data() function so that it reports
> > the highest touch_major and highest tool_major of any touching finger as
> > ABS_PRESSURE and ABS_TOOL_WIDTH, respectively.
>
> I appreciate the problem, but I would much rather have bcm5974 converted
> to use input_mt_report_pointer_emulation() instead. The emulation code
> has been left as is for a long while, but this seems to be a good time
> to convert it.
report_tp_state() calls input_mt_sync_frame(), which in turn calls input_mt_report_pointer_emulation() already. So does this mean that report_synaptics_data() can be removed entirely?
next prev parent reply other threads:[~2015-06-03 12:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 11:49 [PATCH] Input: bcm5974 - report highest finger pressure to Synaptics Matt Whitlock
2015-06-03 12:24 ` Henrik Rydberg
2015-06-03 12:31 ` Matt Whitlock [this message]
2015-06-03 12:52 ` Henrik Rydberg
2015-06-09 1:07 ` [PATCH 1/2] Input: input_mt_report_pointer_emulation(), rescale pressure + tool width Matt Whitlock
2015-06-09 1:07 ` [PATCH 2/2] Input: bcm5974 - report ABS_MT_PRESSURE + remove redundant emulation code Matt Whitlock
2015-07-06 18:37 ` Matt Whitlock
2015-07-06 19:11 ` Henrik Rydberg
2015-07-06 19:35 ` Matt Whitlock
2015-07-06 19:44 ` Henrik Rydberg
2015-07-06 19:59 ` Matt Whitlock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=119471698.ELkjzU3HSk@crushinator \
--to=linux@mattwhitlock.name \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).