From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arek Burdach Subject: Re: Missing release event for Synaptics touchscreen Date: Wed, 7 Jun 2017 09:27:39 +0200 Message-ID: <11ceaddd-41ad-c7fe-1ab0-453d2b1a57e1@gmail.com> References: <708339c2-2b70-81ae-a939-ac122e5fd6f2@gmail.com> <8566ae03-faad-a1ee-2156-db49d36cea71@ginzinger.com> <540cd246-d72f-a9eb-9618-ff2449384a21@ginzinger.com> <8d690a3d-88f6-cef9-b271-da5dcc87741b@gmail.com> <12ac2e90-ba7b-8a29-bb35-40d50841a63b@ginzinger.com> <27a556e7-2045-2d6a-3b13-287d314375d5@gmail.com> <699f72dc-25fe-3ffb-a20a-7800a09f0c86@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:35731 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbdFGH1n (ORCPT ); Wed, 7 Jun 2017 03:27:43 -0400 Received: by mail-wm0-f68.google.com with SMTP id g15so1133925wmc.2 for ; Wed, 07 Jun 2017 00:27:42 -0700 (PDT) In-Reply-To: <699f72dc-25fe-3ffb-a20a-7800a09f0c86@gmail.com> Content-Language: en-US Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Benjamin Tissoires Cc: Martin Kepplinger , Andrew Duggan , =?UTF-8?Q?St=c3=a9phane_Chatty?= , linux-input Hi Benjamin, On 16.05.2017 11:46, Arek Burdach wrote: > > > On 16.05.2017 10:18, Benjamin Tissoires wrote: >> On Mon, May 15, 2017 at 8:45 PM, Arek Burdach >> wrote: >>> Hi Benjamin, >>> >>> I found out what was wrong in the change that you've provided: >>> >>> On 12.05.2017 16:28, Benjamin Tissoires wrote: >>> >>> + if (td->mtclass.quirks & MT_QUIRK_STICKY_FINGERS) >>> + mod_timer(&td->release_timer, msecs_to_jiffies(250)); >>> } >>> >>> Should be: >>> >>> mod_timer(&td->release_timer, jiffies + msecs_to_jiffies(100)); >> Right, thanks! >> >>> Delay should be added to current jiffies value. Also I found out >>> that 250 ms >>> is too long delay - xserver recognize such a delay as a drag >>> gesture. Using >>> 100 ms everything works perfectly! >> Does 160 ms works too? > 160 ms works too but I have a feeling that values closer to 200 ms > gives quite a laggy experience so I'd suggest to keep value closer to > 100 ms. Beside that I haven't seen situation that "normal" syn_report > have been repored after longer delay than 30 ms. Mean value is 9 ms > and 95 pp ~10 ms (tested by drags with evemu-record) > >> I'd rather have 10 times the maximum time >> between 2 reports than 6.25 times it :) >> We can use 96 ms if 160 doesn't work. > In fact 100 ms it is exactly 6 times the maximum time between 2 > reports, because 60 Hz frequency gives 16,(6) ms period > >>> What do you think that should be changed >>> more in the patch to make it ready for being submitted as an >>> official patch? >> Not much actually. I need to wrote down a commit message, sign it >> (your sign-off-by can also be added given that you debugged it), and >> that should be it. Do you planning to submit this change? I think that other users would be glad to take advantage of this fix :-) Or do you want me to do it on your behalf? >> >>> I thought about some unit tests, but can't find any for hid drivers >>> also I >> I have a test suite that can emulate hid devices and inject them in >> hid-multitouch. The setup is a little bit manual, so I'll try to run >> it today and see if there are differences with or without the patch. > Ok, waiting for signed patch Cheers, Arek