From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-input@vger.kernel.org,
Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH] i2c: ACPI: Do not check ACPI_FADT_LOW_POWER_S0
Date: Fri, 05 Aug 2022 18:51:11 +0200 [thread overview]
Message-ID: <12042830.O9o76ZdvQC@kreacher> (raw)
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
The ACPI_FADT_LOW_POWER_S0 flag merely means that it is better to
use low-power S0 idle on the given platform than S3 (provided that
the latter is supported) and it doesn't preclude using either of
them (which of them will be used depends on the choices made by user
space).
Because of that, ACPI_FADT_LOW_POWER_S0 is generally not sufficient
for making decisions in device drivers and so i2c_hid_acpi_probe()
should not use it.
Moreover, Linux always supports suspend-to-idle, so if a given
device can wake up the system from suspend-to-idle, then it can be
marked as wakeup capable unconditionally, so make that happen in
i2c_hid_acpi_probe().
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/hid/i2c-hid/i2c-hid-acpi.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
Index: linux-pm/drivers/hid/i2c-hid/i2c-hid-acpi.c
===================================================================
--- linux-pm.orig/drivers/hid/i2c-hid/i2c-hid-acpi.c
+++ linux-pm/drivers/hid/i2c-hid/i2c-hid-acpi.c
@@ -105,10 +105,8 @@ static int i2c_hid_acpi_probe(struct i2c
acpi_device_fix_up_power(adev);
- if (acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0) {
- device_set_wakeup_capable(dev, true);
- device_set_wakeup_enable(dev, false);
- }
+ device_set_wakeup_capable(dev, true);
+ device_set_wakeup_enable(dev, false);
return i2c_hid_core_probe(client, &ihid_acpi->ops,
hid_descriptor_address, 0);
next reply other threads:[~2022-08-05 16:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 16:51 Rafael J. Wysocki [this message]
2022-08-05 16:59 ` [PATCH] i2c: ACPI: Do not check ACPI_FADT_LOW_POWER_S0 Limonciello, Mario
2022-08-05 17:08 ` Rafael J. Wysocki
2022-08-05 18:54 ` Hans de Goede
2022-08-06 2:19 ` Raul Rangel
2022-08-08 17:10 ` Rafael J. Wysocki
2022-08-26 21:48 ` Raul Rangel
2022-08-30 17:10 ` Raul Rangel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12042830.O9o76ZdvQC@kreacher \
--to=rjw@rjwysocki.net \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox